[PATCH 09/13] qemuPrepareNVRAM: Refuse conversion of NVRAM backing file format

Peter Krempa posted 13 patches 2 weeks, 2 days ago
[PATCH 09/13] qemuPrepareNVRAM: Refuse conversion of NVRAM backing file format
Posted by Peter Krempa 2 weeks, 2 days ago
Refuse situations where the user configures a different format for a
file-backed nvram than the template file has.

At this point it's still required that the NVRAM and firmware share
format, but that is going to be relaxed, thus we need to refuse
configurations that the code can't handle.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_process.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 7a40e09d47..d134de532c 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -4624,6 +4624,12 @@ qemuPrepareNVRAM(virQEMUDriver *driver,
         return -1;
     }

+    if (loader->nvram->format != loader->nvramTemplateFormat) {
+        virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
+                       _("conversion of the nvram template to another target format is not supported"));
+        return -1;
+    }
+
     if ((srcFD = virFileOpenAs(loader->nvramTemplate, O_RDONLY,
                                0, -1, -1, 0)) < 0) {
         virReportSystemError(-srcFD,
-- 
2.47.0