[PATCH 2/2] testutilsqemuschema: Support 'unstable' feature in QMP schema validator

Peter Krempa posted 2 patches 1 year, 4 months ago
[PATCH 2/2] testutilsqemuschema: Support 'unstable' feature in QMP schema validator
Posted by Peter Krempa 1 year, 4 months ago
The 'unstable' feature is present on any schema member which was not yet
finalized in qemu. Use it to refuse such fields/commands in qemu as they
are possibly subject to change.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 tests/testutilsqemuschema.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/testutilsqemuschema.c b/tests/testutilsqemuschema.c
index bb3d6b3141..6ee83c3ba7 100644
--- a/tests/testutilsqemuschema.c
+++ b/tests/testutilsqemuschema.c
@@ -32,6 +32,7 @@ struct testQEMUSchemaValidateCtxt {
 /**
  * Validate that the schema member doesn't have some significant features:
  * - 'deprecated' - schema member is deprecated
+ * - 'unstable' - schema member is considered unstable
  */
 static int
 testQEMUSchemaValidateFeatures(virJSONValue *root,
@@ -57,6 +58,11 @@ testQEMUSchemaValidateFeatures(virJSONValue *root,
             return -2;
         }

+        if (STREQ(curstr, "unstable")) {
+            virBufferAsprintf(ctxt->debug, "ERROR: '%s' is unstable", name);
+            return -1;
+        }
+
         if (STREQ(curstr, "deprecated")) {
             if (ctxt->allowDeprecated) {
                 virBufferAsprintf(ctxt->debug, "WARNING: '%s' is deprecated", name);
-- 
2.46.0