The value 100 represented the percentage as it was originally done from
Intel in the Linux kernel and on their CPUs.  Since then the situation
changed and there is no error-prone way of figuring out the meaning of
the value in the current configuration, let alone its possible maximum.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---
 src/util/virresctrl.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c
index 8ed111c182e7..e0a7a3e12759 100644
--- a/src/util/virresctrl.c
+++ b/src/util/virresctrl.c
@@ -1269,12 +1269,6 @@ virResctrlAllocSetMemoryBandwidth(virResctrlAlloc *alloc,
 {
     virResctrlAllocMemBW *mem_bw = alloc->mem_bw;
 
-    if (memory_bandwidth > 100) {
-        virReportError(VIR_ERR_XML_ERROR, "%s",
-                       _("Memory Bandwidth value exceeding 100 is invalid."));
-        return -1;
-    }
-
     if (!mem_bw) {
         mem_bw = g_new0(virResctrlAllocMemBW, 1);
         alloc->mem_bw = mem_bw;
-- 
2.46.0

On 9/12/24 16:47, Martin Kletzander wrote:
> The value 100 represented the percentage as it was originally done from
> Intel in the Linux kernel and on their CPUs.  Since then the situation

s/  / /

and I'm just gonna stop pointing that out. You get the picture by now.

> changed and there is no error-prone way of figuring out the meaning of
> the value in the current configuration, let alone its possible maximum.
> 
> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
> ---
>  src/util/virresctrl.c | 6 ------
>  1 file changed, 6 deletions(-)

Michal

On Fri, Sep 13, 2024 at 11:09:25AM +0200, Michal Prívozník wrote:
>On 9/12/24 16:47, Martin Kletzander wrote:
>> The value 100 represented the percentage as it was originally done from
>> Intel in the Linux kernel and on their CPUs.  Since then the situation
>
>s/  / /
>
>and I'm just gonna stop pointing that out. You get the picture by now.
>

It's weird that you noticed now and not earlier.  I always used two
spaces after a sentence and we even talked about it at some point on the
list (not sure if that was with you though).

I wanted to check how many times this is visible in the code and lo and
behold, it is also used in all the license file headers.

>> changed and there is no error-prone way of figuring out the meaning of
>> the value in the current configuration, let alone its possible maximum.
>>
>> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
>> ---
>>  src/util/virresctrl.c | 6 ------
>>  1 file changed, 6 deletions(-)
>
>Michal
>