[PATCH 1/4] vircommand: Drop unused arguments from virCommandMassCloseGetFDs*()

Michal Privoznik posted 4 patches 2 months, 3 weeks ago
[PATCH 1/4] vircommand: Drop unused arguments from virCommandMassCloseGetFDs*()
Posted by Michal Privoznik 2 months, 3 weeks ago
Both virCommandMassCloseGetFDsLinux() and
virCommandMassCloseGetFDsGeneric() take @cmd argument only to
mark it as unused. Drop it from both.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/util/vircommand.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/util/vircommand.c b/src/util/vircommand.c
index a03fcc37ae..8bd5e5e771 100644
--- a/src/util/vircommand.c
+++ b/src/util/vircommand.c
@@ -478,8 +478,7 @@ virExecCommon(virCommand *cmd, gid_t *groups, int ngroups)
  * onto child process (well, the one we will exec soon since this
  * is called from the child). */
 static int
-virCommandMassCloseGetFDsLinux(virCommand *cmd G_GNUC_UNUSED,
-                               virBitmap *fds)
+virCommandMassCloseGetFDsLinux(virBitmap *fds)
 {
     g_autoptr(DIR) dp = NULL;
     struct dirent *entry;
@@ -511,8 +510,7 @@ virCommandMassCloseGetFDsLinux(virCommand *cmd G_GNUC_UNUSED,
 # else /* !__linux__ */
 
 static int
-virCommandMassCloseGetFDsGeneric(virCommand *cmd G_GNUC_UNUSED,
-                                 virBitmap *fds)
+virCommandMassCloseGetFDsGeneric(virBitmap *fds)
 {
     virBitmapSetAll(fds);
     return 0;
@@ -547,10 +545,10 @@ virCommandMassCloseFrom(virCommand *cmd,
     fds = virBitmapNew(openmax);
 
 # ifdef __linux__
-    if (virCommandMassCloseGetFDsLinux(cmd, fds) < 0)
+    if (virCommandMassCloseGetFDsLinux(fds) < 0)
         return -1;
 # else
-    if (virCommandMassCloseGetFDsGeneric(cmd, fds) < 0)
+    if (virCommandMassCloseGetFDsGeneric(fds) < 0)
         return -1;
 # endif
 
-- 
2.44.2
Re: [PATCH 1/4] vircommand: Drop unused arguments from virCommandMassCloseGetFDs*()
Posted by Martin Kletzander 2 months, 1 week ago
On Wed, Aug 28, 2024 at 02:16:14PM +0200, Michal Privoznik wrote:
>Both virCommandMassCloseGetFDsLinux() and
>virCommandMassCloseGetFDsGeneric() take @cmd argument only to
>mark it as unused. Drop it from both.
>
>Signed-off-by: Michal Privoznik <mprivozn@redhat.com>

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>