qemu: Don't crash on empty USB cdrom hotplug

[PATCH 0/2] qemu: Don't crash on empty USB cdrom hotplug

Peter Krempa posted 2 patches 1 year, 5 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1723819310.git.pkrempa@redhat.com

src/qemu/qemu_block.c                         |  3 ++
src/qemu/qemu_validate.c                      |  6 ++++
.../disk-cdrom-bus-other.x86_64-latest.args   |  5 ++--
.../disk-cdrom-bus-other.x86_64-latest.xml    |  5 ----
.../qemuxmlconfdata/disk-cdrom-bus-other.xml  |  5 ----
.../disk-cdrom-usb-empty.x86_64-latest.err    |  1 +
.../qemuxmlconfdata/disk-cdrom-usb-empty.xml  | 29 +++++++++++++++++++
tests/qemuxmlconftest.c                       |  1 +
8 files changed, 42 insertions(+), 13 deletions(-)
create mode 100644 tests/qemuxmlconfdata/disk-cdrom-usb-empty.x86_64-latest.err
create mode 100644 tests/qemuxmlconfdata/disk-cdrom-usb-empty.xml

Expand all Fold all

[PATCH 0/2] qemu: Don't crash on empty USB cdrom hotplug

Posted by Peter Krempa 1 year, 5 months ago

Fix the main crash cause and also forbid empty USB devices as qemu
doesn't accept them.

Peter Krempa (2):
  qemu: block: Allow NULL 'data' in 'qemuBlockStorageSourceChainDetach'
  qemu: validate: Reject empty USB disks

 src/qemu/qemu_block.c                         |  3 ++
 src/qemu/qemu_validate.c                      |  6 ++++
 .../disk-cdrom-bus-other.x86_64-latest.args   |  5 ++--
 .../disk-cdrom-bus-other.x86_64-latest.xml    |  5 ----
 .../qemuxmlconfdata/disk-cdrom-bus-other.xml  |  5 ----
 .../disk-cdrom-usb-empty.x86_64-latest.err    |  1 +
 .../qemuxmlconfdata/disk-cdrom-usb-empty.xml  | 29 +++++++++++++++++++
 tests/qemuxmlconftest.c                       |  1 +
 8 files changed, 42 insertions(+), 13 deletions(-)
 create mode 100644 tests/qemuxmlconfdata/disk-cdrom-usb-empty.x86_64-latest.err
 create mode 100644 tests/qemuxmlconfdata/disk-cdrom-usb-empty.xml

-- 
2.46.0