[PATCH v2 0/2] conf: Validate QoS values

Michal Privoznik posted 2 patches 3 months, 1 week ago
src/conf/domain_validate.c         |  9 +++++++
src/conf/netdev_bandwidth_conf.c   | 42 ++++++++++++++++++++++++++++++
src/conf/netdev_bandwidth_conf.h   |  2 ++
src/conf/schemas/networkcommon.rng |  3 ++-
src/libvirt_private.syms           |  1 +
src/network/bridge_driver.c        |  4 +++
6 files changed, 60 insertions(+), 1 deletion(-)
[PATCH v2 0/2] conf: Validate QoS values
Posted by Michal Privoznik 3 months, 1 week ago
v2 of:

https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/EDR7ILY66RE2Q2DRLXURO3CVHA2CDG65/

diff to v1:
- Validate in validation phase of XML parsing, or since network XML
  doesn't have validation phase, do it during network start (just like
  other stuff)

Michal Prívozník (2):
  conf: Introduce virNetDevBandwidthValidate()
  conf: Validate QoS values

 src/conf/domain_validate.c         |  9 +++++++
 src/conf/netdev_bandwidth_conf.c   | 42 ++++++++++++++++++++++++++++++
 src/conf/netdev_bandwidth_conf.h   |  2 ++
 src/conf/schemas/networkcommon.rng |  3 ++-
 src/libvirt_private.syms           |  1 +
 src/network/bridge_driver.c        |  4 +++
 6 files changed, 60 insertions(+), 1 deletion(-)

-- 
2.44.2
Re: [PATCH v2 0/2] conf: Validate QoS values
Posted by Peter Krempa 3 months, 1 week ago
On Tue, Aug 13, 2024 at 14:58:58 +0200, Michal Privoznik wrote:
> v2 of:
> 
> https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/EDR7ILY66RE2Q2DRLXURO3CVHA2CDG65/
> 
> diff to v1:
> - Validate in validation phase of XML parsing, or since network XML
>   doesn't have validation phase, do it during network start (just like
>   other stuff)

The latter makes sense. We even re-validate the definition of VMs when
starting up.

Reviewed-by: Peter Krempa <pkrempa@redhat.com>