On 8/9/24 14:40, Peter Krempa wrote:
> Patch 3/3 adds the actual test:
>
> Changes to v1:
> - fixed missing NULL termination of the 'skip' array
> - "backported" g_string_replace into glibcompat.c until we bump minimum
> glib
> - started striping 'abs_srcdir' strings from qemuxmlconftest's '.err'
> output files
>
> Peter Krempa (3):
> glibcompat: "Backport" 'g_string_replace'
> testQemuConfXMLCommon: Strip 'abs_srcdir' paths from '.err' files in
> qemuxmlconftest
> qemuxmlconftest: Add test cases for broken and missing XML files
>
> src/libvirt_private.syms | 1 +
> src/util/glibcompat.c | 65 +++++++++++++++++++
> src/util/glibcompat.h | 10 +++
> .../broken-xml-invalid.x86_64-latest.err | 3 +
> tests/qemuxmlconfdata/broken-xml-invalid.xml | 1 +
> .../nonexistent-file.x86_64-latest.err | 1 +
> tests/qemuxmlconftest.c | 16 ++++-
> tests/testutilsqemu.h | 1 +
> tests/virschematest.c | 12 ++++
> 9 files changed, 107 insertions(+), 3 deletions(-)
> create mode 100644 tests/qemuxmlconfdata/broken-xml-invalid.x86_64-latest.err
> create mode 100644 tests/qemuxmlconfdata/broken-xml-invalid.xml
> create mode 100644 tests/qemuxmlconfdata/nonexistent-file.x86_64-latest.err
>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Michal