virsysinfo: Be more forgiving when decoding OEM strings

[PATCH 0/5] virsysinfo: Be more forgiving when decoding OEM strings

Michal Privoznik posted 5 patches 1 month, 3 weeks ago

Download series mbox

src/util/vircommand.c                         |   2 +-
src/util/virsysinfo.c                         |  36 +++-
.../aarch64-hpe-apollosysinfo.data            | 162 ++++++++++++++++++
.../aarch64-hpe-apollosysinfo.expect          |  88 ++++++++++
tests/sysinfotest.c                           |   9 +-
5 files changed, 285 insertions(+), 12 deletions(-)
create mode 100644 tests/sysinfodata/aarch64-hpe-apollosysinfo.data
create mode 100644 tests/sysinfodata/aarch64-hpe-apollosysinfo.expect

Expand all Fold all

[PATCH 0/5] virsysinfo: Be more forgiving when decoding OEM strings

Posted by Michal Privoznik 1 month, 3 weeks ago

See 4/5 for explanation.

Michal Prívozník (5):
  vircommand: Initialize dryRunStatus to portable EXIT_SUCCESS instead
    of 0
  virsysinfo: Trim newline when decoding OEM strings
  tests: Add HPE Apollo test case to sysinfotest
  virsysinfo: Be more forgiving when decoding OEM strings
  virsysinfo: Calculate OEM string index better

 src/util/vircommand.c                         |   2 +-
 src/util/virsysinfo.c                         |  36 +++-
 .../aarch64-hpe-apollosysinfo.data            | 162 ++++++++++++++++++
 .../aarch64-hpe-apollosysinfo.expect          |  88 ++++++++++
 tests/sysinfotest.c                           |   9 +-
 5 files changed, 285 insertions(+), 12 deletions(-)
 create mode 100644 tests/sysinfodata/aarch64-hpe-apollosysinfo.data
 create mode 100644 tests/sysinfodata/aarch64-hpe-apollosysinfo.expect

-- 
2.44.2

Re: [PATCH 0/5] virsysinfo: Be more forgiving when decoding OEM strings

Posted by Jiri Denemark 1 month, 2 weeks ago

On Thu, Jul 18, 2024 at 16:08:02 +0200, Michal Privoznik wrote:
> See 4/5 for explanation.
> 
> Michal Prívozník (5):
>   vircommand: Initialize dryRunStatus to portable EXIT_SUCCESS instead
>     of 0
>   virsysinfo: Trim newline when decoding OEM strings
>   tests: Add HPE Apollo test case to sysinfotest
>   virsysinfo: Be more forgiving when decoding OEM strings
>   virsysinfo: Calculate OEM string index better
> 
>  src/util/vircommand.c                         |   2 +-
>  src/util/virsysinfo.c                         |  36 +++-
>  .../aarch64-hpe-apollosysinfo.data            | 162 ++++++++++++++++++
>  .../aarch64-hpe-apollosysinfo.expect          |  88 ++++++++++
>  tests/sysinfotest.c                           |   9 +-
>  5 files changed, 285 insertions(+), 12 deletions(-)
>  create mode 100644 tests/sysinfodata/aarch64-hpe-apollosysinfo.data
>  create mode 100644 tests/sysinfodata/aarch64-hpe-apollosysinfo.expect

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>