vsh: Fix handling of '--help' for all commands

[PATCH 0/3] vsh: Fix handling of '--help' for all commands

Peter Krempa posted 3 patches 6 months, 1 week ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1715756627.git.pkrempa@redhat.com

NEWS.rst                            | 15 +++++++
tests/virshtest.c                   |  3 ++
tests/virshtestdata/help-option.in  |  4 ++
tests/virshtestdata/help-option.out | 64 +++++++++++++++++++++++++++++
tools/vsh.c                         |  5 ++-
5 files changed, 90 insertions(+), 1 deletion(-)
create mode 100644 tests/virshtestdata/help-option.in
create mode 100644 tests/virshtestdata/help-option.out

Expand all Fold all

[PATCH 0/3] vsh: Fix handling of '--help' for all commands

Posted by Peter Krempa 6 months, 1 week ago

Brown paper box was applied due to lack of paper bags.

Peter Krempa (3):
  vsh: Fix '--help' option for virsh/virt-admin
  virshtest: Add tests for '--help'
  NEWS: Mention '--help' bug in virsh and virt-admin

 NEWS.rst                            | 15 +++++++
 tests/virshtest.c                   |  3 ++
 tests/virshtestdata/help-option.in  |  4 ++
 tests/virshtestdata/help-option.out | 64 +++++++++++++++++++++++++++++
 tools/vsh.c                         |  5 ++-
 5 files changed, 90 insertions(+), 1 deletion(-)
 create mode 100644 tests/virshtestdata/help-option.in
 create mode 100644 tests/virshtestdata/help-option.out

-- 
2.45.0

Re: [PATCH 0/3] vsh: Fix handling of '--help' for all commands

Posted by Martin Kletzander 6 months, 1 week ago

On Wed, May 15, 2024 at 09:04:37AM +0200, Peter Krempa wrote:
>Brown paper box was applied due to lack of paper bags.
>
>Peter Krempa (3):
>  vsh: Fix '--help' option for virsh/virt-admin
>  virshtest: Add tests for '--help'
>  NEWS: Mention '--help' bug in virsh and virt-admin

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

>
> NEWS.rst                            | 15 +++++++
> tests/virshtest.c                   |  3 ++
> tests/virshtestdata/help-option.in  |  4 ++
> tests/virshtestdata/help-option.out | 64 +++++++++++++++++++++++++++++
> tools/vsh.c                         |  5 ++-
> 5 files changed, 90 insertions(+), 1 deletion(-)
> create mode 100644 tests/virshtestdata/help-option.in
> create mode 100644 tests/virshtestdata/help-option.out
>
>-- 
>2.45.0
>