[PATCH 03/13] testutilsqemu: Don't leak struct testQemuArgs::vdpafds

Michal Privoznik posted 13 patches 1 year, 9 months ago
There is a newer version of this series
[PATCH 03/13] testutilsqemu: Don't leak struct testQemuArgs::vdpafds
Posted by Michal Privoznik 1 year, 9 months ago
Allocated in testQemuInfoSetArgs(), the vdpafds member of
testQemuArgs is never freed.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 tests/testutilsqemu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c
index 9c12a165b1..d70850cb5d 100644
--- a/tests/testutilsqemu.c
+++ b/tests/testutilsqemu.c
@@ -966,6 +966,7 @@ testQemuInfoFree(testQemuInfo *info)
     g_clear_pointer(&info->args.fakeCapsAdd, virBitmapFree);
     g_clear_pointer(&info->args.fakeCapsDel, virBitmapFree);
     g_clear_pointer(&info->args.fds, g_hash_table_unref);
+    g_clear_pointer(&info->args.vdpafds, g_hash_table_unref);
     g_clear_object(&info->nbdkitCaps);
     g_clear_pointer(&info->args.fakeNbdkitCaps, virBitmapFree);
     g_free(info);
-- 
2.43.2
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org
Re: [PATCH 03/13] testutilsqemu: Don't leak struct testQemuArgs::vdpafds
Posted by Daniel P. Berrangé 1 year, 9 months ago
On Mon, May 06, 2024 at 10:43:00AM +0200, Michal Privoznik wrote:
> Allocated in testQemuInfoSetArgs(), the vdpafds member of
> testQemuArgs is never freed.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  tests/testutilsqemu.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org