[PATCH v3 1/5] test: Fix `virsh nodedev-list`

Cole Robinson posted 5 patches 1 year, 10 months ago
There is a newer version of this series
[PATCH v3 1/5] test: Fix `virsh nodedev-list`
Posted by Cole Robinson 1 year, 10 months ago
$ virsh --connect test:///default nodedev-list
error: Failed to list node devices
error: unsupported flags (0x80000000) in function testConnectListAllNodeDevices

The test driver handles the nodedev state flags, we just need to
allow them

Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
 src/test/test_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index ed0cdc0dab..852a084bce 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -7481,7 +7481,7 @@ testConnectListAllNodeDevices(virConnectPtr conn,
 {
     testDriver *driver = conn->privateData;
 
-    virCheckFlags(VIR_CONNECT_LIST_NODE_DEVICES_FILTERS_CAP, -1);
+    virCheckFlags(VIR_CONNECT_LIST_NODE_DEVICES_FILTERS_ALL, -1);
 
     return virNodeDeviceObjListExport(conn, driver->devs, devices,
                                       NULL, flags);
-- 
2.44.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org
Re: [PATCH v3 1/5] test: Fix `virsh nodedev-list`
Posted by Boris Fiuczynski 1 year, 10 months ago
Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com>

On 4/9/24 16:56, Cole Robinson wrote:
> $ virsh --connect test:///default nodedev-list
> error: Failed to list node devices
> error: unsupported flags (0x80000000) in function testConnectListAllNodeDevices
> 
> The test driver handles the nodedev state flags, we just need to
> allow them
> 
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
>   src/test/test_driver.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/test/test_driver.c b/src/test/test_driver.c
> index ed0cdc0dab..852a084bce 100644
> --- a/src/test/test_driver.c
> +++ b/src/test/test_driver.c
> @@ -7481,7 +7481,7 @@ testConnectListAllNodeDevices(virConnectPtr conn,
>   {
>       testDriver *driver = conn->privateData;
>   
> -    virCheckFlags(VIR_CONNECT_LIST_NODE_DEVICES_FILTERS_CAP, -1);
> +    virCheckFlags(VIR_CONNECT_LIST_NODE_DEVICES_FILTERS_ALL, -1);
>   
>       return virNodeDeviceObjListExport(conn, driver->devs, devices,
>                                         NULL, flags);

-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org