vsh: Fix handling of commands and help - part 2 (unwanted positional parsing of optional arguments)

[PATCH 20/28] virsh-backup: Fix argument annotations of 'backup-begin' command

Posted by Peter Krempa 1 year, 11 months ago

Mark the 'backupxml' as positional optional and the 'checkpointxml' as
'unwanted_positional' to preserve the positioanl parsing quirk.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 tools/virsh-backup.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/virsh-backup.c b/tools/virsh-backup.c
index 7a7834d7ff..52325b5ca0 100644
--- a/tools/virsh-backup.c
+++ b/tools/virsh-backup.c
@@ -34,11 +34,13 @@ static const vshCmdOptDef opts_backup_begin[] = {
     VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_ACTIVE),
     {.name = "backupxml",
      .type = VSH_OT_STRING,
+     .positional = true,
      .completer = virshCompletePathLocalExisting,
      .help = N_("domain backup XML"),
     },
     {.name = "checkpointxml",
      .type = VSH_OT_STRING,
+     .unwanted_positional = true,
      .completer = virshCompletePathLocalExisting,
      .help = N_("domain checkpoint XML"),
     },
-- 
2.44.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

Re: [PATCH 20/28] virsh-backup: Fix argument annotations of 'backup-begin' command

Posted by Ján Tomko 1 year, 10 months ago

On a Friday in 2024, Peter Krempa wrote:
>Mark the 'backupxml' as positional optional and the 'checkpointxml' as
>'unwanted_positional' to preserve the positioanl parsing quirk.

*positional

>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> tools/virsh-backup.c | 2 ++
> 1 file changed, 2 insertions(+)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org