vsh: Fix handling of commands and help - part 2 (unwanted positional parsing of optional arguments)

[PATCH 01/28] vshCmddefHelp: Drop empty line at the end

Posted by Peter Krempa 1 year, 11 months ago

All virsh commands in non-quiet mode append another separator line thus
having two is unnecessary and in quiet mode it still has a trailing
blank line. Remove it.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 tools/vsh.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/vsh.c b/tools/vsh.c
index f96071060a..e6ea3a398a 100644
--- a/tools/vsh.c
+++ b/tools/vsh.c
@@ -725,7 +725,6 @@ vshCmddefHelp(const vshCmdDef *def)
             fprintf(stdout, "    %-15s  %s\n", optstr, _(opt->help));
         }
     }
-    fputc('\n', stdout);

     return true;
 }
-- 
2.44.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

Re: [PATCH 01/28] vshCmddefHelp: Drop empty line at the end

Posted by Ján Tomko 1 year, 10 months ago

On a Friday in 2024, Peter Krempa wrote:
>All virsh commands in non-quiet mode append another separator line thus
>having two is unnecessary and in quiet mode it still has a trailing
>blank line. Remove it.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> tools/vsh.c | 1 -
> 1 file changed, 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org