On a Monday in 2024, Peter Krempa wrote:
>This series refactors the cruft in the virsh command and argument
>handling so that handling of options and the flags for them make
>actually sense.
>
>Except for the 'timeout' parameter of 'daemon-timeout' 'virt-admin'
>command the behaviour is supposed to be identical.
>
>Peter Krempa (23):
> vsh: Always assume that command groups are used
> vsh: Don't translate error messages for 'self-test'
> vsh: Add VSH_OT_NONE option type to catch programming errors
> vsh: Remove VSH_CMD_FLAG_ALIAS
> vshCmddefCheckInternals: Fix listing of missing completers for
> 'VSH_OT_ARGV'
> virsh: Remove uncommon redundant descriptions of virsh commands
> virt-admin: Drop trailing whitespaces from description of some
> commands
> virsh-domain: Don't explicitly break lines in help
> vsh: Add '--dump-help' option for 'self-test' command
> vsh: Refactor store of command help and description
> vshCmddefHelp: Refactor printing of help (list of arguments)
> vshCmddefHelp: Refactor printing of help (argument description)
> vshCmddefGetOption: Improve readability
> virsh: Inline only use of VIRSH_COMMON_OPT_DOMAIN_OT_ARGV macro
> vsh: Annotate 'required' and 'positional' arguments explicitly
> vsh: Fix broken assumption that required VSH_OT_INT must be positional
> vsh: Require that positional non-argv arguments are required
> vshCmddefCheckInternals: Remove refactoring safety checks
> vshCmdGrpHelp: Refactor formatting of help for VSH_OT_ARGV
> vshCmddefHelp: Refactor and fix printing of help for _STRING/_INT
> arguments
> vsh: Replace VSH_OT_DATA by VSH_OT_STRING
> vsh: remove VSH_OFLAG_REQ
> vsh: Automatically calculate VSH_OFLAG_REQ_OPT
>
> tools/virsh-backup.c | 29 +-
> tools/virsh-checkpoint.c | 109 +--
> tools/virsh-domain-event.c | 13 +-
> tools/virsh-domain-monitor.c | 207 ++--
> tools/virsh-domain.c | 1783 ++++++++++++----------------------
> tools/virsh-host.c | 311 ++----
> tools/virsh-interface.c | 217 ++---
> tools/virsh-network.c | 312 ++----
> tools/virsh-nodedev.c | 242 ++---
> tools/virsh-nwfilter.c | 144 +--
> tools/virsh-pool.c | 296 ++----
> tools/virsh-secret.c | 113 +--
> tools/virsh-snapshot.c | 137 +--
> tools/virsh-volume.c | 241 ++---
> tools/virsh.c | 22 +-
> tools/virsh.h | 29 +-
> tools/virt-admin.c | 275 ++----
> tools/vsh.c | 474 +++++----
> tools/vsh.h | 49 +-
> 19 files changed, 1798 insertions(+), 3205 deletions(-)
>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Jano
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org