This patchset removes the use of '-usb' legacy controller specification.

For the vast majority of platforms/machines (most of the irrelevant
ones) which don't actually have a concept of implicit USB qemu ignores
the '-usb' argument.

For the relevant platforms libvirt would already pick exactly the
same controller and thus '-usb' wouldn't be used at all.

There's a small handful of ARM boards 'realview' and 'versatilepb' where
libvirt would pick the wrong one as default if some controllers were
compiled out and thus reallistically '-usb' would have effect for those
although would be unusable as libvirt's bus name for the bus is incorret
and thus no devices would be usable.

For the two mostly obsolete board types this series can break ABI in the
aforementioned corner case.

Other than that this removes all the legacy code which makes USB
controller selection utterly confusing.

Peter Krempa (25):
  tests: Replace mentions of the removed 'qemucapabilitiesnumbering'
    tool
  qemucapabilitiesdata: Document faked caps dumps
  testutilshostcpus: Add support for VIR_ARCH_ARMV7L
  qemucapabilitiestest: Add test dump for 'armv7l' architecture
  qemu: domain: Add checkers for 'microvm' machine type
  qemu: Add basic framework for 'microvm' machine type
  qemuxmlconfdata: Add tests for USB controller selection with
    'versatilepb' machine on aarch64 qemu binary
  qemuxmlconfdata: Add tests for USB controller selection with
    'versatilepb' machine on arm qemu binary
  qemuDomainDefAddDefaultDevices: Handle defaults for all ARM arches
    together
  qemuDomainControllerDefPostParse: Use proper enum value for default
    USB controller model
  qemuDomainDefAddDefaultDevices: Populate default USB for 'versatilepb'
    and 'realview' ARM machines
  qemuDomainControllerDefPostParse: Use 'pci-ohci' as last-resort
    fallback USB controller
  qemuxmlconftest: Add test for 'realview' machine
  qemuxmlconftest: Add test data for an ARM machine where qemu doesn't
    honour -usb
  qemuxml2conftest: Consolidate usb controller tests for 'pseries'
    machine
  qemuxmlconftest: Add test case when default USB controller for
    'pseries' is compiled out
  qemuxmlconftest: Add test data for USB selection with 'g3beige'
    machine on ppc64
  qemuxmlconftest: Add test data for USB selection with 'mac99' machine
    on ppc64
  qemuxmlconftest: Add test data for USB selection with 'powernv'
    machine on ppc64
  qemuxmlconftest: Add test data for USB selection with 'mac99' machine
    on ppc
  qemu: command: Don't downgrade to '-usb' for x86 based machines
  qemu: command: Don't downgrade to '-usb' with 'pseries' machines
  qemu: command: Don't downgrade to '-usb' for ppc based machines
  qemu: command: Don't downgrade to '-usb' for arm based machines
  qemu: command: Remove fallback '-usb' handling

 src/qemu/qemu_command.c                       |    87 +-
 src/qemu/qemu_domain.c                        |    63 +-
 src/qemu/qemu_domain.h                        |     1 +
 tests/domaincapsdata/qemu_8.2.0.armv7l.xml    |   175 +
 tests/domaincapstest.c                        |     5 +-
 tests/qemucapabilitiesdata/README.rst         |    18 +-
 .../caps_8.2.0_armv7l.replies                 | 35062 ++++++++++++++++
 .../caps_8.2.0_armv7l.xml                     |   326 +
 tests/qemucaps2xmloutdata/caps.armv7l.xml     |    26 +
 ...usb-minimal.aarch64-latest.abi-update.args |    30 +
 ...ousb-minimal.aarch64-latest.abi-update.xml |    21 +
 .../aarch64-nousb-minimal.aarch64-latest.args |    30 +
 .../aarch64-nousb-minimal.aarch64-latest.xml  |    21 +
 .../qemuxmlconfdata/aarch64-nousb-minimal.xml |    15 +
 ...iew-minimal.aarch64-latest.abi-update.args |    31 +
 ...view-minimal.aarch64-latest.abi-update.xml |    22 +
 ...rch64-realview-minimal.aarch64-latest.args |    31 +
 ...arch64-realview-minimal.aarch64-latest.xml |    22 +
 .../aarch64-realview-minimal.xml              |    14 +
 ...epb-minimal.aarch64-latest.abi-update.args |    32 +
 ...lepb-minimal.aarch64-latest.abi-update.xml |    25 +
 ...64-versatilepb-minimal.aarch64-latest.args |    32 +
 ...h64-versatilepb-minimal.aarch64-latest.xml |    25 +
 .../aarch64-versatilepb-minimal.xml           |    14 +
 .../arm-vexpressa9-basic.aarch64-latest.args  |     1 -
 .../arm-vexpressa9-nodevs.aarch64-latest.args |     1 -
 .../arm-vexpressa9-virtio.aarch64-latest.args |     1 -
 ...lepb-minimal.armv7l-latest.abi-update.args |    32 +
 ...ilepb-minimal.armv7l-latest.abi-update.xml |    27 +
 ...v7l-versatilepb-minimal.armv7l-latest.args |    32 +
 ...mv7l-versatilepb-minimal.armv7l-latest.xml |    27 +
 .../armv7l-versatilepb-minimal.xml            |    13 +
 .../disk-arm-virtio-sd.aarch64-latest.args    |     1 -
 .../microvm.x86_64-latest.args                |    34 +
 .../qemuxmlconfdata/microvm.x86_64-latest.xml |    29 +
 tests/qemuxmlconfdata/microvm.xml             |    20 +
 ...c-mac99-minimal.ppc-latest.abi-update.args |    32 +
 ...pc-mac99-minimal.ppc-latest.abi-update.xml |    26 +
 .../ppc-mac99-minimal.ppc-latest.args         |    32 +
 .../ppc-mac99-minimal.ppc-latest.xml          |    26 +
 tests/qemuxmlconfdata/ppc-mac99-minimal.xml   |    12 +
 ...beige-minimal.ppc64-latest.abi-update.args |    33 +
 ...3beige-minimal.ppc64-latest.abi-update.xml |    29 +
 .../ppc64-g3beige-minimal.ppc64-latest.args   |    33 +
 .../ppc64-g3beige-minimal.ppc64-latest.xml    |    29 +
 .../qemuxmlconfdata/ppc64-g3beige-minimal.xml |    12 +
 ...mac99-minimal.ppc64-latest.abi-update.args |    33 +
 ...-mac99-minimal.ppc64-latest.abi-update.xml |    29 +
 .../ppc64-mac99-minimal.ppc64-latest.args     |    33 +
 .../ppc64-mac99-minimal.ppc64-latest.xml      |    29 +
 tests/qemuxmlconfdata/ppc64-mac99-minimal.xml |    12 +
 ...ernv9-minimal.ppc64-latest.abi-update.args |    33 +
 ...wernv9-minimal.ppc64-latest.abi-update.xml |    29 +
 .../ppc64-powernv9-minimal.ppc64-latest.args  |    33 +
 .../ppc64-powernv9-minimal.ppc64-latest.xml   |    29 +
 .../ppc64-powernv9-minimal.xml                |    12 +
 .../sparc-minimal.sparc-latest.args           |     1 -
 ...default-fallback-g3beige.ppc64-latest.args |    33 +
 ...-default-fallback-g3beige.ppc64-latest.xml |    34 +
 ...sb-controller-default-fallback-g3beige.xml |     1 +
 ...r-default-fallback-mac99.ppc64-latest.args |    33 +
 ...er-default-fallback-mac99.ppc64-latest.xml |    34 +
 .../usb-controller-default-fallback-mac99.xml |     1 +
 ...default-fallback-mac99ppc.ppc-latest.args} |     9 +-
 ...r-default-fallback-mac99ppc.ppc-latest.xml |    31 +
 ...b-controller-default-fallback-mac99ppc.xml |     1 +
 ...default-fallback-nousb.aarch64-latest.args |    31 +
 ...-default-fallback-nousb.aarch64-latest.xml |    23 +
 .../usb-controller-default-fallback-nousb.xml |     1 +
 ...efault-fallback-powernv9.ppc64-latest.args |    33 +
 ...default-fallback-powernv9.ppc64-latest.xml |    34 +
 ...b-controller-default-fallback-powernv9.xml |     1 +
 ...ault-fallback-realview.aarch64-latest.args |    31 +
 ...fault-fallback-realview.aarch64-latest.xml |    23 +
 ...b-controller-default-fallback-realview.xml |     1 +
 ...ck-versatilepb-aarch64.aarch64-latest.args |    32 +
 ...ack-versatilepb-aarch64.aarch64-latest.xml |    25 +
 ...r-default-fallback-versatilepb-aarch64.xml |     1 +
 ...back-versatilepb-armv7l.armv7l-latest.args |    32 +
 ...lback-versatilepb-armv7l.armv7l-latest.xml |    27 +
 ...er-default-fallback-versatilepb-armv7l.xml |     1 +
 ...ntroller-default-g3beige.ppc64-latest.args |    33 +
 ...ontroller-default-g3beige.ppc64-latest.xml |    34 +
 .../usb-controller-default-g3beige.xml        |    23 +
 ...controller-default-mac99.ppc64-latest.args |    33 +
 ...-controller-default-mac99.ppc64-latest.xml |    34 +
 .../usb-controller-default-mac99.xml          |    23 +
 ...ontroller-default-mac99ppc.ppc-latest.args |    32 +
 ...controller-default-mac99ppc.ppc-latest.xml |    31 +
 .../usb-controller-default-mac99ppc.xml       |    23 +
 ...ntroller-default-nousb.aarch64-latest.args |    31 +
 ...ontroller-default-nousb.aarch64-latest.xml |    23 +
 .../usb-controller-default-nousb.xml          |    17 +
 ...troller-default-powernv9.ppc64-latest.args |    33 +
 ...ntroller-default-powernv9.ppc64-latest.xml |    34 +
 .../usb-controller-default-powernv9.xml       |    23 +
 ...ault-pseries.ppc64-latest.abi-update.args} |     0
 ...fault-pseries.ppc64-latest.abi-update.xml} |     0
 ...troller-default-pseries.ppc64-latest.args} |     0
 ...ntroller-default-pseries.ppc64-latest.xml} |     0
 ...xml => usb-controller-default-pseries.xml} |     0
 ...oller-default-realview.aarch64-latest.args |    31 +
 ...roller-default-realview.aarch64-latest.xml |    23 +
 .../usb-controller-default-realview.xml       |    16 +
 ...fault-unavailable-g3beige.ppc64-latest.err |     1 +
 ...fault-unavailable-g3beige.ppc64-latest.xml |    34 +
 ...controller-default-unavailable-g3beige.xml |     1 +
 ...fault-unavailable-i440fx.x86_64-latest.err |     1 +
 ...default-unavailable-mac99.ppc64-latest.err |     1 +
 ...default-unavailable-mac99.ppc64-latest.xml |    34 +
 ...b-controller-default-unavailable-mac99.xml |     1 +
 ...efault-unavailable-mac99ppc.ppc-latest.err |     1 +
 ...efault-unavailable-mac99ppc.ppc-latest.xml |    31 +
 ...ontroller-default-unavailable-mac99ppc.xml |     1 +
 ...ault-unavailable-nousb.aarch64-latest.args |    31 +
 ...fault-unavailable-nousb.aarch64-latest.xml |    23 +
 ...b-controller-default-unavailable-nousb.xml |     1 +
 ...ault-unavailable-powernv9.ppc64-latest.err |     1 +
 ...ault-unavailable-powernv9.ppc64-latest.xml |    34 +
 ...ontroller-default-unavailable-powernv9.xml |     1 +
 ...fault-unavailable-pseries.ppc64-latest.err |     1 +
 ...fault-unavailable-pseries.ppc64-latest.xml |    38 +
 ...controller-default-unavailable-pseries.xml |     1 +
 ...t-unavailable-realview.aarch64-latest.args |    31 +
 ...lt-unavailable-realview.aarch64-latest.xml |    23 +
 ...ontroller-default-unavailable-realview.xml |     1 +
 ...le-versatilepb-aarch64.aarch64-latest.args |    32 +
 ...ble-versatilepb-aarch64.aarch64-latest.xml |    25 +
 ...efault-unavailable-versatilepb-aarch64.xml |     1 +
 ...lable-versatilepb-armv7l.armv7l-latest.err |     1 +
 ...lable-versatilepb-armv7l.armv7l-latest.xml |    27 +
 ...default-unavailable-versatilepb-armv7l.xml |     1 +
 ...lt-versatilepb-aarch64.aarch64-latest.args |    32 +
 ...ult-versatilepb-aarch64.aarch64-latest.xml |    25 +
 ...controller-default-versatilepb-aarch64.xml |    16 +
 ...ault-versatilepb-armv7l.armv7l-latest.args |    32 +
 ...fault-versatilepb-armv7l.armv7l-latest.xml |    27 +
 ...-controller-default-versatilepb-armv7l.xml |    15 +
 ...ntroller-implicit-isapc.x86_64-latest.args |     1 -
 ...troller-implicit-microvm.x86_64-latest.err |     1 +
 ...troller-implicit-microvm.x86_64-latest.xml |    25 +
 .../usb-controller-implicit-microvm.xml       |    17 +
 ...rovm-minimal.x86_64-latest.abi-update.args |    31 +
 ...crovm-minimal.x86_64-latest.abi-update.xml |    23 +
 .../x86_64-microvm-minimal.x86_64-latest.args |    31 +
 .../x86_64-microvm-minimal.x86_64-latest.xml  |    23 +
 .../x86_64-microvm-minimal.xml                |    14 +
 tests/qemuxmlconftest.c                       |   140 +-
 tests/testutilshostcpus.h                     |    10 +
 149 files changed, 38588 insertions(+), 107 deletions(-)
 create mode 100644 tests/domaincapsdata/qemu_8.2.0.armv7l.xml
 create mode 100644 tests/qemucapabilitiesdata/caps_8.2.0_armv7l.replies
 create mode 100644 tests/qemucapabilitiesdata/caps_8.2.0_armv7l.xml
 create mode 100644 tests/qemucaps2xmloutdata/caps.armv7l.xml
 create mode 100644 tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.abi-update.args
 create mode 100644 tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.abi-update.xml
 create mode 100644 tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.args
 create mode 100644 tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/aarch64-nousb-minimal.xml
 create mode 100644 tests/qemuxmlconfdata/aarch64-realview-minimal.aarch64-latest.abi-update.args
 create mode 100644 tests/qemuxmlconfdata/aarch64-realview-minimal.aarch64-latest.abi-update.xml
 create mode 100644 tests/qemuxmlconfdata/aarch64-realview-minimal.aarch64-latest.args
 create mode 100644 tests/qemuxmlconfdata/aarch64-realview-minimal.aarch64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/aarch64-realview-minimal.xml
 create mode 100644 tests/qemuxmlconfdata/aarch64-versatilepb-minimal.aarch64-latest.abi-update.args
 create mode 100644 tests/qemuxmlconfdata/aarch64-versatilepb-minimal.aarch64-latest.abi-update.xml
 create mode 100644 tests/qemuxmlconfdata/aarch64-versatilepb-minimal.aarch64-latest.args
 create mode 100644 tests/qemuxmlconfdata/aarch64-versatilepb-minimal.aarch64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/aarch64-versatilepb-minimal.xml
 create mode 100644 tests/qemuxmlconfdata/armv7l-versatilepb-minimal.armv7l-latest.abi-update.args
 create mode 100644 tests/qemuxmlconfdata/armv7l-versatilepb-minimal.armv7l-latest.abi-update.xml
 create mode 100644 tests/qemuxmlconfdata/armv7l-versatilepb-minimal.armv7l-latest.args
 create mode 100644 tests/qemuxmlconfdata/armv7l-versatilepb-minimal.armv7l-latest.xml
 create mode 100644 tests/qemuxmlconfdata/armv7l-versatilepb-minimal.xml
 create mode 100644 tests/qemuxmlconfdata/microvm.x86_64-latest.args
 create mode 100644 tests/qemuxmlconfdata/microvm.x86_64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/microvm.xml
 create mode 100644 tests/qemuxmlconfdata/ppc-mac99-minimal.ppc-latest.abi-update.args
 create mode 100644 tests/qemuxmlconfdata/ppc-mac99-minimal.ppc-latest.abi-update.xml
 create mode 100644 tests/qemuxmlconfdata/ppc-mac99-minimal.ppc-latest.args
 create mode 100644 tests/qemuxmlconfdata/ppc-mac99-minimal.ppc-latest.xml
 create mode 100644 tests/qemuxmlconfdata/ppc-mac99-minimal.xml
 create mode 100644 tests/qemuxmlconfdata/ppc64-g3beige-minimal.ppc64-latest.abi-update.args
 create mode 100644 tests/qemuxmlconfdata/ppc64-g3beige-minimal.ppc64-latest.abi-update.xml
 create mode 100644 tests/qemuxmlconfdata/ppc64-g3beige-minimal.ppc64-latest.args
 create mode 100644 tests/qemuxmlconfdata/ppc64-g3beige-minimal.ppc64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/ppc64-g3beige-minimal.xml
 create mode 100644 tests/qemuxmlconfdata/ppc64-mac99-minimal.ppc64-latest.abi-update.args
 create mode 100644 tests/qemuxmlconfdata/ppc64-mac99-minimal.ppc64-latest.abi-update.xml
 create mode 100644 tests/qemuxmlconfdata/ppc64-mac99-minimal.ppc64-latest.args
 create mode 100644 tests/qemuxmlconfdata/ppc64-mac99-minimal.ppc64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/ppc64-mac99-minimal.xml
 create mode 100644 tests/qemuxmlconfdata/ppc64-powernv9-minimal.ppc64-latest.abi-update.args
 create mode 100644 tests/qemuxmlconfdata/ppc64-powernv9-minimal.ppc64-latest.abi-update.xml
 create mode 100644 tests/qemuxmlconfdata/ppc64-powernv9-minimal.ppc64-latest.args
 create mode 100644 tests/qemuxmlconfdata/ppc64-powernv9-minimal.ppc64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/ppc64-powernv9-minimal.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-g3beige.ppc64-latest.args
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-g3beige.ppc64-latest.xml
 create mode 120000 tests/qemuxmlconfdata/usb-controller-default-fallback-g3beige.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-mac99.ppc64-latest.args
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-mac99.ppc64-latest.xml
 create mode 120000 tests/qemuxmlconfdata/usb-controller-default-fallback-mac99.xml
 rename tests/qemuxmlconfdata/{usb-controller-default-unavailable-i440fx.x86_64-latest.args => usb-controller-default-fallback-mac99ppc.ppc-latest.args} (80%)
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-mac99ppc.ppc-latest.xml
 create mode 120000 tests/qemuxmlconfdata/usb-controller-default-fallback-mac99ppc.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-nousb.aarch64-latest.args
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-nousb.aarch64-latest.xml
 create mode 120000 tests/qemuxmlconfdata/usb-controller-default-fallback-nousb.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-powernv9.ppc64-latest.args
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-powernv9.ppc64-latest.xml
 create mode 120000 tests/qemuxmlconfdata/usb-controller-default-fallback-powernv9.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-realview.aarch64-latest.args
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-realview.aarch64-latest.xml
 create mode 120000 tests/qemuxmlconfdata/usb-controller-default-fallback-realview.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-versatilepb-aarch64.aarch64-latest.args
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-versatilepb-aarch64.aarch64-latest.xml
 create mode 120000 tests/qemuxmlconfdata/usb-controller-default-fallback-versatilepb-aarch64.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-versatilepb-armv7l.armv7l-latest.args
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-versatilepb-armv7l.armv7l-latest.xml
 create mode 120000 tests/qemuxmlconfdata/usb-controller-default-fallback-versatilepb-armv7l.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-g3beige.ppc64-latest.args
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-g3beige.ppc64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-g3beige.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-mac99.ppc64-latest.args
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-mac99.ppc64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-mac99.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-mac99ppc.ppc-latest.args
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-mac99ppc.ppc-latest.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-mac99ppc.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-nousb.aarch64-latest.args
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-nousb.aarch64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-nousb.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-powernv9.ppc64-latest.args
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-powernv9.ppc64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-powernv9.xml
 rename tests/qemuxmlconfdata/{ppc64-usb-controller.ppc64-latest.abi-update.args => usb-controller-default-pseries.ppc64-latest.abi-update.args} (100%)
 rename tests/qemuxmlconfdata/{ppc64-usb-controller.ppc64-latest.abi-update.xml => usb-controller-default-pseries.ppc64-latest.abi-update.xml} (100%)
 rename tests/qemuxmlconfdata/{ppc64-usb-controller.ppc64-latest.args => usb-controller-default-pseries.ppc64-latest.args} (100%)
 rename tests/qemuxmlconfdata/{ppc64-usb-controller.ppc64-latest.xml => usb-controller-default-pseries.ppc64-latest.xml} (100%)
 rename tests/qemuxmlconfdata/{ppc64-usb-controller.xml => usb-controller-default-pseries.xml} (100%)
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-realview.aarch64-latest.args
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-realview.aarch64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-realview.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-g3beige.ppc64-latest.err
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-g3beige.ppc64-latest.xml
 create mode 120000 tests/qemuxmlconfdata/usb-controller-default-unavailable-g3beige.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-i440fx.x86_64-latest.err
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-mac99.ppc64-latest.err
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-mac99.ppc64-latest.xml
 create mode 120000 tests/qemuxmlconfdata/usb-controller-default-unavailable-mac99.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-mac99ppc.ppc-latest.err
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-mac99ppc.ppc-latest.xml
 create mode 120000 tests/qemuxmlconfdata/usb-controller-default-unavailable-mac99ppc.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-nousb.aarch64-latest.args
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-nousb.aarch64-latest.xml
 create mode 120000 tests/qemuxmlconfdata/usb-controller-default-unavailable-nousb.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-powernv9.ppc64-latest.err
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-powernv9.ppc64-latest.xml
 create mode 120000 tests/qemuxmlconfdata/usb-controller-default-unavailable-powernv9.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-pseries.ppc64-latest.err
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-pseries.ppc64-latest.xml
 create mode 120000 tests/qemuxmlconfdata/usb-controller-default-unavailable-pseries.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-realview.aarch64-latest.args
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-realview.aarch64-latest.xml
 create mode 120000 tests/qemuxmlconfdata/usb-controller-default-unavailable-realview.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-versatilepb-aarch64.aarch64-latest.args
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-versatilepb-aarch64.aarch64-latest.xml
 create mode 120000 tests/qemuxmlconfdata/usb-controller-default-unavailable-versatilepb-aarch64.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-versatilepb-armv7l.armv7l-latest.err
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-versatilepb-armv7l.armv7l-latest.xml
 create mode 120000 tests/qemuxmlconfdata/usb-controller-default-unavailable-versatilepb-armv7l.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-versatilepb-aarch64.aarch64-latest.args
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-versatilepb-aarch64.aarch64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-versatilepb-aarch64.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-versatilepb-armv7l.armv7l-latest.args
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-versatilepb-armv7l.armv7l-latest.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-versatilepb-armv7l.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-implicit-microvm.x86_64-latest.err
 create mode 100644 tests/qemuxmlconfdata/usb-controller-implicit-microvm.x86_64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/usb-controller-implicit-microvm.xml
 create mode 100644 tests/qemuxmlconfdata/x86_64-microvm-minimal.x86_64-latest.abi-update.args
 create mode 100644 tests/qemuxmlconfdata/x86_64-microvm-minimal.x86_64-latest.abi-update.xml
 create mode 100644 tests/qemuxmlconfdata/x86_64-microvm-minimal.x86_64-latest.args
 create mode 100644 tests/qemuxmlconfdata/x86_64-microvm-minimal.x86_64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/x86_64-microvm-minimal.xml

-- 
2.43.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

On Tue, Feb 27, 2024 at 05:36:02PM +0100, Peter Krempa wrote:
> This patchset removes the use of '-usb' legacy controller specification.
>
> For the vast majority of platforms/machines (most of the irrelevant
> ones) which don't actually have a concept of implicit USB qemu ignores
> the '-usb' argument.
>
> For the relevant platforms libvirt would already pick exactly the
> same controller and thus '-usb' wouldn't be used at all.
>
> There's a small handful of ARM boards 'realview' and 'versatilepb' where
> libvirt would pick the wrong one as default if some controllers were
> compiled out and thus reallistically '-usb' would have effect for those
> although would be unusable as libvirt's bus name for the bus is incorret
> and thus no devices would be usable.
>
> For the two mostly obsolete board types this series can break ABI in the
> aforementioned corner case.
>
> Other than that this removes all the legacy code which makes USB
> controller selection utterly confusing.
>
> Peter Krempa (25):
>   tests: Replace mentions of the removed 'qemucapabilitiesnumbering' tool
>   qemucapabilitiesdata: Document faked caps dumps
>   testutilshostcpus: Add support for VIR_ARCH_ARMV7L
>   qemucapabilitiestest: Add test dump for 'armv7l' architecture
>   qemu: domain: Add checkers for 'microvm' machine type
>   qemu: Add basic framework for 'microvm' machine type
>   qemuxmlconfdata: Add tests for USB controller selection with 'versatilepb' machine on aarch64 qemu binary
>   qemuxmlconfdata: Add tests for USB controller selection with 'versatilepb' machine on arm qemu binary
>   qemuDomainDefAddDefaultDevices: Handle defaults for all ARM arches together
>   qemuDomainControllerDefPostParse: Use proper enum value for default USB controller model
>   qemuDomainDefAddDefaultDevices: Populate default USB for 'versatilepb' and 'realview' ARM machines
>   qemuDomainControllerDefPostParse: Use 'pci-ohci' as last-resort fallback USB controller
>   qemuxmlconftest: Add test for 'realview' machine
>   qemuxmlconftest: Add test data for an ARM machine where qemu doesn't honour -usb
>   qemuxml2conftest: Consolidate usb controller tests for 'pseries' machine
>   qemuxmlconftest: Add test case when default USB controller for 'pseries' is compiled out
>   qemuxmlconftest: Add test data for USB selection with 'g3beige' machine on ppc64
>   qemuxmlconftest: Add test data for USB selection with 'mac99' machine on ppc64
>   qemuxmlconftest: Add test data for USB selection with 'powernv' machine on ppc64
>   qemuxmlconftest: Add test data for USB selection with 'mac99' machine on ppc
>   qemu: command: Don't downgrade to '-usb' for x86 based machines
>   qemu: command: Don't downgrade to '-usb' with 'pseries' machines
>   qemu: command: Don't downgrade to '-usb' for ppc based machines
>   qemu: command: Don't downgrade to '-usb' for arm based machines
>   qemu: command: Remove fallback '-usb' handling

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org