qemu_process: Skip over non-virtio non-TAP NIC models when refreshing rx-filter

[PATCH v2 0/2] qemu_process: Skip over non-virtio non-TAP NIC models when refreshing rx-filter

Posted by Michal Privoznik 3 months ago

This was reported here:

https://lists.libvirt.org/archives/list/users@lists.libvirt.org/thread/QZ43KUTWO5UY2FLC5BMKKHA7CCCKJ3HI/

and v1 was posted here:

https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/AVRYA5W3TKYKRPHRCI7VRMELAKHZC5NN/

diff to v1:
- Expanded commit message in 1/2
- Added NEWS entry
- Expanded list of vNIC types for which query-rx-filter is issued to
  basically every TUN/TAP based type. Might be an overkill, but should
  keep us covered for foreseeable future (e.g. when we decide to report
  changed MAC address in domain XML).

Michal Prívozník (2):
  qemu_process: Skip over non-virtio non-TAP NIC models when refreshing
    rx-filter
  NEWS: Document recent rx-filter bugfix

 NEWS.rst                |  9 +++++++++
 src/qemu/qemu_process.c | 27 +++++++++++++++++++++++++++
 2 files changed, 36 insertions(+)

-- 
2.43.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

Re: [PATCH v2 0/2] qemu_process: Skip over non-virtio non-TAP NIC models when refreshing rx-filter

Posted by Peter Krempa 3 months ago

On Thu, Jan 25, 2024 at 14:49:47 +0100, Michal Privoznik wrote:
> This was reported here:
> 
> https://lists.libvirt.org/archives/list/users@lists.libvirt.org/thread/QZ43KUTWO5UY2FLC5BMKKHA7CCCKJ3HI/
> 
> and v1 was posted here:
> 
> https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/AVRYA5W3TKYKRPHRCI7VRMELAKHZC5NN/
> 
> diff to v1:
> - Expanded commit message in 1/2
> - Added NEWS entry
> - Expanded list of vNIC types for which query-rx-filter is issued to
>   basically every TUN/TAP based type. Might be an overkill, but should
>   keep us covered for foreseeable future (e.g. when we decide to report
>   changed MAC address in domain XML).

Please add the exact verbatim copy of the error message the user gets if
they have the broken configuration both into the commit message and
into the news entry for anyone searching for that problem.

Reviewed-by: Peter Krempa <pkrempa@redhat.com>
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org