[PATCH 14/23] qemuxml2argvtest: Remove unused separate parsing of arch

Peter Krempa posted 23 patches 1 year ago
[PATCH 14/23] qemuxml2argvtest: Remove unused separate parsing of arch
Posted by Peter Krempa 1 year ago
Prior to all tests being converted to "DO_TEST_CAPS*" invocation the
fake-caps tests required knowing the architecture, which was pre-parsed
in qemuxml2argvtest. This code was now removed, but the arch parser was
forgotten.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 tests/qemuxml2argvtest.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index 41e34279ce..226f8d4451 100644
--- a/tests/qemuxml2argvtest.c
+++ b/tests/qemuxml2argvtest.c
@@ -618,8 +618,6 @@ testCompareXMLToArgv(const void *data)
     qemuDomainObjPrivate *priv = NULL;
     g_autoptr(xmlDoc) xml = NULL;
     g_autoptr(xmlXPathContext) ctxt = NULL;
-    g_autofree char *archstr = NULL;
-    virArch arch = VIR_ARCH_NONE;
     g_autoptr(virIdentity) sysident = virIdentityGetSystem();

     /* mark test case as used */
@@ -675,12 +673,6 @@ testCompareXMLToArgv(const void *data)
                             "domain", &ctxt, NULL, false)))
         goto cleanup;

-    if ((archstr = virXPathString("string(./os/type[1]/@arch)", ctxt)))
-        arch = virArchFromString(archstr);
-
-    if (arch == VIR_ARCH_NONE)
-        arch = virArchFromHost();
-
     virFileCacheClear(driver.qemuCapsCache);

     if (qemuTestCapsCacheInsert(driver.qemuCapsCache, info->qemuCaps) < 0)
-- 
2.43.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org