[PATCH 1/2] ci: integration: Switch upstream integration tests to Fedora 39

Michal Privoznik posted 2 patches 2 years, 1 month ago
[PATCH 1/2] ci: integration: Switch upstream integration tests to Fedora 39
Posted by Michal Privoznik 2 years, 1 month ago
Currently, Fedora 37 and 38 is used. The former is now EOL since
there's new release. Switch 37 to 39 then.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 ci/integration.yml | 80 +++++++++++++++++++++++-----------------------
 1 file changed, 40 insertions(+), 40 deletions(-)

diff --git a/ci/integration.yml b/ci/integration.yml
index 25788099b5..8b66a8c688 100644
--- a/ci/integration.yml
+++ b/ci/integration.yml
@@ -81,46 +81,6 @@ centos-stream-9-tests-local-env:
       artifacts: true
 
 
-.fedora-37-tests:
-  variables:
-    # needed by libvirt-gitlab-executor
-    DISTRO: fedora-37
-    # can be overridden in forks to set a different runner tag
-    LIBVIRT_CI_INTEGRATION_RUNNER_TAG: redhat-vm-host
-  tags:
-    - $LIBVIRT_CI_INTEGRATION_RUNNER_TAG
-
-fedora-37-tests-prebuilt-env:
-  extends:
-    - .integration_tests_prebuilt_env
-    - .fedora-37-tests
-  needs:
-    - x86_64-fedora-37-prebuilt-env
-    - project: libvirt/libvirt-perl
-      job: x86_64-fedora-37-prebuilt-env
-      ref: master
-      artifacts: true
-    - project: libvirt/libvirt-python
-      job: x86_64-fedora-37-prebuilt-env
-      ref: master
-      artifacts: true
-
-fedora-37-tests-local-env:
-  extends:
-    - .integration_tests_local_env
-    - .fedora-37-tests
-  needs:
-    - x86_64-fedora-37-local-env
-    - project: libvirt/libvirt-perl
-      job: x86_64-fedora-37-prebuilt-env
-      ref: master
-      artifacts: true
-    - project: libvirt/libvirt-python
-      job: x86_64-fedora-37-prebuilt-env
-      ref: master
-      artifacts: true
-
-
 .fedora-38-tests:
   variables:
     # needed by libvirt-gitlab-executor
@@ -199,3 +159,43 @@ fedora-38-upstream-qemu-tests-local-env:
       job: x86_64-fedora-38-prebuilt-env
       ref: master
       artifacts: true
+
+
+.fedora-39-tests:
+  variables:
+    # needed by libvirt-gitlab-executor
+    DISTRO: fedora-39
+    # can be overridden in forks to set a different runner tag
+    LIBVIRT_CI_INTEGRATION_RUNNER_TAG: redhat-vm-host
+  tags:
+    - $LIBVIRT_CI_INTEGRATION_RUNNER_TAG
+
+fedora-39-tests-prebuilt-env:
+  extends:
+    - .integration_tests_prebuilt_env
+    - .fedora-39-tests
+  needs:
+    - x86_64-fedora-39-prebuilt-env
+    - project: libvirt/libvirt-perl
+      job: x86_64-fedora-39-prebuilt-env
+      ref: master
+      artifacts: true
+    - project: libvirt/libvirt-python
+      job: x86_64-fedora-39-prebuilt-env
+      ref: master
+      artifacts: true
+
+fedora-39-tests-local-env:
+  extends:
+    - .integration_tests_local_env
+    - .fedora-39-tests
+  needs:
+    - x86_64-fedora-39-local-env
+    - project: libvirt/libvirt-perl
+      job: x86_64-fedora-39-prebuilt-env
+      ref: master
+      artifacts: true
+    - project: libvirt/libvirt-python
+      job: x86_64-fedora-39-prebuilt-env
+      ref: master
+      artifacts: true
-- 
2.41.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org
Re: [PATCH 1/2] ci: integration: Switch upstream integration tests to Fedora 39
Posted by Andrea Bolognani 2 years, 1 month ago
On Thu, Dec 14, 2023 at 09:28:16AM +0100, Michal Privoznik wrote:
> Currently, Fedora 37 and 38 is used. The former is now EOL since
> there's new release. Switch 37 to 39 then.
>
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  ci/integration.yml | 80 +++++++++++++++++++++++-----------------------
>  1 file changed, 40 insertions(+), 40 deletions(-)

Patch looks good, but I don't think we can push it until the Fedora
39 runner used for integration tests has been created, and AFAIK
that's a manual process.

Erik, I know that you've taken care of this so far. Has the process
been documented anywhere? Is it something that people other than you
can deal with?

-- 
Andrea Bolognani / Red Hat / Virtualization
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org
Re: [PATCH 1/2] ci: integration: Switch upstream integration tests to Fedora 39
Posted by Erik Skultety 2 years, 1 month ago
On Fri, Dec 15, 2023 at 02:26:11AM -0800, Andrea Bolognani wrote:
> On Thu, Dec 14, 2023 at 09:28:16AM +0100, Michal Privoznik wrote:
> > Currently, Fedora 37 and 38 is used. The former is now EOL since
> > there's new release. Switch 37 to 39 then.
> >
> > Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> > ---
> >  ci/integration.yml | 80 +++++++++++++++++++++++-----------------------
> >  1 file changed, 40 insertions(+), 40 deletions(-)
> 
> Patch looks good, but I don't think we can push it until the Fedora
> 39 runner used for integration tests has been created, and AFAIK
> that's a manual process.
> 
> Erik, I know that you've taken care of this so far. Has the process
> been documented anywhere? Is it something that people other than you
> can deal with?

Uhm, yes, it is documented, however that docs resource isn't public as it runs on a private infra.
Yes, Cleber and Jan should be able to do that too as they have access. I'd do that for you myself
no problem, but I'm already on PTO since today. If this isn't a blocker for you until the new year,
then I'll take care of it then.

Erik
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org
Re: [PATCH 1/2] ci: integration: Switch upstream integration tests to Fedora 39
Posted by Michal Prívozník 2 years, 1 month ago
On 12/15/23 18:06, Erik Skultety wrote:
> On Fri, Dec 15, 2023 at 02:26:11AM -0800, Andrea Bolognani wrote:
>> On Thu, Dec 14, 2023 at 09:28:16AM +0100, Michal Privoznik wrote:
>>> Currently, Fedora 37 and 38 is used. The former is now EOL since
>>> there's new release. Switch 37 to 39 then.
>>>
>>> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>>> ---
>>>  ci/integration.yml | 80 +++++++++++++++++++++++-----------------------
>>>  1 file changed, 40 insertions(+), 40 deletions(-)
>>
>> Patch looks good, but I don't think we can push it until the Fedora
>> 39 runner used for integration tests has been created, and AFAIK
>> that's a manual process.
>>
>> Erik, I know that you've taken care of this so far. Has the process
>> been documented anywhere? Is it something that people other than you
>> can deal with?
> 
> Uhm, yes, it is documented, however that docs resource isn't public as it runs on a private infra.
> Yes, Cleber and Jan should be able to do that too as they have access. I'd do that for you myself
> no problem, but I'm already on PTO since today. If this isn't a blocker for you until the new year,
> then I'll take care of it then.
> 
> Erik
> 

Gentle ping.

Although, libvirt-ci moved meanwhile and dropped freebsd-12 in favor of
freebsd-14. Which is exactly what we need to fix failing CI:

https://gitlab.com/libvirt/libvirt/-/pipelines/1125194120

Michal
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org
Re: [PATCH 1/2] ci: integration: Switch upstream integration tests to Fedora 39
Posted by Andrea Bolognani 2 years, 1 month ago
On Fri, Dec 15, 2023 at 06:06:54PM +0100, Erik Skultety wrote:
> On Fri, Dec 15, 2023 at 02:26:11AM -0800, Andrea Bolognani wrote:
> > On Thu, Dec 14, 2023 at 09:28:16AM +0100, Michal Privoznik wrote:
> > > Currently, Fedora 37 and 38 is used. The former is now EOL since
> > > there's new release. Switch 37 to 39 then.
> > >
> > > Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> > > ---
> > >  ci/integration.yml | 80 +++++++++++++++++++++++-----------------------
> > >  1 file changed, 40 insertions(+), 40 deletions(-)
> >
> > Patch looks good, but I don't think we can push it until the Fedora
> > 39 runner used for integration tests has been created, and AFAIK
> > that's a manual process.
> >
> > Erik, I know that you've taken care of this so far. Has the process
> > been documented anywhere? Is it something that people other than you
> > can deal with?
>
> Uhm, yes, it is documented, however that docs resource isn't public as it runs on a private infra.
> Yes, Cleber and Jan should be able to do that too as they have access. I'd do that for you myself
> no problem, but I'm already on PTO since today. If this isn't a blocker for you until the new year,
> then I'll take care of it then.

I don't think it's a blocker.

And it's fine if the documentation is internal, as long as there's
more than one person that can push things forward when needed.

-- 
Andrea Bolognani / Red Hat / Virtualization
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org