[libvirt PATCH 05/12] ci: jobs.sh: Drop comment about the need for Avocado 98.0

Erik Skultety posted 12 patches 1 year, 1 month ago
There is a newer version of this series
[libvirt PATCH 05/12] ci: jobs.sh: Drop comment about the need for Avocado 98.0
Posted by Erik Skultety 1 year, 1 month ago
We needed v98.0 due to a bug in the past and have been installing the
latest Avocado for a while, yet we kept the comment by a mistake.
Besides, looks like v98.0 ignores the avocado.config file in the TCK
repo instructing it to run the test suite sequentially leading to test
stability issues, so abandoning the v98.0 was a good thing in the end.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
---
 ci/jobs.sh | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ci/jobs.sh b/ci/jobs.sh
index adb798d127..04e776e9be 100644
--- a/ci/jobs.sh
+++ b/ci/jobs.sh
@@ -82,7 +82,6 @@ run_website_build() {
 }
 
 run_integration() {
-    # Avocado >98.0 fails with the nwfilter TCK tests, so stick with 98.0 for now
     sudo pip3 install --prefix=/usr avocado-framework
 
     sudo sh -c "echo DefaultLimitCORE=infinity >> /etc/systemd/system.conf" # Explicitly allow storing cores globally
-- 
2.41.0
Re: [libvirt PATCH 05/12] ci: jobs.sh: Drop comment about the need for Avocado 98.0
Posted by Daniel P. Berrangé 1 year, 1 month ago
On Mon, Sep 18, 2023 at 12:22:41PM +0200, Erik Skultety wrote:
> We needed v98.0 due to a bug in the past and have been installing the
> latest Avocado for a while, yet we kept the comment by a mistake.
> Besides, looks like v98.0 ignores the avocado.config file in the TCK
> repo instructing it to run the test suite sequentially leading to test
> stability issues, so abandoning the v98.0 was a good thing in the end.

Heh, ok ignore my comment in an earlier patch then :-)

> Signed-off-by: Erik Skultety <eskultet@redhat.com>
> ---
>  ci/jobs.sh | 1 -
>  1 file changed, 1 deletion(-)


Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|