On a Thursday in 2023, Michal Privoznik wrote:
>I had these sitting on a local branch for a while. My initial plan was
>to use virXMLPropEnum() more and while working on that I found one bug
>(patch 01/20), one improvement (patch 02/20) and a couple of useless
>typecats.
>
>Michal Prívozník (20):
> lxc_controller: Access correct union member in
> virLXCControllerSetupHostdevCaps()
> src: Access hostdev->source.subsys iff VIR_DOMAIN_HOSTDEV_MODE_SUBSYS
> qemu_domain_address: Drop needless typecast in
> qemuDomainDeviceCalculatePCIConnectFlags()
> qemu: Drop needless typecast to virDomainFSDriverType
> src: Drop needless typecast to virDomainDeviceType
> qemu_domain_address: Drop needless typecast to virDomainDiskModel
> src: Drop needless typecast to virDomainDiskBus
> virDomainHostdevSubsysSCSI: Convert 'protocol' field to proper enum
> type
> virDomainHostdevSubsysSCSIVHost: Convert 'protocol' field to proper
> enum type
> virDomainHostdevDef: Convert 'mode' field to proper enum type
> virDomainHostdevCaps: Convert 'type' field to proper enum type
> virDomainHostdevSubsys: Convert 'type' field to proper enum type
> virDomainControllerDef: Convert 'type' field to proper enum type
> virDomainRNGDef: Convert 'model' field to proper enum type
> virDomainRNGDef: Convert 'backend' field to proper enum type
> virDomainWatchdogDef: Convert 'model' field to proper enum type
> virDomainWatchdogDef: Convert 'action' field to proper enum type
> virDomainDeviceInfo: Convert 'type' field to proper enum type
> virStorageNetHostDef: Convert 'transport' field to proper enum type
> virDomainDiskSourceNVMeParse: Use virXMLPropULongLong()
>
> src/ch/ch_domain.c | 2 +-
> src/conf/device_conf.c | 12 +-
> src/conf/device_conf.h | 4 +-
> src/conf/domain_audit.c | 10 +-
> src/conf/domain_conf.c | 291 ++++++++----------
> src/conf/domain_conf.h | 29 +-
> src/conf/domain_postparse.c | 2 +-
> src/conf/domain_validate.c | 9 +-
> src/conf/storage_source_conf.h | 2 +-
> src/libxl/libxl_driver.c | 12 +
> src/lxc/lxc_cgroup.c | 3 +
> src/lxc/lxc_controller.c | 9 +-
> src/lxc/lxc_driver.c | 16 +
> src/lxc/lxc_hostdev.c | 7 +
> src/qemu/qemu_alias.c | 2 +-
> src/qemu/qemu_backup.c | 2 +-
> src/qemu/qemu_block.c | 2 +-
> src/qemu/qemu_command.c | 26 +-
> src/qemu/qemu_domain.c | 18 +-
> src/qemu/qemu_domain_address.c | 28 +-
> src/qemu/qemu_driver.c | 6 +-
> src/qemu/qemu_hotplug.c | 22 +-
> src/qemu/qemu_migration.c | 4 +-
> src/qemu/qemu_monitor.c | 12 +
> src/qemu/qemu_monitor_json.c | 2 +-
> src/qemu/qemu_namespace.c | 2 +-
> src/qemu/qemu_validate.c | 18 +-
> src/security/security_apparmor.c | 2 +-
> src/security/security_dac.c | 4 +-
> src/security/security_selinux.c | 10 +-
> src/security/virt-aa-helper.c | 7 +
> .../storage_file_backend_gluster.c | 2 +-
> .../storage_source_backingstore.c | 15 +-
> src/vbox/vbox_common.c | 4 +-
> 34 files changed, 333 insertions(+), 263 deletions(-)
>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Jano