[PATCH 04/51] qemuxml2argvtest: Clean up host CPU if overriden

Peter Krempa posted 51 patches 1 year ago
[PATCH 04/51] qemuxml2argvtest: Clean up host CPU if overriden
Posted by Peter Krempa 1 year ago
If a test uses ARG_CAPS_HOST_CPU_MODEL feature we override the global
host cpu model to the selected CPU but don't clear it afterwards. This
can trip up fake caps tests following a test which uses this feature.

This does not happen with real caps, because unless overriden, the host
cpu from capabilities is always populated as the host cpu.

Clear the CPU on cleanup.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 tests/qemuxml2argvtest.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index 5d23c552c5..32affb16c0 100644
--- a/tests/qemuxml2argvtest.c
+++ b/tests/qemuxml2argvtest.c
@@ -713,6 +713,9 @@ testCompareXMLToArgv(const void *data)
     ret = 0;

  cleanup:
+    /* clear overriden host cpu */
+    if (info->args.capsHostCPUModel)
+        qemuTestSetHostCPU(&driver, driver.hostarch, NULL);
     virDomainChrSourceDefClear(&monitor_chr);
     virObjectUnref(vm);
     virIdentitySetCurrent(NULL);
-- 
2.41.0