This fixes reverting external snapshots to not error out in cases where  
it should work and makes it correctly load the memory state when         
reverting to snapshot of running VM.

Pavel Hrdina (7):
  qemu_saveimage: extract starting process to qemuSaveImageStartProcess
  qemuSaveImageStartProcess: allow setting reason for audit log
  qemuSaveImageStartProcess: add snapshot argument
  qemuSaveImageStartProcess: make it possible to use without header
  qemu_snapshot: fix reverting external snapshot when not all disks are
    included
  qemu_snapshot: correctly load the saved memory state file
  NEWS: document support for reverting external snapshots

 NEWS.rst                  |   8 +++
 src/qemu/qemu_saveimage.c | 111 ++++++++++++++++++++++++++------------
 src/qemu/qemu_saveimage.h |  14 +++++
 src/qemu/qemu_snapshot.c  |  90 ++++++++++++++++++++-----------
 4 files changed, 158 insertions(+), 65 deletions(-)

-- 
2.41.0

On Thu, Aug 31, 2023 at 04:54:59PM +0200, Pavel Hrdina wrote:
> This fixes reverting external snapshots to not error out in cases where  
> it should work and makes it correctly load the memory state when         
> reverting to snapshot of running VM.

Forget to mention that we need this to be in 9.7.0 otherwise I will have
to revert commit <de71573bfec7f3acd22ec74794318de121716e21> introducing
capability to indicate that reverting external snapshots is usable.

Pavel

> Pavel Hrdina (7):
>   qemu_saveimage: extract starting process to qemuSaveImageStartProcess
>   qemuSaveImageStartProcess: allow setting reason for audit log
>   qemuSaveImageStartProcess: add snapshot argument
>   qemuSaveImageStartProcess: make it possible to use without header
>   qemu_snapshot: fix reverting external snapshot when not all disks are
>     included
>   qemu_snapshot: correctly load the saved memory state file
>   NEWS: document support for reverting external snapshots
> 
>  NEWS.rst                  |   8 +++
>  src/qemu/qemu_saveimage.c | 111 ++++++++++++++++++++++++++------------
>  src/qemu/qemu_saveimage.h |  14 +++++
>  src/qemu/qemu_snapshot.c  |  90 ++++++++++++++++++++-----------
>  4 files changed, 158 insertions(+), 65 deletions(-)
> 
> -- 
> 2.41.0
> 

On Thu, Aug 31, 2023 at 17:06:35 +0200, Pavel Hrdina wrote:
> On Thu, Aug 31, 2023 at 04:54:59PM +0200, Pavel Hrdina wrote:
> > This fixes reverting external snapshots to not error out in cases where  
> > it should work and makes it correctly load the memory state when         
> > reverting to snapshot of running VM.
> 
> Forget to mention that we need this to be in 9.7.0 otherwise I will have
> to revert commit <de71573bfec7f3acd22ec74794318de121716e21> introducing
> capability to indicate that reverting external snapshots is usable.

Given that the release is tomorrow and I conceptually don't like using
the 'save image' function to open iternal snapshots which do not have a
save image at all (memory state is stored _internally_ in qcow2) I think
the safest will be if you also send this variant.