Finish effort to decrease maximum stack frame to 2048

[PATCH 2/8] virHostValidateBhyve: Declare one variable per line

Posted by Peter Krempa 2 years, 5 months ago

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 tools/virt-host-validate-bhyve.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tools/virt-host-validate-bhyve.c b/tools/virt-host-validate-bhyve.c
index a39225016d..9457fac9a5 100644
--- a/tools/virt-host-validate-bhyve.c
+++ b/tools/virt-host-validate-bhyve.c
@@ -50,8 +50,10 @@ int virHostValidateBhyve(void)
     int ret = 0;
     int fileid = 0;
     struct kld_file_stat stat;
-    bool vmm_loaded = false, if_tap_loaded = false;
-    bool if_bridge_loaded = false, nmdm_loaded = false;
+    bool vmm_loaded = false;
+    bool if_tap_loaded = false;
+    bool if_bridge_loaded = false;
+    bool nmdm_loaded = false;

     for (fileid = kldnext(0); fileid > 0; fileid = kldnext(fileid)) {
         stat.version = sizeof(struct kld_file_stat);
-- 
2.41.0

Re: [PATCH 2/8] virHostValidateBhyve: Declare one variable per line

Posted by Kristina Hanicova 2 years, 5 months ago

On Wed, Aug 30, 2023 at 1:59 PM Peter Krempa <pkrempa@redhat.com> wrote:

> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  tools/virt-host-validate-bhyve.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>

Reviewed-by: Kristina Hanicova <khanicov@redhat.com>

Kristina