[libvirt PATCH 03/33] ci: build.sh: Don't mention that MESON_ARGS are available via CLI

Erik Skultety posted 33 patches 2 years, 5 months ago
There is a newer version of this series
[libvirt PATCH 03/33] ci: build.sh: Don't mention that MESON_ARGS are available via CLI
Posted by Erik Skultety 2 years, 5 months ago
Previous patches have removed the code that allowed injecting arbitrary
meson arguments, same for ninja args.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
---
 ci/build.sh | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/ci/build.sh b/ci/build.sh
index 152c222244..82016ba29c 100644
--- a/ci/build.sh
+++ b/ci/build.sh
@@ -16,9 +16,7 @@ GIT_ROOT="$(git rev-parse --show-toplevel)"
 # be to pass options to trigger cross-compilation
 #
 # $MESON_ARGS correspond to meson's setup args, i.e. configure args. It's
-# populated either from a GitLab's job configuration or from command line as
-# `$ helper build --meson-configure-args=-Dopt1 -Dopt2` when run in a local
-# containerized environment
+# populated from a GitLab's job configuration
 
 MESON_ARGS="$MESON_ARGS $MESON_OPTS"
 
-- 
2.41.0
Re: [libvirt PATCH 03/33] ci: build.sh: Don't mention that MESON_ARGS are available via CLI
Posted by Daniel P. Berrangé 2 years, 5 months ago
On Fri, Aug 25, 2023 at 07:55:11PM +0200, Erik Skultety wrote:
> Previous patches have removed the code that allowed injecting arbitrary
> meson arguments, same for ninja args.
> 
> Signed-off-by: Erik Skultety <eskultet@redhat.com>
> ---
>  ci/build.sh | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|