[libvirt PATCH 23/33] ci: helper: Don't make ':' literal a static part of the image tag

Erik Skultety posted 33 patches 2 years, 5 months ago
There is a newer version of this series
[libvirt PATCH 23/33] ci: helper: Don't make ':' literal a static part of the image tag
Posted by Erik Skultety 2 years, 5 months ago
':' is just a connecting character, we can add it to the appropriate
place later in the Python script later, but it doesn't make sense to be
part of the image 'tag' string.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
---
 ci/helper | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ci/helper b/ci/helper
index 8986772153..d3de6d96cb 100755
--- a/ci/helper
+++ b/ci/helper
@@ -40,7 +40,7 @@ class Parser:
         )
         containerparser.add_argument(
             "--image-tag",
-            default=":latest",
+            default="latest",
             help="use container images with non-default tags",
         )
 
-- 
2.41.0
Re: [libvirt PATCH 23/33] ci: helper: Don't make ':' literal a static part of the image tag
Posted by Daniel P. Berrangé 2 years, 5 months ago
On Fri, Aug 25, 2023 at 07:55:31PM +0200, Erik Skultety wrote:
> ':' is just a connecting character, we can add it to the appropriate
> place later in the Python script later, but it doesn't make sense to be
> part of the image 'tag' string.
> 
> Signed-off-by: Erik Skultety <eskultet@redhat.com>
> ---
>  ci/helper | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|