[libvirt PATCH 31/33] ci: helper: Drop original actions

Erik Skultety posted 33 patches 2 years, 5 months ago
There is a newer version of this series
[libvirt PATCH 31/33] ci: helper: Drop original actions
Posted by Erik Skultety 2 years, 5 months ago
Previous patches added a single 'run' command parametrized with GitLab
job specs via '--job' that cover all of these original actions, adding
some more in the process. Drop the original actions as we don't need
them anymore.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
---
 ci/helper | 36 ------------------------------------
 1 file changed, 36 deletions(-)

diff --git a/ci/helper b/ci/helper
index 7385d3b95c..07e449e59f 100755
--- a/ci/helper
+++ b/ci/helper
@@ -112,33 +112,6 @@ class Parser:
         )
         subparsers.required = True
 
-        # build action
-        buildparser = subparsers.add_parser(
-            "build",
-            help="run a build in a container",
-            parents=[containerparser, mesonparser],
-            formatter_class=argparse.ArgumentDefaultsHelpFormatter,
-        )
-        buildparser.set_defaults(func=Application._action_build)
-
-        # test action
-        testparser = subparsers.add_parser(
-            "test",
-            help="run a build in a container (including tests)",
-            parents=[containerparser, mesonparser],
-            formatter_class=argparse.ArgumentDefaultsHelpFormatter,
-        )
-        testparser.set_defaults(func=Application._action_test)
-
-        # shell action
-        shellparser = subparsers.add_parser(
-            "shell",
-            help="start a shell in a container",
-            parents=[containerparser],
-            formatter_class=argparse.ArgumentDefaultsHelpFormatter,
-        )
-        shellparser.set_defaults(func=Application._action_shell)
-
         jobparser = subparsers.add_parser(
             "run",
             help="Run a GitLab CI job or 'shell' in a local environment",
@@ -296,15 +269,6 @@ class Application:
             """)
             print(msg.replace("STALE_DETAILS", stale_details))
 
-    def _action_build(self):
-        self._make_run(f"ci-build@{self._args.target}")
-
-    def _action_test(self):
-        self._make_run(f"ci-test@{self._args.target}")
-
-    def _action_shell(self):
-        self._make_run(f"ci-shell@{self._args.target}")
-
     @required_deps("git")
     def _action_run(self):
         self._lcitool_run(self._args.job)
-- 
2.41.0
Re: [libvirt PATCH 31/33] ci: helper: Drop original actions
Posted by Daniel P. Berrangé 2 years, 5 months ago
On Fri, Aug 25, 2023 at 07:55:39PM +0200, Erik Skultety wrote:
> Previous patches added a single 'run' command parametrized with GitLab
> job specs via '--job' that cover all of these original actions, adding
> some more in the process. Drop the original actions as we don't need
> them anymore.
> 
> Signed-off-by: Erik Skultety <eskultet@redhat.com>
> ---
>  ci/helper | 36 ------------------------------------
>  1 file changed, 36 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|