Fix the failing FreeBSD 13.1 CI build job

[libvirt PATCH 0/2] Fix the failing FreeBSD 13.1 CI build job

Posted by Erik Skultety 8 months, 3 weeks ago

failing CI job reference: https://gitlab.com/libvirt/libvirt/-/jobs/4880861477

Even though 13.1 has been marked as EOL and we are rightfully permitted to bump
the version, we can't/shouldn't fix this directly in lcitool just yet, because
libosinfo hasn't caught up on this fact yet and if we just bumped the cirrus
version in the lcitool target OS config without updating the libosinfo ID we'd
create a consistency problem.
However, thanks to Paolo Bonzini's work on lcitool we have an easy workaround
fix at hand where we can override many data-related things in lcitool.

Erik Skultety (2):
  ci: Introduce a new 'lcitool' data directory
  ci: Udate FreeBSD-13 image with lcitool manifest

 ci/gitlab/builds.yml              | 2 +-
 ci/lcitool/targets/freebsd-13.yml | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)
 create mode 100644 ci/lcitool/targets/freebsd-13.yml

-- 
2.41.0

Re: [libvirt PATCH 0/2] Fix the failing FreeBSD 13.1 CI build job

Posted by Michal Prívozník 8 months, 3 weeks ago

On 8/16/23 10:52, Erik Skultety wrote:
> failing CI job reference: https://gitlab.com/libvirt/libvirt/-/jobs/4880861477
> 
> Even though 13.1 has been marked as EOL and we are rightfully permitted to bump
> the version, we can't/shouldn't fix this directly in lcitool just yet, because
> libosinfo hasn't caught up on this fact yet and if we just bumped the cirrus
> version in the lcitool target OS config without updating the libosinfo ID we'd
> create a consistency problem.
> However, thanks to Paolo Bonzini's work on lcitool we have an easy workaround
> fix at hand where we can override many data-related things in lcitool.
> 
> Erik Skultety (2):
>   ci: Introduce a new 'lcitool' data directory
>   ci: Udate FreeBSD-13 image with lcitool manifest
> 
>  ci/gitlab/builds.yml              | 2 +-
>  ci/lcitool/targets/freebsd-13.yml | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
>  create mode 100644 ci/lcitool/targets/freebsd-13.yml
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

Re: [libvirt PATCH 0/2] Fix the failing FreeBSD 13.1 CI build job

Posted by Erik Skultety 8 months, 3 weeks ago

On Wed, Aug 16, 2023 at 10:52:34AM +0200, Erik Skultety wrote:
> failing CI job reference: https://gitlab.com/libvirt/libvirt/-/jobs/4880861477
> 
> Even though 13.1 has been marked as EOL and we are rightfully permitted to bump
> the version, we can't/shouldn't fix this directly in lcitool just yet, because
> libosinfo hasn't caught up on this fact yet and if we just bumped the cirrus
> version in the lcitool target OS config without updating the libosinfo ID we'd
> create a consistency problem.
> However, thanks to Paolo Bonzini's work on lcitool we have an easy workaround
> fix at hand where we can override many data-related things in lcitool.

Forgot to mention one important fact:
After patch 1 a plain '$ lcitool manifest' won't be enough to pick up the
overrides from the ci/lcitool data directory. Instead,
'$ lcitool -d ci/lcitool manifest' will be needed for a correct lcitool
manifest refresh.

Erik

> 
> Erik Skultety (2):
>   ci: Introduce a new 'lcitool' data directory
>   ci: Udate FreeBSD-13 image with lcitool manifest
> 
>  ci/gitlab/builds.yml              | 2 +-
>  ci/lcitool/targets/freebsd-13.yml | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
>  create mode 100644 ci/lcitool/targets/freebsd-13.yml
> 
> -- 
> 2.41.0
>