[PATCH 0/3] Don't use 'query-commands' to probe presence of commands

Peter Krempa posted 3 patches 9 months, 3 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1689341565.git.pkrempa@redhat.com
src/qemu/qemu_capabilities.c                  |  30 +-
src/qemu/qemu_monitor.c                       |  12 -
src/qemu/qemu_monitor.h                       |   2 -
src/qemu/qemu_monitor_json.c                  |  44 -
src/qemu/qemu_monitor_json.h                  |   5 -
.../caps_4.2.0_aarch64.replies                | 700 ++------------
.../caps_4.2.0_ppc64.replies                  | 678 ++------------
.../caps_4.2.0_s390x.replies                  | 686 ++------------
.../caps_4.2.0_x86_64.replies                 | 732 ++-------------
.../caps_5.0.0_aarch64.replies                | 704 ++------------
.../caps_5.0.0_ppc64.replies                  | 690 ++------------
.../caps_5.0.0_riscv64.replies                | 682 ++------------
.../caps_5.0.0_x86_64.replies                 | 736 ++-------------
.../caps_5.1.0_sparc.replies                  | 629 +------------
.../caps_5.1.0_x86_64.replies                 | 743 ++-------------
.../caps_5.2.0_aarch64.replies                | 735 ++-------------
.../caps_5.2.0_ppc64.replies                  | 717 ++-------------
.../caps_5.2.0_riscv64.replies                | 709 ++------------
.../caps_5.2.0_s390x.replies                  | 717 ++-------------
.../caps_5.2.0_x86_64.replies                 | 767 ++--------------
.../caps_6.0.0_aarch64.replies                | 732 ++-------------
.../caps_6.0.0_s390x.replies                  | 714 ++-------------
.../caps_6.0.0_x86_64.replies                 | 767 ++--------------
.../caps_6.1.0_x86_64.replies                 | 770 ++--------------
.../caps_6.2.0_aarch64.replies                | 739 ++-------------
.../caps_6.2.0_ppc64.replies                  | 741 ++-------------
.../caps_6.2.0_x86_64.replies                 | 807 ++--------------
.../caps_7.0.0_aarch64+hvf.replies            | 770 ++--------------
.../caps_7.0.0_aarch64.replies                | 770 ++--------------
.../caps_7.0.0_ppc64.replies                  | 745 ++-------------
.../caps_7.0.0_x86_64.replies                 | 807 ++--------------
.../caps_7.1.0_ppc64.replies                  | 763 ++--------------
.../caps_7.1.0_x86_64.replies                 | 825 ++---------------
.../caps_7.2.0_ppc.replies                    | 772 ++--------------
.../caps_7.2.0_x86_64+hvf.replies             | 843 ++---------------
.../caps_7.2.0_x86_64.replies                 | 843 ++---------------
.../caps_8.0.0_riscv64.replies                | 761 ++-------------
.../caps_8.0.0_x86_64.replies                 | 864 ++----------------
.../caps_8.1.0_s390x.replies                  | 788 ++--------------
.../caps_8.1.0_x86_64.replies                 | 864 ++----------------
tests/qemumonitorjsontest.c                   |  59 --
41 files changed, 2778 insertions(+), 23684 deletions(-)
[PATCH 0/3] Don't use 'query-commands' to probe presence of commands
Posted by Peter Krempa 9 months, 3 weeks ago
We now call 'query-qmp-schema' unconditionally and can extract the
information from there.

Peter Krempa (3):
  qemu: capabilities: Probe presence of commands from QMP schema instead
    of 'query-commands'
  qemu: capabilities: Don't probe 'query-commands'
  qemu_monitor: Remove helpers for 'query-commands'

 src/qemu/qemu_capabilities.c                  |  30 +-
 src/qemu/qemu_monitor.c                       |  12 -
 src/qemu/qemu_monitor.h                       |   2 -
 src/qemu/qemu_monitor_json.c                  |  44 -
 src/qemu/qemu_monitor_json.h                  |   5 -
 .../caps_4.2.0_aarch64.replies                | 700 ++------------
 .../caps_4.2.0_ppc64.replies                  | 678 ++------------
 .../caps_4.2.0_s390x.replies                  | 686 ++------------
 .../caps_4.2.0_x86_64.replies                 | 732 ++-------------
 .../caps_5.0.0_aarch64.replies                | 704 ++------------
 .../caps_5.0.0_ppc64.replies                  | 690 ++------------
 .../caps_5.0.0_riscv64.replies                | 682 ++------------
 .../caps_5.0.0_x86_64.replies                 | 736 ++-------------
 .../caps_5.1.0_sparc.replies                  | 629 +------------
 .../caps_5.1.0_x86_64.replies                 | 743 ++-------------
 .../caps_5.2.0_aarch64.replies                | 735 ++-------------
 .../caps_5.2.0_ppc64.replies                  | 717 ++-------------
 .../caps_5.2.0_riscv64.replies                | 709 ++------------
 .../caps_5.2.0_s390x.replies                  | 717 ++-------------
 .../caps_5.2.0_x86_64.replies                 | 767 ++--------------
 .../caps_6.0.0_aarch64.replies                | 732 ++-------------
 .../caps_6.0.0_s390x.replies                  | 714 ++-------------
 .../caps_6.0.0_x86_64.replies                 | 767 ++--------------
 .../caps_6.1.0_x86_64.replies                 | 770 ++--------------
 .../caps_6.2.0_aarch64.replies                | 739 ++-------------
 .../caps_6.2.0_ppc64.replies                  | 741 ++-------------
 .../caps_6.2.0_x86_64.replies                 | 807 ++--------------
 .../caps_7.0.0_aarch64+hvf.replies            | 770 ++--------------
 .../caps_7.0.0_aarch64.replies                | 770 ++--------------
 .../caps_7.0.0_ppc64.replies                  | 745 ++-------------
 .../caps_7.0.0_x86_64.replies                 | 807 ++--------------
 .../caps_7.1.0_ppc64.replies                  | 763 ++--------------
 .../caps_7.1.0_x86_64.replies                 | 825 ++---------------
 .../caps_7.2.0_ppc.replies                    | 772 ++--------------
 .../caps_7.2.0_x86_64+hvf.replies             | 843 ++---------------
 .../caps_7.2.0_x86_64.replies                 | 843 ++---------------
 .../caps_8.0.0_riscv64.replies                | 761 ++-------------
 .../caps_8.0.0_x86_64.replies                 | 864 ++----------------
 .../caps_8.1.0_s390x.replies                  | 788 ++--------------
 .../caps_8.1.0_x86_64.replies                 | 864 ++----------------
 tests/qemumonitorjsontest.c                   |  59 --
 41 files changed, 2778 insertions(+), 23684 deletions(-)

-- 
2.41.0
Re: [PATCH 0/3] Don't use 'query-commands' to probe presence of commands
Posted by Ján Tomko 9 months, 3 weeks ago
On a Friday in 2023, Peter Krempa wrote:
>We now call 'query-qmp-schema' unconditionally and can extract the
>information from there.
>
>Peter Krempa (3):
>  qemu: capabilities: Probe presence of commands from QMP schema instead
>    of 'query-commands'
>  qemu: capabilities: Don't probe 'query-commands'
>  qemu_monitor: Remove helpers for 'query-commands'
>

There's one more reference to query-commands in a comment in qemuMonitorJSONQueryCPUModelExpansionOne

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano