[v2] introduce external snapshot revert support

[libvirt PATCH v2 24/24] qemu_snapshot: allow snapshot revert for external snapshots

Posted by Pavel Hrdina 2 years, 5 months ago

Now that the support to revert external snapshots is implemented we can
drop this check.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---
 src/qemu/qemu_snapshot.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
index 9e8a7f2f9f..5150e8685a 100644
--- a/src/qemu/qemu_snapshot.c
+++ b/src/qemu/qemu_snapshot.c
@@ -1880,12 +1880,6 @@ qemuSnapshotRevertValidate(virDomainObj *vm,
         return -1;
     }
 
-    if (virDomainSnapshotIsExternal(snap)) {
-        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
-                       _("revert to external snapshot not supported yet"));
-        return -1;
-    }
-
     if (!snap->def->dom) {
         virReportError(VIR_ERR_SNAPSHOT_REVERT_RISKY,
                        _("snapshot '%1$s' lacks domain '%2$s' rollback info"),
-- 
2.41.0

Re: [libvirt PATCH v2 24/24] qemu_snapshot: allow snapshot revert for external snapshots

Posted by Peter Krempa 2 years, 4 months ago

On Tue, Jun 27, 2023 at 17:07:27 +0200, Pavel Hrdina wrote:
> Now that the support to revert external snapshots is implemented we can
> drop this check.
> 
> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> ---
>  src/qemu/qemu_snapshot.c | 6 ------
>  1 file changed, 6 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>