On a Friday in 2023, Peter Krempa wrote:
>Peter Krempa (15):
> virNetDevBandwidthParse: Don't validate element name
> virNetDevBandwidthParse: Use 'virXMLPropUInt' to parse 'classID'
> virNetDevBandwidthParseRate: Refactor parsing
> virNetDevBandwidthParse: Use virXMLNodeGetSubelement instead of looped
> parser
> virNetworkDHCPDefParseXML: Refactor cleanup
> util: xml: Introduce virXMLNodeGetSubelementList
> nwfilterxml2xmltest: Add test case for parser and formatter quirks
> conf: network: Refactor XML parsing in virNetworkDHCPDefParseXML
> conf: nwfilter: Refactor XML formatting in virNWFilterRuleDefFormat
> virNWFilterRuleDef: Turn 'action' and 'tt' into proper enum types
> virNWFilterRuleParse: Parse 'priority' via 'virXMLPropInt'
> virNWFilterRuleParse: Refactor attribute parser
> virNWFilterRuleDefDetailsFormat: Refactor formatter
> conf: nwfilter: Refactor virNWFilterIncludeParse
> conf: nwfilter: Refactor virNWFilterFormatParamAttributes
>
> src/conf/netdev_bandwidth_conf.c | 141 ++-----
> src/conf/network_conf.c | 74 ++--
> src/conf/nwfilter_conf.c | 410 ++++++++------------
> src/conf/nwfilter_conf.h | 4 +-
> src/conf/nwfilter_params.c | 45 +--
> src/libvirt_private.syms | 1 +
> src/nwfilter/nwfilter_ebiptables_driver.c | 5 +
> src/util/virxml.c | 34 ++
> src/util/virxml.h | 5 +
> tests/nwfilterxml2xmlin/quirks-invalid.xml | 13 +
> tests/nwfilterxml2xmlout/quirks-invalid.xml | 7 +
> tests/nwfilterxml2xmltest.c | 5 +
> 12 files changed, 326 insertions(+), 418 deletions(-)
> create mode 100644 tests/nwfilterxml2xmlin/quirks-invalid.xml
> create mode 100644 tests/nwfilterxml2xmlout/quirks-invalid.xml
>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Jano