[PATCH 00/18] QMP schema validation fixes

Peter Krempa posted 18 patches 10 months, 3 weeks ago
Failed in applying to current master (apply log)
src/qemu/qemu_command.c      |   2 +-
src/qemu/qemu_command.h      |   2 +-
src/qemu/qemu_driver.c       |  40 ++----
src/qemu/qemu_hotplug.c      |   4 +-
src/qemu/qemu_monitor.c      |  12 +-
src/qemu/qemu_monitor.h      |   2 -
src/qemu/qemu_monitor_json.c |  14 +-
src/qemu/qemu_monitor_json.h |   2 -
src/qemu/qemu_process.c      |  12 +-
src/qemu/qemu_validate.c     |   8 ++
src/util/virerror.c          |   4 +-
tests/qemuagenttest.c        |  92 ++++++------
tests/qemumonitorjsontest.c  | 153 ++++++++++----------
tests/qemumonitortestutils.c | 266 +++--------------------------------
tests/qemumonitortestutils.h |  16 +--
tests/testutilsqemuschema.c  |   4 +
16 files changed, 191 insertions(+), 442 deletions(-)
[PATCH 00/18] QMP schema validation fixes
Posted by Peter Krempa 10 months, 3 weeks ago
Turns out we still had wired up use of 'device' argument of
block_set_io_throttle which got deprecated and our valiator didn't catch
it due to multiple reasons. Address all of that.

Peter Krempa (18):
  qemuMonitorTestAddItemVerbatim: Simplify cleanup
  qemuMonitorTestAddHandler: Remove return value
  virRaiseErrorLog: Don't skip error printing when enabling debug
    logging env variable
  testQemuMonitorJSONAttachChardev: Move all setup code under virTestRun
  qemuMonitorJSONTestAttachOneChardev: Rewrite using
    qemuMonitorTestAddItemVerbatim
  qemuMonitorTestAddItemExpect: Remove unused helper
  testQemuAgentCPU: Rewrite using qemuMonitorTestAddItemVerbatim
  testQemuAgentFSTrim: Rewrite using qemuMonitorTestAddItemVerbatim
  testQemuMonitorJSONqemuMonitorJSONSendKeyHoldtime: Rewrite using
    qemuMonitorTestAddItemVerbatim
  testQemuMonitorJSONqemuMonitorJSONSetBlockIoThrottle: Rewrite using
    qemuMonitorTestAddItemVerbatim
  Drop unused qemuMonitorTestAddItemParams
  qemumonitorjsontest: Drop 'schema-meta' case
  qemuDiskConfigBlkdeviotuneEnabled: Make 'disk' argument const
  qemu: Refuse setting <iotune> for 'SD' disks
  qemumonitorjsontest: Use 'id' instead of deprecated 'device' argument
    of 'block_set_io_throttle'
  qemuMonitorGetBlockIoThrottle: Drop 'diskalias' argument
  qemuMonitorSetBlockIoThrottle: Drop 'diskalias' argument
  testQEMUSchemaValidateObjectMember: validate QMP object member
    deprecation

 src/qemu/qemu_command.c      |   2 +-
 src/qemu/qemu_command.h      |   2 +-
 src/qemu/qemu_driver.c       |  40 ++----
 src/qemu/qemu_hotplug.c      |   4 +-
 src/qemu/qemu_monitor.c      |  12 +-
 src/qemu/qemu_monitor.h      |   2 -
 src/qemu/qemu_monitor_json.c |  14 +-
 src/qemu/qemu_monitor_json.h |   2 -
 src/qemu/qemu_process.c      |  12 +-
 src/qemu/qemu_validate.c     |   8 ++
 src/util/virerror.c          |   4 +-
 tests/qemuagenttest.c        |  92 ++++++------
 tests/qemumonitorjsontest.c  | 153 ++++++++++----------
 tests/qemumonitortestutils.c | 266 +++--------------------------------
 tests/qemumonitortestutils.h |  16 +--
 tests/testutilsqemuschema.c  |   4 +
 16 files changed, 191 insertions(+), 442 deletions(-)

-- 
2.40.1