[PATCH 0/3] Audio test cleanups

Peter Krempa posted 3 patches 9 months, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1683650075.git.pkrempa@redhat.com
...gs => audio-default-sdl.x86_64-4.2.0.args} |  6 +-
... => audio-default-spice.x86_64-4.2.0.args} |  6 +-
...gs => audio-default-vnc.x86_64-4.2.0.args} |  6 +-
tests/qemuxml2argvtest.c                      |  6 +-
.../audio-alsa-best.x86_64-latest.xml         | 46 ++++++++++++++
tests/qemuxml2xmloutdata/audio-alsa-best.xml  |  1 -
.../audio-alsa-full.x86_64-latest.xml         | 46 ++++++++++++++
tests/qemuxml2xmloutdata/audio-alsa-full.xml  |  1 -
.../audio-alsa-minimal.x86_64-latest.xml      | 39 ++++++++++++
.../qemuxml2xmloutdata/audio-alsa-minimal.xml |  1 -
.../audio-coreaudio-best.x86_64-latest.xml    | 46 ++++++++++++++
.../audio-coreaudio-best.xml                  |  1 -
.../audio-coreaudio-full.x86_64-latest.xml    | 46 ++++++++++++++
.../audio-coreaudio-full.xml                  |  1 -
.../audio-coreaudio-minimal.x86_64-latest.xml | 39 ++++++++++++
.../audio-coreaudio-minimal.xml               |  1 -
.../audio-file-best.x86_64-latest.xml         | 46 ++++++++++++++
tests/qemuxml2xmloutdata/audio-file-best.xml  |  1 -
.../audio-file-full.x86_64-latest.xml         | 46 ++++++++++++++
tests/qemuxml2xmloutdata/audio-file-full.xml  |  1 -
.../audio-file-minimal.x86_64-latest.xml      | 39 ++++++++++++
.../qemuxml2xmloutdata/audio-file-minimal.xml |  1 -
.../audio-jack-full.x86_64-latest.xml         | 46 ++++++++++++++
tests/qemuxml2xmloutdata/audio-jack-full.xml  |  1 -
.../audio-many-backends.x86_64-latest.xml     | 61 ++++++++++++++++++-
.../audio-none-best.x86_64-latest.xml         | 46 ++++++++++++++
tests/qemuxml2xmloutdata/audio-none-best.xml  |  1 -
.../audio-none-full.x86_64-latest.xml         | 46 ++++++++++++++
tests/qemuxml2xmloutdata/audio-none-full.xml  |  1 -
.../audio-none-minimal.x86_64-latest.xml      | 39 ++++++++++++
.../qemuxml2xmloutdata/audio-none-minimal.xml |  1 -
.../audio-oss-best.x86_64-latest.xml          | 46 ++++++++++++++
tests/qemuxml2xmloutdata/audio-oss-best.xml   |  1 -
.../audio-oss-full.x86_64-latest.xml          | 46 ++++++++++++++
tests/qemuxml2xmloutdata/audio-oss-full.xml   |  1 -
.../audio-oss-minimal.x86_64-latest.xml       | 39 ++++++++++++
.../qemuxml2xmloutdata/audio-oss-minimal.xml  |  1 -
.../audio-pulseaudio-best.x86_64-latest.xml   | 46 ++++++++++++++
.../audio-pulseaudio-best.xml                 |  1 -
.../audio-pulseaudio-full.x86_64-latest.xml   | 46 ++++++++++++++
.../audio-pulseaudio-full.xml                 |  1 -
...audio-pulseaudio-minimal.x86_64-latest.xml | 39 ++++++++++++
.../audio-pulseaudio-minimal.xml              |  1 -
.../audio-sdl-best.x86_64-latest.xml          | 46 ++++++++++++++
tests/qemuxml2xmloutdata/audio-sdl-best.xml   |  1 -
.../audio-sdl-full.x86_64-latest.xml          | 46 ++++++++++++++
tests/qemuxml2xmloutdata/audio-sdl-full.xml   |  1 -
.../audio-sdl-minimal.x86_64-latest.xml       | 39 ++++++++++++
.../qemuxml2xmloutdata/audio-sdl-minimal.xml  |  1 -
.../audio-spice-best.x86_64-latest.xml        | 53 ++++++++++++++++
tests/qemuxml2xmloutdata/audio-spice-best.xml |  1 -
.../audio-spice-full.x86_64-latest.xml        | 53 ++++++++++++++++
tests/qemuxml2xmloutdata/audio-spice-full.xml |  1 -
.../audio-spice-minimal.x86_64-latest.xml     | 46 ++++++++++++++
.../audio-spice-minimal.xml                   |  1 -
tests/qemuxml2xmltest.c                       | 56 ++++++++---------
56 files changed, 1215 insertions(+), 66 deletions(-)
rename tests/qemuxml2argvdata/{audio-default-sdl.args => audio-default-sdl.x86_64-4.2.0.args} (86%)
rename tests/qemuxml2argvdata/{audio-default-spice.args => audio-default-spice.x86_64-4.2.0.args} (86%)
rename tests/qemuxml2argvdata/{audio-default-vnc.args => audio-default-vnc.x86_64-4.2.0.args} (86%)
create mode 100644 tests/qemuxml2xmloutdata/audio-alsa-best.x86_64-latest.xml
delete mode 120000 tests/qemuxml2xmloutdata/audio-alsa-best.xml
create mode 100644 tests/qemuxml2xmloutdata/audio-alsa-full.x86_64-latest.xml
delete mode 120000 tests/qemuxml2xmloutdata/audio-alsa-full.xml
create mode 100644 tests/qemuxml2xmloutdata/audio-alsa-minimal.x86_64-latest.xml
delete mode 120000 tests/qemuxml2xmloutdata/audio-alsa-minimal.xml
create mode 100644 tests/qemuxml2xmloutdata/audio-coreaudio-best.x86_64-latest.xml
delete mode 120000 tests/qemuxml2xmloutdata/audio-coreaudio-best.xml
create mode 100644 tests/qemuxml2xmloutdata/audio-coreaudio-full.x86_64-latest.xml
delete mode 120000 tests/qemuxml2xmloutdata/audio-coreaudio-full.xml
create mode 100644 tests/qemuxml2xmloutdata/audio-coreaudio-minimal.x86_64-latest.xml
delete mode 120000 tests/qemuxml2xmloutdata/audio-coreaudio-minimal.xml
create mode 100644 tests/qemuxml2xmloutdata/audio-file-best.x86_64-latest.xml
delete mode 120000 tests/qemuxml2xmloutdata/audio-file-best.xml
create mode 100644 tests/qemuxml2xmloutdata/audio-file-full.x86_64-latest.xml
delete mode 120000 tests/qemuxml2xmloutdata/audio-file-full.xml
create mode 100644 tests/qemuxml2xmloutdata/audio-file-minimal.x86_64-latest.xml
delete mode 120000 tests/qemuxml2xmloutdata/audio-file-minimal.xml
create mode 100644 tests/qemuxml2xmloutdata/audio-jack-full.x86_64-latest.xml
delete mode 120000 tests/qemuxml2xmloutdata/audio-jack-full.xml
mode change 120000 => 100644 tests/qemuxml2xmloutdata/audio-many-backends.x86_64-latest.xml
create mode 100644 tests/qemuxml2xmloutdata/audio-none-best.x86_64-latest.xml
delete mode 120000 tests/qemuxml2xmloutdata/audio-none-best.xml
create mode 100644 tests/qemuxml2xmloutdata/audio-none-full.x86_64-latest.xml
delete mode 120000 tests/qemuxml2xmloutdata/audio-none-full.xml
create mode 100644 tests/qemuxml2xmloutdata/audio-none-minimal.x86_64-latest.xml
delete mode 120000 tests/qemuxml2xmloutdata/audio-none-minimal.xml
create mode 100644 tests/qemuxml2xmloutdata/audio-oss-best.x86_64-latest.xml
delete mode 120000 tests/qemuxml2xmloutdata/audio-oss-best.xml
create mode 100644 tests/qemuxml2xmloutdata/audio-oss-full.x86_64-latest.xml
delete mode 120000 tests/qemuxml2xmloutdata/audio-oss-full.xml
create mode 100644 tests/qemuxml2xmloutdata/audio-oss-minimal.x86_64-latest.xml
delete mode 120000 tests/qemuxml2xmloutdata/audio-oss-minimal.xml
create mode 100644 tests/qemuxml2xmloutdata/audio-pulseaudio-best.x86_64-latest.xml
delete mode 120000 tests/qemuxml2xmloutdata/audio-pulseaudio-best.xml
create mode 100644 tests/qemuxml2xmloutdata/audio-pulseaudio-full.x86_64-latest.xml
delete mode 120000 tests/qemuxml2xmloutdata/audio-pulseaudio-full.xml
create mode 100644 tests/qemuxml2xmloutdata/audio-pulseaudio-minimal.x86_64-latest.xml
delete mode 120000 tests/qemuxml2xmloutdata/audio-pulseaudio-minimal.xml
create mode 100644 tests/qemuxml2xmloutdata/audio-sdl-best.x86_64-latest.xml
delete mode 120000 tests/qemuxml2xmloutdata/audio-sdl-best.xml
create mode 100644 tests/qemuxml2xmloutdata/audio-sdl-full.x86_64-latest.xml
delete mode 120000 tests/qemuxml2xmloutdata/audio-sdl-full.xml
create mode 100644 tests/qemuxml2xmloutdata/audio-sdl-minimal.x86_64-latest.xml
delete mode 120000 tests/qemuxml2xmloutdata/audio-sdl-minimal.xml
create mode 100644 tests/qemuxml2xmloutdata/audio-spice-best.x86_64-latest.xml
delete mode 120000 tests/qemuxml2xmloutdata/audio-spice-best.xml
create mode 100644 tests/qemuxml2xmloutdata/audio-spice-full.x86_64-latest.xml
delete mode 120000 tests/qemuxml2xmloutdata/audio-spice-full.xml
create mode 100644 tests/qemuxml2xmloutdata/audio-spice-minimal.x86_64-latest.xml
delete mode 120000 tests/qemuxml2xmloutdata/audio-spice-minimal.xml
[PATCH 0/3] Audio test cleanups
Posted by Peter Krempa 9 months, 2 weeks ago
Few things I've cleaned up before realizing that:

https://gitlab.com/libvirt/libvirt/-/issues/473

can't really be solved without qemu assistance.

Peter Krempa (3):
  qemuxml2xmlout: Replace symlinks of all 'audio-' tests by real files
  qemuxml2argvtest: Use real caps instead of fake caps for
    'audio-default-*' cases
  qemuxml2xmltest: Modernize all 'audio-' cases

 ...gs => audio-default-sdl.x86_64-4.2.0.args} |  6 +-
 ... => audio-default-spice.x86_64-4.2.0.args} |  6 +-
 ...gs => audio-default-vnc.x86_64-4.2.0.args} |  6 +-
 tests/qemuxml2argvtest.c                      |  6 +-
 .../audio-alsa-best.x86_64-latest.xml         | 46 ++++++++++++++
 tests/qemuxml2xmloutdata/audio-alsa-best.xml  |  1 -
 .../audio-alsa-full.x86_64-latest.xml         | 46 ++++++++++++++
 tests/qemuxml2xmloutdata/audio-alsa-full.xml  |  1 -
 .../audio-alsa-minimal.x86_64-latest.xml      | 39 ++++++++++++
 .../qemuxml2xmloutdata/audio-alsa-minimal.xml |  1 -
 .../audio-coreaudio-best.x86_64-latest.xml    | 46 ++++++++++++++
 .../audio-coreaudio-best.xml                  |  1 -
 .../audio-coreaudio-full.x86_64-latest.xml    | 46 ++++++++++++++
 .../audio-coreaudio-full.xml                  |  1 -
 .../audio-coreaudio-minimal.x86_64-latest.xml | 39 ++++++++++++
 .../audio-coreaudio-minimal.xml               |  1 -
 .../audio-file-best.x86_64-latest.xml         | 46 ++++++++++++++
 tests/qemuxml2xmloutdata/audio-file-best.xml  |  1 -
 .../audio-file-full.x86_64-latest.xml         | 46 ++++++++++++++
 tests/qemuxml2xmloutdata/audio-file-full.xml  |  1 -
 .../audio-file-minimal.x86_64-latest.xml      | 39 ++++++++++++
 .../qemuxml2xmloutdata/audio-file-minimal.xml |  1 -
 .../audio-jack-full.x86_64-latest.xml         | 46 ++++++++++++++
 tests/qemuxml2xmloutdata/audio-jack-full.xml  |  1 -
 .../audio-many-backends.x86_64-latest.xml     | 61 ++++++++++++++++++-
 .../audio-none-best.x86_64-latest.xml         | 46 ++++++++++++++
 tests/qemuxml2xmloutdata/audio-none-best.xml  |  1 -
 .../audio-none-full.x86_64-latest.xml         | 46 ++++++++++++++
 tests/qemuxml2xmloutdata/audio-none-full.xml  |  1 -
 .../audio-none-minimal.x86_64-latest.xml      | 39 ++++++++++++
 .../qemuxml2xmloutdata/audio-none-minimal.xml |  1 -
 .../audio-oss-best.x86_64-latest.xml          | 46 ++++++++++++++
 tests/qemuxml2xmloutdata/audio-oss-best.xml   |  1 -
 .../audio-oss-full.x86_64-latest.xml          | 46 ++++++++++++++
 tests/qemuxml2xmloutdata/audio-oss-full.xml   |  1 -
 .../audio-oss-minimal.x86_64-latest.xml       | 39 ++++++++++++
 .../qemuxml2xmloutdata/audio-oss-minimal.xml  |  1 -
 .../audio-pulseaudio-best.x86_64-latest.xml   | 46 ++++++++++++++
 .../audio-pulseaudio-best.xml                 |  1 -
 .../audio-pulseaudio-full.x86_64-latest.xml   | 46 ++++++++++++++
 .../audio-pulseaudio-full.xml                 |  1 -
 ...audio-pulseaudio-minimal.x86_64-latest.xml | 39 ++++++++++++
 .../audio-pulseaudio-minimal.xml              |  1 -
 .../audio-sdl-best.x86_64-latest.xml          | 46 ++++++++++++++
 tests/qemuxml2xmloutdata/audio-sdl-best.xml   |  1 -
 .../audio-sdl-full.x86_64-latest.xml          | 46 ++++++++++++++
 tests/qemuxml2xmloutdata/audio-sdl-full.xml   |  1 -
 .../audio-sdl-minimal.x86_64-latest.xml       | 39 ++++++++++++
 .../qemuxml2xmloutdata/audio-sdl-minimal.xml  |  1 -
 .../audio-spice-best.x86_64-latest.xml        | 53 ++++++++++++++++
 tests/qemuxml2xmloutdata/audio-spice-best.xml |  1 -
 .../audio-spice-full.x86_64-latest.xml        | 53 ++++++++++++++++
 tests/qemuxml2xmloutdata/audio-spice-full.xml |  1 -
 .../audio-spice-minimal.x86_64-latest.xml     | 46 ++++++++++++++
 .../audio-spice-minimal.xml                   |  1 -
 tests/qemuxml2xmltest.c                       | 56 ++++++++---------
 56 files changed, 1215 insertions(+), 66 deletions(-)
 rename tests/qemuxml2argvdata/{audio-default-sdl.args => audio-default-sdl.x86_64-4.2.0.args} (86%)
 rename tests/qemuxml2argvdata/{audio-default-spice.args => audio-default-spice.x86_64-4.2.0.args} (86%)
 rename tests/qemuxml2argvdata/{audio-default-vnc.args => audio-default-vnc.x86_64-4.2.0.args} (86%)
 create mode 100644 tests/qemuxml2xmloutdata/audio-alsa-best.x86_64-latest.xml
 delete mode 120000 tests/qemuxml2xmloutdata/audio-alsa-best.xml
 create mode 100644 tests/qemuxml2xmloutdata/audio-alsa-full.x86_64-latest.xml
 delete mode 120000 tests/qemuxml2xmloutdata/audio-alsa-full.xml
 create mode 100644 tests/qemuxml2xmloutdata/audio-alsa-minimal.x86_64-latest.xml
 delete mode 120000 tests/qemuxml2xmloutdata/audio-alsa-minimal.xml
 create mode 100644 tests/qemuxml2xmloutdata/audio-coreaudio-best.x86_64-latest.xml
 delete mode 120000 tests/qemuxml2xmloutdata/audio-coreaudio-best.xml
 create mode 100644 tests/qemuxml2xmloutdata/audio-coreaudio-full.x86_64-latest.xml
 delete mode 120000 tests/qemuxml2xmloutdata/audio-coreaudio-full.xml
 create mode 100644 tests/qemuxml2xmloutdata/audio-coreaudio-minimal.x86_64-latest.xml
 delete mode 120000 tests/qemuxml2xmloutdata/audio-coreaudio-minimal.xml
 create mode 100644 tests/qemuxml2xmloutdata/audio-file-best.x86_64-latest.xml
 delete mode 120000 tests/qemuxml2xmloutdata/audio-file-best.xml
 create mode 100644 tests/qemuxml2xmloutdata/audio-file-full.x86_64-latest.xml
 delete mode 120000 tests/qemuxml2xmloutdata/audio-file-full.xml
 create mode 100644 tests/qemuxml2xmloutdata/audio-file-minimal.x86_64-latest.xml
 delete mode 120000 tests/qemuxml2xmloutdata/audio-file-minimal.xml
 create mode 100644 tests/qemuxml2xmloutdata/audio-jack-full.x86_64-latest.xml
 delete mode 120000 tests/qemuxml2xmloutdata/audio-jack-full.xml
 mode change 120000 => 100644 tests/qemuxml2xmloutdata/audio-many-backends.x86_64-latest.xml
 create mode 100644 tests/qemuxml2xmloutdata/audio-none-best.x86_64-latest.xml
 delete mode 120000 tests/qemuxml2xmloutdata/audio-none-best.xml
 create mode 100644 tests/qemuxml2xmloutdata/audio-none-full.x86_64-latest.xml
 delete mode 120000 tests/qemuxml2xmloutdata/audio-none-full.xml
 create mode 100644 tests/qemuxml2xmloutdata/audio-none-minimal.x86_64-latest.xml
 delete mode 120000 tests/qemuxml2xmloutdata/audio-none-minimal.xml
 create mode 100644 tests/qemuxml2xmloutdata/audio-oss-best.x86_64-latest.xml
 delete mode 120000 tests/qemuxml2xmloutdata/audio-oss-best.xml
 create mode 100644 tests/qemuxml2xmloutdata/audio-oss-full.x86_64-latest.xml
 delete mode 120000 tests/qemuxml2xmloutdata/audio-oss-full.xml
 create mode 100644 tests/qemuxml2xmloutdata/audio-oss-minimal.x86_64-latest.xml
 delete mode 120000 tests/qemuxml2xmloutdata/audio-oss-minimal.xml
 create mode 100644 tests/qemuxml2xmloutdata/audio-pulseaudio-best.x86_64-latest.xml
 delete mode 120000 tests/qemuxml2xmloutdata/audio-pulseaudio-best.xml
 create mode 100644 tests/qemuxml2xmloutdata/audio-pulseaudio-full.x86_64-latest.xml
 delete mode 120000 tests/qemuxml2xmloutdata/audio-pulseaudio-full.xml
 create mode 100644 tests/qemuxml2xmloutdata/audio-pulseaudio-minimal.x86_64-latest.xml
 delete mode 120000 tests/qemuxml2xmloutdata/audio-pulseaudio-minimal.xml
 create mode 100644 tests/qemuxml2xmloutdata/audio-sdl-best.x86_64-latest.xml
 delete mode 120000 tests/qemuxml2xmloutdata/audio-sdl-best.xml
 create mode 100644 tests/qemuxml2xmloutdata/audio-sdl-full.x86_64-latest.xml
 delete mode 120000 tests/qemuxml2xmloutdata/audio-sdl-full.xml
 create mode 100644 tests/qemuxml2xmloutdata/audio-sdl-minimal.x86_64-latest.xml
 delete mode 120000 tests/qemuxml2xmloutdata/audio-sdl-minimal.xml
 create mode 100644 tests/qemuxml2xmloutdata/audio-spice-best.x86_64-latest.xml
 delete mode 120000 tests/qemuxml2xmloutdata/audio-spice-best.xml
 create mode 100644 tests/qemuxml2xmloutdata/audio-spice-full.x86_64-latest.xml
 delete mode 120000 tests/qemuxml2xmloutdata/audio-spice-full.xml
 create mode 100644 tests/qemuxml2xmloutdata/audio-spice-minimal.x86_64-latest.xml
 delete mode 120000 tests/qemuxml2xmloutdata/audio-spice-minimal.xml

-- 
2.40.1
Re: [PATCH 0/3] Audio test cleanups
Posted by Ján Tomko 9 months, 2 weeks ago
On a Tuesday in 2023, Peter Krempa wrote:
>Few things I've cleaned up before realizing that:
>
>https://gitlab.com/libvirt/libvirt/-/issues/473
>
>can't really be solved without qemu assistance.
>
>Peter Krempa (3):
>  qemuxml2xmlout: Replace symlinks of all 'audio-' tests by real files
>  qemuxml2argvtest: Use real caps instead of fake caps for
>    'audio-default-*' cases
>  qemuxml2xmltest: Modernize all 'audio-' cases
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano