[libvirt PATCH 0/4] ci: Update to latest lcitool, drop Fedora 36 & add Fedora 38

Erik Skultety posted 4 patches 11 months, 2 weeks ago
Failed in applying to current master (apply log)
...-mingw32.sh => fedora-38-cross-mingw32.sh} |   0
...-mingw64.sh => fedora-38-cross-mingw64.sh} |   0
ci/buildenv/{fedora-36.sh => fedora-38.sh}    |   0
...ile => fedora-38-cross-mingw32.Dockerfile} |   2 +-
...ile => fedora-38-cross-mingw64.Dockerfile} |   2 +-
...ora-36.Dockerfile => fedora-38.Dockerfile} |   2 +-
ci/gitlab/builds.yml                          |  76 ++++++-------
ci/gitlab/containers.yml                      |  22 ++--
ci/integration.yml                            | 104 +++++++++---------
ci/manifest.yml                               |  17 +--
10 files changed, 113 insertions(+), 112 deletions(-)
rename ci/buildenv/{fedora-37-cross-mingw32.sh => fedora-38-cross-mingw32.sh} (100%)
rename ci/buildenv/{fedora-37-cross-mingw64.sh => fedora-38-cross-mingw64.sh} (100%)
rename ci/buildenv/{fedora-36.sh => fedora-38.sh} (100%)
rename ci/containers/{fedora-37-cross-mingw32.Dockerfile => fedora-38-cross-mingw32.Dockerfile} (98%)
rename ci/containers/{fedora-37-cross-mingw64.Dockerfile => fedora-38-cross-mingw64.Dockerfile} (98%)
rename ci/containers/{fedora-36.Dockerfile => fedora-38.Dockerfile} (98%)
[libvirt PATCH 0/4] ci: Update to latest lcitool, drop Fedora 36 & add Fedora 38
Posted by Erik Skultety 11 months, 2 weeks ago
This depends on the corresponding changes in libvirt-perl and libvirt-python:

https://gitlab.com/libvirt/libvirt-perl/-/merge_requests/92
https://gitlab.com/libvirt/libvirt-python/-/merge_requests/114

Once those are in, I'll provide a link to a fresh libvirt proof pipeline.

Erik Skultety (4):
  ci: Add Fedora 38 target
  ci: Drop Fedora 36 target
  ci: Flip mingw jobs from Fedora 37 to Fedora 38
  ci: integration: Flip QEMU upstream integration tests to Fedora 38

 ...-mingw32.sh => fedora-38-cross-mingw32.sh} |   0
 ...-mingw64.sh => fedora-38-cross-mingw64.sh} |   0
 ci/buildenv/{fedora-36.sh => fedora-38.sh}    |   0
 ...ile => fedora-38-cross-mingw32.Dockerfile} |   2 +-
 ...ile => fedora-38-cross-mingw64.Dockerfile} |   2 +-
 ...ora-36.Dockerfile => fedora-38.Dockerfile} |   2 +-
 ci/gitlab/builds.yml                          |  76 ++++++-------
 ci/gitlab/containers.yml                      |  22 ++--
 ci/integration.yml                            | 104 +++++++++---------
 ci/manifest.yml                               |  17 +--
 10 files changed, 113 insertions(+), 112 deletions(-)
 rename ci/buildenv/{fedora-37-cross-mingw32.sh => fedora-38-cross-mingw32.sh} (100%)
 rename ci/buildenv/{fedora-37-cross-mingw64.sh => fedora-38-cross-mingw64.sh} (100%)
 rename ci/buildenv/{fedora-36.sh => fedora-38.sh} (100%)
 rename ci/containers/{fedora-37-cross-mingw32.Dockerfile => fedora-38-cross-mingw32.Dockerfile} (98%)
 rename ci/containers/{fedora-37-cross-mingw64.Dockerfile => fedora-38-cross-mingw64.Dockerfile} (98%)
 rename ci/containers/{fedora-36.Dockerfile => fedora-38.Dockerfile} (98%)

-- 
2.40.0
Re: [libvirt PATCH 0/4] ci: Update to latest lcitool, drop Fedora 36 & add Fedora 38
Posted by Andrea Bolognani 11 months, 2 weeks ago
On Wed, May 03, 2023 at 09:19:10AM +0200, Erik Skultety wrote:
> This depends on the corresponding changes in libvirt-perl and libvirt-python:
>
> https://gitlab.com/libvirt/libvirt-perl/-/merge_requests/92
> https://gitlab.com/libvirt/libvirt-python/-/merge_requests/114
>
> Once those are in, I'll provide a link to a fresh libvirt proof pipeline.
>
> Erik Skultety (4):
>   ci: Add Fedora 38 target
>   ci: Drop Fedora 36 target
>   ci: Flip mingw jobs from Fedora 37 to Fedora 38
>   ci: integration: Flip QEMU upstream integration tests to Fedora 38

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization
Re: [libvirt PATCH 0/4] ci: Update to latest lcitool, drop Fedora 36 & add Fedora 38
Posted by Erik Skultety 11 months, 1 week ago
On Wed, May 03, 2023 at 09:24:45AM +0100, Andrea Bolognani wrote:
> On Wed, May 03, 2023 at 09:19:10AM +0200, Erik Skultety wrote:
> > This depends on the corresponding changes in libvirt-perl and libvirt-python:
> >
> > https://gitlab.com/libvirt/libvirt-perl/-/merge_requests/92
> > https://gitlab.com/libvirt/libvirt-python/-/merge_requests/114
> >
> > Once those are in, I'll provide a link to a fresh libvirt proof pipeline.
> >
> > Erik Skultety (4):
> >   ci: Add Fedora 38 target
> >   ci: Drop Fedora 36 target
> >   ci: Flip mingw jobs from Fedora 37 to Fedora 38
> >   ci: integration: Flip QEMU upstream integration tests to Fedora 38
> 
> Reviewed-by: Andrea Bolognani <abologna@redhat.com>

Thanks!

So, I couldn't merge this just yet, as tests started failing on F38, here's an
MR with necessary fixes for that:
https://gitlab.com/libvirt/libvirt-tck/-/merge_requests/41

Here's a pipeline including ^those fixes + Fedora 38 (as promised):
https://gitlab.com/eskultety/libvirt/-/pipelines/858474139

@abologna: After the lcitool refresh I also need this bit in to fix Leap 15.4:
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 3a36c0ef18..2378b1a39f 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -118,10 +118,10 @@ codestyle_prebuilt_env:
     - .codestyle_job
     - .gitlab_native_build_job_prebuilt_env
   needs:
-    - job: x86_64-opensuse-leap-154-container
+    - job: x86_64-opensuse-leap-15-container
       optional: true
   variables:
-    NAME: opensuse-leap-154
+    NAME: opensuse-leap-15

 codestyle_local_env:
   extends:
@@ -129,7 +129,7 @@ codestyle_local_env:
     - .gitlab_native_build_job_local_env
   variables:
     IMAGE: registry.opensuse.org/opensuse/leap:15.4
-    NAME: opensuse-leap-154
+    NAME: opensuse-leap-15


Please let me know if your RB still stands or whether I need to respin with
that change.

Regards,
Erik
Re: [libvirt PATCH 0/4] ci: Update to latest lcitool, drop Fedora 36 & add Fedora 38
Posted by Andrea Bolognani 11 months, 1 week ago
On Fri, May 05, 2023 at 04:41:34PM +0200, Erik Skultety wrote:
> So, I couldn't merge this just yet, as tests started failing on F38, here's an
> MR with necessary fixes for that:
> https://gitlab.com/libvirt/libvirt-tck/-/merge_requests/41

I don't feel qualified to review those changes, sorry!

> Here's a pipeline including ^those fixes + Fedora 38 (as promised):
> https://gitlab.com/eskultety/libvirt/-/pipelines/858474139

Looking good.

> @abologna: After the lcitool refresh I also need this bit in to fix Leap 15.4:
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 3a36c0ef18..2378b1a39f 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -118,10 +118,10 @@ codestyle_prebuilt_env:
>      - .codestyle_job
>      - .gitlab_native_build_job_prebuilt_env
>    needs:
> -    - job: x86_64-opensuse-leap-154-container
> +    - job: x86_64-opensuse-leap-15-container
>        optional: true
>    variables:
> -    NAME: opensuse-leap-154
> +    NAME: opensuse-leap-15
>
>  codestyle_local_env:
>    extends:
> @@ -129,7 +129,7 @@ codestyle_local_env:
>      - .gitlab_native_build_job_local_env
>    variables:
>      IMAGE: registry.opensuse.org/opensuse/leap:15.4
> -    NAME: opensuse-leap-154
> +    NAME: opensuse-leap-15
>
> Please let me know if your RB still stands or whether I need to respin with
> that change.

That should have happened as part of a3cc0e9ceb3e. Good catch. Please
post it as a separate patch though.

-- 
Andrea Bolognani / Red Hat / Virtualization