qemuhotplugtest: Various cleanups and improvements

[PATCH 09/11] qemuhotplugtest: Don't overwrite vm->def->id in testQemuHotplugCheckResult()

Posted by Michal Privoznik 1 year, 7 months ago

This is a leftover from v2.0.0-rc1~300. In v1.2.12-rc1~43 we've
introduced a code that explicitly sets vm->def->id to -1 to force
generation of inactive XML. But this was removed in the later
commit, which forgot to remove the restoration of the original
dom ID.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 tests/qemuhotplugtest.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c
index 9a1cf8ab2f..d5ceb1373b 100644
--- a/tests/qemuhotplugtest.c
+++ b/tests/qemuhotplugtest.c
@@ -122,7 +122,6 @@ testQemuHotplugCheckResult(virDomainObj *vm,
                                 VIR_DOMAIN_DEF_FORMAT_SECURE);
     if (!actual)
         return -1;
-    vm->def->id = QEMU_HOTPLUG_TEST_DOMAIN_ID;
 
     if (STREQ(expected, actual)) {
         if (fail)
-- 
2.39.2

Re: [PATCH 09/11] qemuhotplugtest: Don't overwrite vm->def->id in testQemuHotplugCheckResult()

Posted by Kristina Hanicova 1 year, 7 months ago

On Fri, Apr 21, 2023 at 10:25 AM Michal Privoznik <mprivozn@redhat.com>
wrote:

> This is a leftover from v2.0.0-rc1~300. In v1.2.12-rc1~43 we've
> introduced a code that explicitly sets vm->def->id to -1 to force
> generation of inactive XML. But this was removed in the later
> commit, which forgot to remove the restoration of the original
> dom ID.
>
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  tests/qemuhotplugtest.c | 1 -
>  1 file changed, 1 deletion(-)
>
Reviewed-by: Kristina Hanicova <khanicov@redhat.com>

Kristina