[PATCH 00/11] qemuhotplugtest: Various cleanups and improvements

Michal Privoznik posted 11 patches 1 year, 7 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1682065352.git.mprivozn@redhat.com
src/qemu/qemu_driver.c                        | 472 +---------------
src/qemu/qemu_hotplug.c                       | 525 +++++++++++++++++-
src/qemu/qemu_hotplug.h                       |  68 +--
tests/qemuhotplugtest.c                       | 197 +------
...hotplug-disk-cdrom+disk-cdrom-nochange.xml |   1 +
.../qemuhotplug-disk-cdrom.xml                |  30 +-
...graphics-spice+graphics-spice-nochange.xml |   1 +
...graphics-spice-listen-network-password.xml |  71 +++
...imeout+graphics-spice-timeout-nochange.xml |   1 +
...imeout+graphics-spice-timeout-password.xml | 117 ++++
.../qemuhotplug-graphics-spice-timeout.xml    |  50 +-
.../qemuhotplug-graphics-spice.xml            |  41 +-
12 files changed, 819 insertions(+), 755 deletions(-)
create mode 120000 tests/qemuhotplugtestdomains/qemuhotplug-disk-cdrom+disk-cdrom-nochange.xml
create mode 120000 tests/qemuhotplugtestdomains/qemuhotplug-graphics-spice+graphics-spice-nochange.xml
create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-graphics-spice-listen-network+graphics-spice-listen-network-password.xml
create mode 120000 tests/qemuhotplugtestdomains/qemuhotplug-graphics-spice-timeout+graphics-spice-timeout-nochange.xml
create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-graphics-spice-timeout+graphics-spice-timeout-password.xml
[PATCH 00/11] qemuhotplugtest: Various cleanups and improvements
Posted by Michal Privoznik 1 year, 7 months ago
While working on something else, I've taken a look at qemuhotplugtest
and realized we can do various cleanups and improvements.

The test still covers just live attach/detach/update, but after this
it's prepared better to test also config attach/detach/update.

Michal Prívozník (11):
  qemu: Replace @dom argument with @driver in
    qemuDomainUpdateDeviceLive()
  qemu: Move qemuDomainAttachDeviceLive() into qemu_hotplug.c
  qemu: Move qemuDomainUpdateDeviceLive() into qemu_hotplug.c
  qemuhotplugtest: Call qemuDomainDetachDeviceLive() directly
  qemuhotplugtest: Call qemuDomainAttachDeviceLive() directly
  qemuhotplugtest: Call qemuDomainUpdateDeviceLive() directly
  qemu_hotplug.h: Expose less functions
  qemuhotplugtest: Fix misleading comment on monitor unlock
  qemuhotplugtest: Don't overwrite vm->def->id in
    testQemuHotplugCheckResult()
  qemuhotplugtest: use g_autoptr(virDomainDeviceDef)
  qemuhotplugtest: Verify domain XML on UPDATE

 src/qemu/qemu_driver.c                        | 472 +---------------
 src/qemu/qemu_hotplug.c                       | 525 +++++++++++++++++-
 src/qemu/qemu_hotplug.h                       |  68 +--
 tests/qemuhotplugtest.c                       | 197 +------
 ...hotplug-disk-cdrom+disk-cdrom-nochange.xml |   1 +
 .../qemuhotplug-disk-cdrom.xml                |  30 +-
 ...graphics-spice+graphics-spice-nochange.xml |   1 +
 ...graphics-spice-listen-network-password.xml |  71 +++
 ...imeout+graphics-spice-timeout-nochange.xml |   1 +
 ...imeout+graphics-spice-timeout-password.xml | 117 ++++
 .../qemuhotplug-graphics-spice-timeout.xml    |  50 +-
 .../qemuhotplug-graphics-spice.xml            |  41 +-
 12 files changed, 819 insertions(+), 755 deletions(-)
 create mode 120000 tests/qemuhotplugtestdomains/qemuhotplug-disk-cdrom+disk-cdrom-nochange.xml
 create mode 120000 tests/qemuhotplugtestdomains/qemuhotplug-graphics-spice+graphics-spice-nochange.xml
 create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-graphics-spice-listen-network+graphics-spice-listen-network-password.xml
 create mode 120000 tests/qemuhotplugtestdomains/qemuhotplug-graphics-spice-timeout+graphics-spice-timeout-nochange.xml
 create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-graphics-spice-timeout+graphics-spice-timeout-password.xml

-- 
2.39.2