[PATCH 0/7] Various watchdog fixes

Martin Kletzander posted 7 patches 1 year, 7 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1681913144.git.mkletzan@redhat.com
src/conf/domain_conf.c                        |  2 +
src/qemu/qemu_driver.c                        | 13 +++++
src/qemu/qemu_hotplug.c                       |  2 +-
src/qemu/qemu_validate.c                      | 51 +++++++++++--------
tests/qemuhotplugtest.c                       |  3 ++
.../qemuhotplug-watchdog-reset.xml            |  1 +
...plug-base-live+watchdog+watchdog-reset.xml |  1 +
.../watchdog-q35-multiple.x86_64-latest.args  |  4 +-
.../watchdog-q35-multiple.xml                 |  2 +-
.../watchdog-q35-multiple.x86_64-latest.xml   |  4 +-
10 files changed, 58 insertions(+), 25 deletions(-)
create mode 100644 tests/qemuhotplugtestdevices/qemuhotplug-watchdog-reset.xml
create mode 120000 tests/qemuhotplugtestdomains/qemuhotplug-base-live+watchdog+watchdog-reset.xml
[PATCH 0/7] Various watchdog fixes
Posted by Martin Kletzander 1 year, 7 months ago
Los blurbos aqui.

Martin Kletzander (7):
  conf: Add missing empty lines before virDomainWatchdogDefParseXML
  qemu: Fix grammar and quoting in watchdog error message on hotplug
  qemu: Forbid device attach of existing platform watchdog
  qemu: Forbid ib700 watchdogs for non-i440fx machine types
  qemu: Check all watchdogs for iTCO duplicates
  qemu: Validate watchdog action compatibility per-device
  qemu: Forbid most duplicated watchdogs

 src/conf/domain_conf.c                        |  2 +
 src/qemu/qemu_driver.c                        | 13 +++++
 src/qemu/qemu_hotplug.c                       |  2 +-
 src/qemu/qemu_validate.c                      | 51 +++++++++++--------
 tests/qemuhotplugtest.c                       |  3 ++
 .../qemuhotplug-watchdog-reset.xml            |  1 +
 ...plug-base-live+watchdog+watchdog-reset.xml |  1 +
 .../watchdog-q35-multiple.x86_64-latest.args  |  4 +-
 .../watchdog-q35-multiple.xml                 |  2 +-
 .../watchdog-q35-multiple.x86_64-latest.xml   |  4 +-
 10 files changed, 58 insertions(+), 25 deletions(-)
 create mode 100644 tests/qemuhotplugtestdevices/qemuhotplug-watchdog-reset.xml
 create mode 120000 tests/qemuhotplugtestdomains/qemuhotplug-base-live+watchdog+watchdog-reset.xml

-- 
2.40.0
Re: [PATCH 0/7] Various watchdog fixes
Posted by Michal Prívozník 1 year, 7 months ago
On 4/19/23 16:07, Martin Kletzander wrote:
> Los blurbos aqui.
> 
> Martin Kletzander (7):
>   conf: Add missing empty lines before virDomainWatchdogDefParseXML
>   qemu: Fix grammar and quoting in watchdog error message on hotplug
>   qemu: Forbid device attach of existing platform watchdog
>   qemu: Forbid ib700 watchdogs for non-i440fx machine types
>   qemu: Check all watchdogs for iTCO duplicates
>   qemu: Validate watchdog action compatibility per-device
>   qemu: Forbid most duplicated watchdogs
> 
>  src/conf/domain_conf.c                        |  2 +
>  src/qemu/qemu_driver.c                        | 13 +++++
>  src/qemu/qemu_hotplug.c                       |  2 +-
>  src/qemu/qemu_validate.c                      | 51 +++++++++++--------
>  tests/qemuhotplugtest.c                       |  3 ++
>  .../qemuhotplug-watchdog-reset.xml            |  1 +
>  ...plug-base-live+watchdog+watchdog-reset.xml |  1 +
>  .../watchdog-q35-multiple.x86_64-latest.args  |  4 +-
>  .../watchdog-q35-multiple.xml                 |  2 +-
>  .../watchdog-q35-multiple.x86_64-latest.xml   |  4 +-
>  10 files changed, 58 insertions(+), 25 deletions(-)
>  create mode 100644 tests/qemuhotplugtestdevices/qemuhotplug-watchdog-reset.xml
>  create mode 120000 tests/qemuhotplugtestdomains/qemuhotplug-base-live+watchdog+watchdog-reset.xml
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal