[PATCH 5/6] docs: downloads: Drop link to sources of 'consoleproxy'

Peter Krempa posted 6 patches 2 years, 9 months ago
There is a newer version of this series
[PATCH 5/6] docs: downloads: Drop link to sources of 'consoleproxy'
Posted by Peter Krempa 2 years, 9 months ago
The directory doesn't exist. The project also doesn't have any releases
on gitlab so there's nothing to replace it with.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 docs/downloads.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/downloads.rst b/docs/downloads.rst
index bf64b45715..ed280e18c6 100644
--- a/docs/downloads.rst
+++ b/docs/downloads.rst
@@ -145,7 +145,7 @@ Integration modules
     -

   * - Console Proxy
-    - `libvirt <https://download.libvirt.org/consoleproxy/>`__
+    -
     - `gitlab <https://gitlab.com/libvirt/libvirt-console-proxy>`__
     - `issues <https://gitlab.com/libvirt/libvirt-console-proxy/-/issues>`__
     - `github <https://github.com/libvirt/libvirt-console-proxy>`__
-- 
2.39.2
Re: [PATCH 5/6] docs: downloads: Drop link to sources of 'consoleproxy'
Posted by Andrea Bolognani 2 years, 9 months ago
On Tue, Mar 14, 2023 at 10:36:57AM +0100, Peter Krempa wrote:
> The directory doesn't exist. The project also doesn't have any releases
> on gitlab so there's nothing to replace it with.
>
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  docs/downloads.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

libvirt-csharp is in a similar situation, with the only difference
being that we actually have a (completely empty) directory for it on
libvirt.org. I would say that we should deal with that project the
same way as this one.

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization
Re: [PATCH 5/6] docs: downloads: Drop link to sources of 'consoleproxy'
Posted by Peter Krempa 2 years, 9 months ago
On Tue, Mar 14, 2023 at 06:15:39 -0400, Andrea Bolognani wrote:
> On Tue, Mar 14, 2023 at 10:36:57AM +0100, Peter Krempa wrote:
> > The directory doesn't exist. The project also doesn't have any releases
> > on gitlab so there's nothing to replace it with.
> >
> > Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> > ---
> >  docs/downloads.rst | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> libvirt-csharp is in a similar situation, with the only difference
> being that we actually have a (completely empty) directory for it on
> libvirt.org. I would say that we should deal with that project the
> same way as this one.

I thought about that too. Here it was very clear as this link is a 404.