[v1] Use 'download.libvirt.org' on our webpage

[PATCH 6/6] docs: downloads: Point to gitlab for go module sources

Posted by Peter Krempa 2 years, 9 months ago

Currently the 'Releases' column pointed to the generic page about the
specific go module. Change the link to point to the gitlab tags page.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 docs/downloads.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/downloads.rst b/docs/downloads.rst
index ed280e18c6..605a8025e0 100644
--- a/docs/downloads.rst
+++ b/docs/downloads.rst
@@ -52,7 +52,7 @@ Language bindings
     -

   * - Go
-    - `libvirt <https://libvirt.org/go/libvirt>`__
+    - `gitlab <https://gitlab.com/libvirt/libvirt-go-module/-/tags>`__
     - `gitlab <https://gitlab.com/libvirt/libvirt-go-module>`__
     - `issues <https://gitlab.com/libvirt/libvirt-go-module/-/issues>`__
     - `github <https://github.com/libvirt/libvirt-go-module>`__
@@ -131,7 +131,7 @@ Integration modules
     -

   * - Go XML
-    - `libvirt <https://libvirt.org/go/libvirtxml>`__
+    - `gitlab <https://gitlab.com/libvirt/libvirt-go-xml-module/-/tags>`__
     - `gitlab <https://gitlab.com/libvirt/libvirt-go-xml-module>`__
     - `issues <https://gitlab.com/libvirt/libvirt-go-xml-module/-/issues>`__
     - `github <https://github.com/libvirt/libvirt-go-xml-module>`__
-- 
2.39.2

Re: [PATCH 6/6] docs: downloads: Point to gitlab for go module sources

Posted by Andrea Bolognani 2 years, 9 months ago

On Tue, Mar 14, 2023 at 10:36:58AM +0100, Peter Krempa wrote:
>    * - Go
> -    - `libvirt <https://libvirt.org/go/libvirt>`__
> +    - `gitlab <https://gitlab.com/libvirt/libvirt-go-module/-/tags>`__
>      - `gitlab <https://gitlab.com/libvirt/libvirt-go-module>`__
>      - `issues <https://gitlab.com/libvirt/libvirt-go-module/-/issues>`__
>      - `github <https://github.com/libvirt/libvirt-go-module>`__
> @@ -131,7 +131,7 @@ Integration modules
>      -
>
>    * - Go XML
> -    - `libvirt <https://libvirt.org/go/libvirtxml>`__
> +    - `gitlab <https://gitlab.com/libvirt/libvirt-go-xml-module/-/tags>`__
>      - `gitlab <https://gitlab.com/libvirt/libvirt-go-xml-module>`__
>      - `issues <https://gitlab.com/libvirt/libvirt-go-xml-module/-/issues>`__
>      - `github <https://github.com/libvirt/libvirt-go-xml-module>`__

For these two, I think linking to

  https://pkg.go.dev/libvirt.org/go/libvirt
  https://pkg.go.dev/libvirt.org/go/libvirtxml

similarly to how we point to the language-specific package repository
for Python, Perl and Rust might make more sense.

On the other hand, in the case of Go we don't explicitly publish
releases to a different system, they get picked up automatically from
the git tags...

Dan?

-- 
Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH 6/6] docs: downloads: Point to gitlab for go module sources

Posted by Daniel P. Berrangé 2 years, 9 months ago

On Tue, Mar 14, 2023 at 06:20:48AM -0400, Andrea Bolognani wrote:
> On Tue, Mar 14, 2023 at 10:36:58AM +0100, Peter Krempa wrote:
> >    * - Go
> > -    - `libvirt <https://libvirt.org/go/libvirt>`__
> > +    - `gitlab <https://gitlab.com/libvirt/libvirt-go-module/-/tags>`__
> >      - `gitlab <https://gitlab.com/libvirt/libvirt-go-module>`__
> >      - `issues <https://gitlab.com/libvirt/libvirt-go-module/-/issues>`__
> >      - `github <https://github.com/libvirt/libvirt-go-module>`__
> > @@ -131,7 +131,7 @@ Integration modules
> >      -
> >
> >    * - Go XML
> > -    - `libvirt <https://libvirt.org/go/libvirtxml>`__
> > +    - `gitlab <https://gitlab.com/libvirt/libvirt-go-xml-module/-/tags>`__
> >      - `gitlab <https://gitlab.com/libvirt/libvirt-go-xml-module>`__
> >      - `issues <https://gitlab.com/libvirt/libvirt-go-xml-module/-/issues>`__
> >      - `github <https://github.com/libvirt/libvirt-go-xml-module>`__
> 
> For these two, I think linking to
> 
>   https://pkg.go.dev/libvirt.org/go/libvirt
>   https://pkg.go.dev/libvirt.org/go/libvirtxml
> 
> similarly to how we point to the language-specific package repository
> for Python, Perl and Rust might make more sense.
> 
> On the other hand, in the case of Go we don't explicitly publish
> releases to a different system, they get picked up automatically from
> the git tags...

Maybe better to use the versions page

  https://pkg.go.dev/libvirt.org/go/libvirt?tab=versions


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH 6/6] docs: downloads: Point to gitlab for go module sources

Posted by Andrea Bolognani 2 years, 9 months ago

On Tue, Mar 14, 2023 at 10:23:15AM +0000, Daniel P. Berrangé wrote:
> On Tue, Mar 14, 2023 at 06:20:48AM -0400, Andrea Bolognani wrote:
> > On Tue, Mar 14, 2023 at 10:36:58AM +0100, Peter Krempa wrote:
> > >    * - Go
> > > -    - `libvirt <https://libvirt.org/go/libvirt>`__
> > > +    - `gitlab <https://gitlab.com/libvirt/libvirt-go-module/-/tags>`__
> > >      - `gitlab <https://gitlab.com/libvirt/libvirt-go-module>`__
> > >      - `issues <https://gitlab.com/libvirt/libvirt-go-module/-/issues>`__
> > >      - `github <https://github.com/libvirt/libvirt-go-module>`__
> > > @@ -131,7 +131,7 @@ Integration modules
> > >      -
> > >
> > >    * - Go XML
> > > -    - `libvirt <https://libvirt.org/go/libvirtxml>`__
> > > +    - `gitlab <https://gitlab.com/libvirt/libvirt-go-xml-module/-/tags>`__
> > >      - `gitlab <https://gitlab.com/libvirt/libvirt-go-xml-module>`__
> > >      - `issues <https://gitlab.com/libvirt/libvirt-go-xml-module/-/issues>`__
> > >      - `github <https://github.com/libvirt/libvirt-go-xml-module>`__
> >
> > For these two, I think linking to
> >
> >   https://pkg.go.dev/libvirt.org/go/libvirt
> >   https://pkg.go.dev/libvirt.org/go/libvirtxml
> >
> > similarly to how we point to the language-specific package repository
> > for Python, Perl and Rust might make more sense.
> >
> > On the other hand, in the case of Go we don't explicitly publish
> > releases to a different system, they get picked up automatically from
> > the git tags...
>
> Maybe better to use the versions page
>
>   https://pkg.go.dev/libvirt.org/go/libvirt?tab=versions

Yeah, that could work too and would be a fitting counterpart for the
directory listing that we present for projects where releases are
stored on libvirt.org.

On the other hand, for Python and Rust we point to the main package
page instead of the version history subpage, which looks a bit better
as a landing page. Perl doesn't seem to have a separate page for
version history - it's all integrated in the small drop-down in the
landing page.

All in all, while both would be reasonable choices I have a slight
preference for pointing to the landing page.

-- 
Andrea Bolognani / Red Hat / Virtualization

[PATCH 1/6] docs: java: Clean up links to source code
[PATCH 2/6] docs: downloads: Replace 'libvirt.org/sources' by 'download.libvirt.org'
[PATCH 3/6] spec: Use 'download.libvirt.org' as source server
[PATCH 4/6] docs: downloads: Change sources link for libvirt-ocaml
[PATCH 5/6] docs: downloads: Drop link to sources of 'consoleproxy'
[PATCH 6/6] docs: downloads: Point to gitlab for go module sources