[libvirt PATCH 0/6] do not report errors in virPidFileForceCleanupPathFull

Ján Tomko posted 6 patches 1 year, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1678205730.git.jtomko@redhat.com
src/bhyve/bhyve_driver.c                |  2 +-
src/interface/interface_backend_netcf.c |  2 +-
src/interface/interface_backend_udev.c  |  2 +-
src/libvirt_private.syms                |  1 +
src/libxl/libxl_driver.c                |  2 +-
src/locking/lock_daemon.c               |  4 +-
src/logging/log_daemon.c                |  4 +-
src/lxc/lxc_driver.c                    |  2 +-
src/network/bridge_driver.c             |  3 +-
src/network/leaseshelper.c              |  2 +-
src/node_device/node_device_udev.c      |  2 +-
src/nwfilter/nwfilter_driver.c          |  2 +-
src/qemu/qemu_driver.c                  |  2 +-
src/remote/remote_daemon.c              |  2 +-
src/secret/secret_driver.c              |  2 +-
src/storage/storage_driver.c            |  3 +-
src/util/vircommand.c                   |  2 +-
src/util/virpidfile.c                   | 69 +++++++++++++++----------
src/util/virpidfile.h                   |  6 ++-
src/vz/vz_driver.c                      |  2 +-
20 files changed, 67 insertions(+), 49 deletions(-)
[libvirt PATCH 0/6] do not report errors in virPidFileForceCleanupPathFull
Posted by Ján Tomko 1 year, 1 month ago
https://bugzilla.redhat.com/show_bug.cgi?id=2171973

Ján Tomko (6):
  util: remove waitForLock from virPidFileAcquire
  util: introduce virPidFileAcquirePathFull
  leaseshelper: use virPidFileAcquirePathFull
  util: virPidFileAcquirePath: remove waitForLock argument
  util: add quiet parameter to virPidFileAcquirePathFull
  util: do not report errors in virPidFileForceCleanupPathFull

 src/bhyve/bhyve_driver.c                |  2 +-
 src/interface/interface_backend_netcf.c |  2 +-
 src/interface/interface_backend_udev.c  |  2 +-
 src/libvirt_private.syms                |  1 +
 src/libxl/libxl_driver.c                |  2 +-
 src/locking/lock_daemon.c               |  4 +-
 src/logging/log_daemon.c                |  4 +-
 src/lxc/lxc_driver.c                    |  2 +-
 src/network/bridge_driver.c             |  3 +-
 src/network/leaseshelper.c              |  2 +-
 src/node_device/node_device_udev.c      |  2 +-
 src/nwfilter/nwfilter_driver.c          |  2 +-
 src/qemu/qemu_driver.c                  |  2 +-
 src/remote/remote_daemon.c              |  2 +-
 src/secret/secret_driver.c              |  2 +-
 src/storage/storage_driver.c            |  3 +-
 src/util/vircommand.c                   |  2 +-
 src/util/virpidfile.c                   | 69 +++++++++++++++----------
 src/util/virpidfile.h                   |  6 ++-
 src/vz/vz_driver.c                      |  2 +-
 20 files changed, 67 insertions(+), 49 deletions(-)

-- 
2.39.2

Re: [libvirt PATCH 0/6] do not report errors in virPidFileForceCleanupPathFull
Posted by Martin Kletzander 1 year, 1 month ago
On Tue, Mar 07, 2023 at 05:15:56PM +0100, Ján Tomko wrote:
>https://bugzilla.redhat.com/show_bug.cgi?id=2171973
>
>Ján Tomko (6):
>  util: remove waitForLock from virPidFileAcquire
>  util: introduce virPidFileAcquirePathFull
>  leaseshelper: use virPidFileAcquirePathFull
>  util: virPidFileAcquirePath: remove waitForLock argument
>  util: add quiet parameter to virPidFileAcquirePathFull
>  util: do not report errors in virPidFileForceCleanupPathFull
>

<usualRantAboutNamingThings/>

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

> src/bhyve/bhyve_driver.c                |  2 +-
> src/interface/interface_backend_netcf.c |  2 +-
> src/interface/interface_backend_udev.c  |  2 +-
> src/libvirt_private.syms                |  1 +
> src/libxl/libxl_driver.c                |  2 +-
> src/locking/lock_daemon.c               |  4 +-
> src/logging/log_daemon.c                |  4 +-
> src/lxc/lxc_driver.c                    |  2 +-
> src/network/bridge_driver.c             |  3 +-
> src/network/leaseshelper.c              |  2 +-
> src/node_device/node_device_udev.c      |  2 +-
> src/nwfilter/nwfilter_driver.c          |  2 +-
> src/qemu/qemu_driver.c                  |  2 +-
> src/remote/remote_daemon.c              |  2 +-
> src/secret/secret_driver.c              |  2 +-
> src/storage/storage_driver.c            |  3 +-
> src/util/vircommand.c                   |  2 +-
> src/util/virpidfile.c                   | 69 +++++++++++++++----------
> src/util/virpidfile.h                   |  6 ++-
> src/vz/vz_driver.c                      |  2 +-
> 20 files changed, 67 insertions(+), 49 deletions(-)
>
>-- 
>2.39.2
>