[PATCH 00/15] qemu: Fix HPET timer validation and remove always-present architecture dependent capabilities

Peter Krempa posted 15 patches 1 year, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1678135546.git.pkrempa@redhat.com
NEWS.rst                                      |  6 ++
src/qemu/qemu_capabilities.c                  | 93 ++---------------
src/qemu/qemu_capabilities.h                  | 12 +--
src/qemu/qemu_capspriv.h                      |  3 -
src/qemu/qemu_command.c                       | 72 +++++++-------
src/qemu/qemu_validate.c                      | 14 +--
.../caps_4.2.0.aarch64.xml                    |  2 -
.../qemucapabilitiesdata/caps_4.2.0.s390x.xml |  3 -
.../caps_4.2.0.x86_64.xml                     |  2 -
.../caps_5.0.0.aarch64.xml                    |  2 -
.../caps_5.0.0.x86_64.xml                     |  2 -
.../caps_5.1.0.x86_64.xml                     |  2 -
.../caps_5.2.0.aarch64.xml                    |  2 -
.../qemucapabilitiesdata/caps_5.2.0.s390x.xml |  3 -
.../caps_5.2.0.x86_64.xml                     |  2 -
.../caps_6.0.0.aarch64.xml                    |  2 -
.../qemucapabilitiesdata/caps_6.0.0.s390x.xml |  3 -
.../caps_6.0.0.x86_64.xml                     |  2 -
.../caps_6.1.0.x86_64.xml                     |  2 -
.../caps_6.2.0.aarch64.xml                    |  2 -
.../caps_6.2.0.x86_64.xml                     |  2 -
.../caps_7.0.0.aarch64.xml                    |  2 -
.../caps_7.0.0.x86_64.xml                     |  2 -
.../caps_7.1.0.x86_64.xml                     |  2 -
.../caps_7.2.0.x86_64.xml                     |  2 -
.../caps_8.0.0.x86_64.xml                     |  1 -
tests/qemuhotplugtest.c                       |  2 -
.../q35-virt-manager-basic.x86_64-4.2.0.args  |  1 -
.../q35-virt-manager-basic.x86_64-latest.args |  2 +-
.../q35-virt-manager-basic.xml                |  2 +-
tests/qemuxml2argvtest.c                      | 99 ++++++-------------
.../q35-virt-manager-basic.x86_64-latest.xml  |  2 +-
tests/qemuxml2xmltest.c                       |  3 -
33 files changed, 93 insertions(+), 260 deletions(-)
[PATCH 00/15] qemu: Fix HPET timer validation and remove always-present architecture dependent capabilities
Posted by Peter Krempa 1 year, 1 month ago
Remove everything out of virQEMUCapsInitQMPBasicArch and in the process
fix a bug.

Peter Krempa (15):
  qemu: validate: Fix logic for validating precence of the HPET timer
  NEWS: Mention bug in validation of HPET timer
  qemu: command: Replace check using QEMU_CAPS_NO_ACPI with architecture
    check
  qemu: capabilities: Retire QEMU_CAPS_NO_ACPI
  qemu: command: Format '-no-hpet' based on architecture check
  qemu: capabilities: Retire QEMU_CAPS_NO_HPET
  qemuxml2argvtest: Don't set QEMU_CAPS_MACH_VIRT_GIC_VERSION
  qemu: command: Replace caps check for QEMU_CAPS_MACH_VIRT_GIC_VERSION
    by arch check
  qemu: capabilities: Retire QEMU_CAPS_MACH_VIRT_GIC_VERSION
  qemuxml2argvtest: Remove always asserted s390 capabilities
  qemuAppendKeyWrapMachineParms: Format "keywrap" arguments based on
    architecture
  qemu: capabilities: Retire QEMU_CAPS_AES_KEY_WRAP and
    QEMU_CAPS_DEA_KEY_WRAP
  qemuAppendLoadparmMachineParm: Format 'loadparm' based on architecture
  qemu: capabilities: Retire QEMU_CAPS_LOADPARM
  qemu: capabilities: Remove unused virQEMUCapsInitQMPBasicArch

 NEWS.rst                                      |  6 ++
 src/qemu/qemu_capabilities.c                  | 93 ++---------------
 src/qemu/qemu_capabilities.h                  | 12 +--
 src/qemu/qemu_capspriv.h                      |  3 -
 src/qemu/qemu_command.c                       | 72 +++++++-------
 src/qemu/qemu_validate.c                      | 14 +--
 .../caps_4.2.0.aarch64.xml                    |  2 -
 .../qemucapabilitiesdata/caps_4.2.0.s390x.xml |  3 -
 .../caps_4.2.0.x86_64.xml                     |  2 -
 .../caps_5.0.0.aarch64.xml                    |  2 -
 .../caps_5.0.0.x86_64.xml                     |  2 -
 .../caps_5.1.0.x86_64.xml                     |  2 -
 .../caps_5.2.0.aarch64.xml                    |  2 -
 .../qemucapabilitiesdata/caps_5.2.0.s390x.xml |  3 -
 .../caps_5.2.0.x86_64.xml                     |  2 -
 .../caps_6.0.0.aarch64.xml                    |  2 -
 .../qemucapabilitiesdata/caps_6.0.0.s390x.xml |  3 -
 .../caps_6.0.0.x86_64.xml                     |  2 -
 .../caps_6.1.0.x86_64.xml                     |  2 -
 .../caps_6.2.0.aarch64.xml                    |  2 -
 .../caps_6.2.0.x86_64.xml                     |  2 -
 .../caps_7.0.0.aarch64.xml                    |  2 -
 .../caps_7.0.0.x86_64.xml                     |  2 -
 .../caps_7.1.0.x86_64.xml                     |  2 -
 .../caps_7.2.0.x86_64.xml                     |  2 -
 .../caps_8.0.0.x86_64.xml                     |  1 -
 tests/qemuhotplugtest.c                       |  2 -
 .../q35-virt-manager-basic.x86_64-4.2.0.args  |  1 -
 .../q35-virt-manager-basic.x86_64-latest.args |  2 +-
 .../q35-virt-manager-basic.xml                |  2 +-
 tests/qemuxml2argvtest.c                      | 99 ++++++-------------
 .../q35-virt-manager-basic.x86_64-latest.xml  |  2 +-
 tests/qemuxml2xmltest.c                       |  3 -
 33 files changed, 93 insertions(+), 260 deletions(-)

-- 
2.39.2
Re: [PATCH 00/15] qemu: Fix HPET timer validation and remove always-present architecture dependent capabilities
Posted by Ján Tomko 1 year, 1 month ago
On a Monday in 2023, Peter Krempa wrote:
>Remove everything out of virQEMUCapsInitQMPBasicArch and in the process
>fix a bug.
>
>Peter Krempa (15):
>  qemu: validate: Fix logic for validating precence of the HPET timer
>  NEWS: Mention bug in validation of HPET timer
>  qemu: command: Replace check using QEMU_CAPS_NO_ACPI with architecture
>    check
>  qemu: capabilities: Retire QEMU_CAPS_NO_ACPI
>  qemu: command: Format '-no-hpet' based on architecture check
>  qemu: capabilities: Retire QEMU_CAPS_NO_HPET
>  qemuxml2argvtest: Don't set QEMU_CAPS_MACH_VIRT_GIC_VERSION
>  qemu: command: Replace caps check for QEMU_CAPS_MACH_VIRT_GIC_VERSION
>    by arch check
>  qemu: capabilities: Retire QEMU_CAPS_MACH_VIRT_GIC_VERSION
>  qemuxml2argvtest: Remove always asserted s390 capabilities
>  qemuAppendKeyWrapMachineParms: Format "keywrap" arguments based on
>    architecture
>  qemu: capabilities: Retire QEMU_CAPS_AES_KEY_WRAP and
>    QEMU_CAPS_DEA_KEY_WRAP
>  qemuAppendLoadparmMachineParm: Format 'loadparm' based on architecture
>  qemu: capabilities: Retire QEMU_CAPS_LOADPARM
>  qemu: capabilities: Remove unused virQEMUCapsInitQMPBasicArch
>
> NEWS.rst                                      |  6 ++
> src/qemu/qemu_capabilities.c                  | 93 ++---------------
> src/qemu/qemu_capabilities.h                  | 12 +--
> src/qemu/qemu_capspriv.h                      |  3 -
> src/qemu/qemu_command.c                       | 72 +++++++-------
> src/qemu/qemu_validate.c                      | 14 +--
> .../caps_4.2.0.aarch64.xml                    |  2 -
> .../qemucapabilitiesdata/caps_4.2.0.s390x.xml |  3 -
> .../caps_4.2.0.x86_64.xml                     |  2 -
> .../caps_5.0.0.aarch64.xml                    |  2 -
> .../caps_5.0.0.x86_64.xml                     |  2 -
> .../caps_5.1.0.x86_64.xml                     |  2 -
> .../caps_5.2.0.aarch64.xml                    |  2 -
> .../qemucapabilitiesdata/caps_5.2.0.s390x.xml |  3 -
> .../caps_5.2.0.x86_64.xml                     |  2 -
> .../caps_6.0.0.aarch64.xml                    |  2 -
> .../qemucapabilitiesdata/caps_6.0.0.s390x.xml |  3 -
> .../caps_6.0.0.x86_64.xml                     |  2 -
> .../caps_6.1.0.x86_64.xml                     |  2 -
> .../caps_6.2.0.aarch64.xml                    |  2 -
> .../caps_6.2.0.x86_64.xml                     |  2 -
> .../caps_7.0.0.aarch64.xml                    |  2 -
> .../caps_7.0.0.x86_64.xml                     |  2 -
> .../caps_7.1.0.x86_64.xml                     |  2 -
> .../caps_7.2.0.x86_64.xml                     |  2 -
> .../caps_8.0.0.x86_64.xml                     |  1 -
> tests/qemuhotplugtest.c                       |  2 -
> .../q35-virt-manager-basic.x86_64-4.2.0.args  |  1 -
> .../q35-virt-manager-basic.x86_64-latest.args |  2 +-
> .../q35-virt-manager-basic.xml                |  2 +-
> tests/qemuxml2argvtest.c                      | 99 ++++++-------------
> .../q35-virt-manager-basic.x86_64-latest.xml  |  2 +-
> tests/qemuxml2xmltest.c                       |  3 -
> 33 files changed, 93 insertions(+), 260 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano