The script references a very specific line in the kernel source code and
a very specific struct. Further changes to the kernel are likely going
to break it. Set the expectations by adding a warning to the reader.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 examples/systemtap/amd-sev-es-vmsa.stp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/examples/systemtap/amd-sev-es-vmsa.stp b/examples/systemtap/amd-sev-es-vmsa.stp
index 551ed739b7..7bd079be71 100644
--- a/examples/systemtap/amd-sev-es-vmsa.stp
+++ b/examples/systemtap/amd-sev-es-vmsa.stp
@@ -19,6 +19,10 @@
 # A script that captures the VMSA blob for the boot vCPU and
 # first additional vCPU, when a KVM guest is booted with SEV-ES
 #
+# NOTE: This directly references specific structures and places in the
+#       kernel source code. It is expected that this example will need to be
+#       editted to match the kernel you intend to run it against.
+#
 # The captured VMSA will be printed to the console in hex format,
 # and can be converted to the required binary format by feeding
 # it through
-- 
2.39.2

On Mon, Mar 06, 2023 at 12:39:12PM +0100, Peter Krempa wrote:
> The script references a very specific line in the kernel source code and
> a very specific struct. Further changes to the kernel are likely going
> to break it. Set the expectations by adding a warning to the reader.
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  examples/systemtap/amd-sev-es-vmsa.stp | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/examples/systemtap/amd-sev-es-vmsa.stp b/examples/systemtap/amd-sev-es-vmsa.stp
> index 551ed739b7..7bd079be71 100644
> --- a/examples/systemtap/amd-sev-es-vmsa.stp
> +++ b/examples/systemtap/amd-sev-es-vmsa.stp
> @@ -19,6 +19,10 @@
>  # A script that captures the VMSA blob for the boot vCPU and
>  # first additional vCPU, when a KVM guest is booted with SEV-ES
>  #
> +# NOTE: This directly references specific structures and places in the
> +#       kernel source code. It is expected that this example will need to be
> +#       editted to match the kernel you intend to run it against.
> +#
>  # The captured VMSA will be printed to the console in hex format,
>  # and can be converted to the required binary format by feeding
>  # it through

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|