qemu: Let virCommand report errors

[PATCH 0/4] qemu: Let virCommand report errors

Michal Privoznik posted 4 patches 1 year, 2 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1676887078.git.mprivozn@redhat.com

src/qemu/qemu_dbus.c           | 11 +----------
src/qemu/qemu_passt.c          | 12 +-----------
src/qemu/qemu_security.c       | 13 ++++++-------
src/qemu/qemu_security.h       |  3 +--
src/qemu/qemu_slirp.c          | 12 +-----------
src/qemu/qemu_tpm.c            |  9 +--------
src/qemu/qemu_vhost_user_gpu.c | 11 ++---------
7 files changed, 13 insertions(+), 58 deletions(-)

Expand all Fold all

[PATCH 0/4] qemu: Let virCommand report errors

Posted by Michal Privoznik 1 year, 2 months ago

In a lot of places we catch errors from qemuSecurityCommandRun() only to
produce an error report. But we can let virCommand module do the same.

Michal Prívozník (4):
  qemu_slirp: Don't set errfd when starting slirp helper
  qemu: Don't overwrite error from qemuSecurityCommandRun()
  qemu: Drop @cmdret argument from qemuSecurityCommandRun()
  qemu: Let virCommand module translate exitstatus

 src/qemu/qemu_dbus.c           | 11 +----------
 src/qemu/qemu_passt.c          | 12 +-----------
 src/qemu/qemu_security.c       | 13 ++++++-------
 src/qemu/qemu_security.h       |  3 +--
 src/qemu/qemu_slirp.c          | 12 +-----------
 src/qemu/qemu_tpm.c            |  9 +--------
 src/qemu/qemu_vhost_user_gpu.c | 11 ++---------
 7 files changed, 13 insertions(+), 58 deletions(-)

-- 
2.39.2

Re: [PATCH 0/4] qemu: Let virCommand report errors

Posted by Ján Tomko 1 year, 1 month ago

On a Monday in 2023, Michal Privoznik wrote:
>In a lot of places we catch errors from qemuSecurityCommandRun() only to
>produce an error report. But we can let virCommand module do the same.
>
>Michal Prívozník (4):
>  qemu_slirp: Don't set errfd when starting slirp helper
>  qemu: Don't overwrite error from qemuSecurityCommandRun()
>  qemu: Drop @cmdret argument from qemuSecurityCommandRun()
>  qemu: Let virCommand module translate exitstatus
>
> src/qemu/qemu_dbus.c           | 11 +----------
> src/qemu/qemu_passt.c          | 12 +-----------
> src/qemu/qemu_security.c       | 13 ++++++-------
> src/qemu/qemu_security.h       |  3 +--
> src/qemu/qemu_slirp.c          | 12 +-----------
> src/qemu/qemu_tpm.c            |  9 +--------
> src/qemu/qemu_vhost_user_gpu.c | 11 ++---------
> 7 files changed, 13 insertions(+), 58 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano