[PATCH 2/2] libvirt-nodedev: Allow read-only access to virNodeDeviceGetAutostart

Peter Krempa posted 2 patches 2 years, 11 months ago
[PATCH 2/2] libvirt-nodedev: Allow read-only access to virNodeDeviceGetAutostart
Posted by Peter Krempa 2 years, 11 months ago
Fetching whether a node-device is marked for autostart can be allowed
from read-only connections similarly to other objects.

Fixes: c6607a25b93
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/libvirt-nodedev.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/libvirt-nodedev.c b/src/libvirt-nodedev.c
index 1b7dee113e..366d2cfdbe 100644
--- a/src/libvirt-nodedev.c
+++ b/src/libvirt-nodedev.c
@@ -1089,7 +1089,6 @@ virNodeDeviceGetAutostart(virNodeDevicePtr dev,
     virResetLastError();

     virCheckNodeDeviceReturn(dev, -1);
-    virCheckReadOnlyGoto(dev->conn->flags, error);

     if (dev->conn->nodeDeviceDriver &&
         dev->conn->nodeDeviceDriver->nodeDeviceGetAutostart) {
-- 
2.39.1
Re: [PATCH 2/2] libvirt-nodedev: Allow read-only access to virNodeDeviceGetAutostart
Posted by Daniel P. Berrangé 2 years, 11 months ago
On Fri, Feb 17, 2023 at 04:11:11PM +0100, Peter Krempa wrote:
> Fetching whether a node-device is marked for autostart can be allowed
> from read-only connections similarly to other objects.
> 
> Fixes: c6607a25b93
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  src/libvirt-nodedev.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|