[libvirt PATCH 04/20] ci: build.sh: Drop the commentary about CI_BUILD_SCRIPT

Erik Skultety posted 20 patches 3 years ago
[libvirt PATCH 04/20] ci: build.sh: Drop the commentary about CI_BUILD_SCRIPT
Posted by Erik Skultety 3 years ago
build.sh is not the place where this should be mentioned as the
official entrypoint for this script locally is ci/helper which can
download the right image from our upstream CI registry. Since the idea
is to ultimately drop the usage of a Makefile for the local executions,
this patch doesn't provide an alternative place for the comment in
question as the functionality is going to be altered substantially in
the future.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
---
 ci/build.sh | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/ci/build.sh b/ci/build.sh
index 0f23df1fa3..3fa28eafa8 100644
--- a/ci/build.sh
+++ b/ci/build.sh
@@ -1,14 +1,5 @@
 #!/bin/sh
 
-# This script is used to build libvirt inside the container.
-#
-# You can customize it to your liking, or alternatively use a
-# completely different script by passing
-#
-#  CI_BUILD_SCRIPT=/path/to/your/build/script
-#
-# to make.
-
 cd "$CI_CONT_SRCDIR"
 
 export VIR_TEST_DEBUG=1
-- 
2.39.1
Re: [libvirt PATCH 04/20] ci: build.sh: Drop the commentary about CI_BUILD_SCRIPT
Posted by Daniel P. Berrangé 2 years, 11 months ago
On Mon, Feb 06, 2023 at 02:53:01PM +0100, Erik Skultety wrote:
> build.sh is not the place where this should be mentioned as the
> official entrypoint for this script locally is ci/helper which can
> download the right image from our upstream CI registry. Since the idea
> is to ultimately drop the usage of a Makefile for the local executions,
> this patch doesn't provide an alternative place for the comment in
> question as the functionality is going to be altered substantially in
> the future.
> 
> Signed-off-by: Erik Skultety <eskultet@redhat.com>
> ---
>  ci/build.sh | 9 ---------
>  1 file changed, 9 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|