[PATCH 0/5] Various cleanups to decrease amount of stack allocated buffers

Peter Krempa posted 5 patches 1 year, 7 months ago
Failed in applying to current master (apply log)
meson.build                         |   2 +-
src/lxc/lxc_process.c               | 100 ++++++++++++++++------------
src/remote/remote_daemon_dispatch.c |  17 +++--
src/util/virnetdev.c                |   2 +-
4 files changed, 66 insertions(+), 55 deletions(-)
[PATCH 0/5] Various cleanups to decrease amount of stack allocated buffers
Posted by Peter Krempa 1 year, 7 months ago
The common theme is the attempt to decrease the use of stack allocated
buffers. In few cases it's coupled with outher cleanups too.

Most patches are standalone and can be individually applied. The last
patch is also optional but can be applied only if the fixes before that
are applied too.

Peter Krempa (5):
  lxc: virLXCProcessReadLogOutput: Automatically close FD
  lxc: process: Rework reading errors from the log file
  util: netdev: Dynamically allocate 'struct nlattr' in
    virNetDevSwitchdevFeature
  remote: dispatch: Allocate 'virDomainDef' in ACL helpers dynamically
  build: Decrease maximum stack frame size to 2048

 meson.build                         |   2 +-
 src/lxc/lxc_process.c               | 100 ++++++++++++++++------------
 src/remote/remote_daemon_dispatch.c |  17 +++--
 src/util/virnetdev.c                |   2 +-
 4 files changed, 66 insertions(+), 55 deletions(-)

-- 
2.37.1
Re: [PATCH 0/5] Various cleanups to decrease amount of stack allocated buffers
Posted by Ján Tomko 1 year, 7 months ago
On a Thursday in 2022, Peter Krempa wrote:
>The common theme is the attempt to decrease the use of stack allocated
>buffers. In few cases it's coupled with outher cleanups too.
>
>Most patches are standalone and can be individually applied. The last
>patch is also optional but can be applied only if the fixes before that
>are applied too.
>
>Peter Krempa (5):
>  lxc: virLXCProcessReadLogOutput: Automatically close FD
>  lxc: process: Rework reading errors from the log file
>  util: netdev: Dynamically allocate 'struct nlattr' in
>    virNetDevSwitchdevFeature
>  remote: dispatch: Allocate 'virDomainDef' in ACL helpers dynamically
>  build: Decrease maximum stack frame size to 2048
>
> meson.build                         |   2 +-
> src/lxc/lxc_process.c               | 100 ++++++++++++++++------------
> src/remote/remote_daemon_dispatch.c |  17 +++--
> src/util/virnetdev.c                |   2 +-
> 4 files changed, 66 insertions(+), 55 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano