[PATCH 0/8] qemu: Fix regression with non-shared storage migration and clean out more dead code

Peter Krempa posted 8 patches 1 year, 7 months ago
Failed in applying to current master (apply log)
NEWS.rst                                      |  6 ++
src/qemu/qemu_capabilities.c                  |  3 +-
src/qemu/qemu_capabilities.h                  |  2 +-
src/qemu/qemu_migration.c                     | 78 ++++++++-----------
src/qemu/qemu_monitor.h                       |  5 +-
src/qemu/qemu_monitor_json.c                  |  7 +-
.../caps_4.2.0.aarch64.xml                    |  1 -
.../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |  1 -
.../qemucapabilitiesdata/caps_4.2.0.s390x.xml |  1 -
.../caps_4.2.0.x86_64.xml                     |  1 -
.../caps_5.0.0.aarch64.xml                    |  1 -
.../qemucapabilitiesdata/caps_5.0.0.ppc64.xml |  1 -
.../caps_5.0.0.riscv64.xml                    |  1 -
.../caps_5.0.0.x86_64.xml                     |  1 -
.../qemucapabilitiesdata/caps_5.1.0.sparc.xml |  1 -
.../caps_5.1.0.x86_64.xml                     |  1 -
.../caps_5.2.0.aarch64.xml                    |  1 -
.../qemucapabilitiesdata/caps_5.2.0.ppc64.xml |  1 -
.../caps_5.2.0.riscv64.xml                    |  1 -
.../qemucapabilitiesdata/caps_5.2.0.s390x.xml |  1 -
.../caps_5.2.0.x86_64.xml                     |  1 -
.../caps_6.0.0.aarch64.xml                    |  1 -
.../qemucapabilitiesdata/caps_6.0.0.s390x.xml |  1 -
.../caps_6.0.0.x86_64.xml                     |  1 -
.../caps_6.1.0.x86_64.xml                     |  1 -
.../caps_6.2.0.aarch64.xml                    |  1 -
.../qemucapabilitiesdata/caps_6.2.0.ppc64.xml |  1 -
.../caps_6.2.0.x86_64.xml                     |  1 -
.../caps_7.0.0.aarch64.xml                    |  1 -
.../qemucapabilitiesdata/caps_7.0.0.ppc64.xml |  1 -
.../caps_7.0.0.x86_64.xml                     |  1 -
.../caps_7.1.0.x86_64.xml                     |  1 -
tests/qemumonitorjsontest.c                   |  4 +-
33 files changed, 42 insertions(+), 89 deletions(-)
[PATCH 0/8] qemu: Fix regression with non-shared storage migration and clean out more dead code
Posted by Peter Krempa 1 year, 7 months ago
Patch 1 fixes regression caused by improper refactor from the
pre-blockdev removal series. The rest are cleanups noticed while
investigating the code.

Peter Krempa (8):
  qemu: migration: Fix setup of non-shared storage migration in
    qemuMigrationSrcBeginPhase
  NEWS: Mention that non-shared storage migration was broken in
    libvirt-8.7
  qemu: migration: Always assume support for QEMU_CAPS_NBD_SERVER
  qemu: capabilities: Retire QEMU_CAPS_NBD_SERVER
  qemu: migration: Don't attempt to fall back to old-style storage
    migration
  qemu: monitor: Drop support for old-style non-shared storage migration
  qemu: migration: Remove QEMU_MONITOR_MIGRATE_BACKGROUND
  qemu: monitor: Renumber QEMU_MONITOR_MIGRATE_RESUME

 NEWS.rst                                      |  6 ++
 src/qemu/qemu_capabilities.c                  |  3 +-
 src/qemu/qemu_capabilities.h                  |  2 +-
 src/qemu/qemu_migration.c                     | 78 ++++++++-----------
 src/qemu/qemu_monitor.h                       |  5 +-
 src/qemu/qemu_monitor_json.c                  |  7 +-
 .../caps_4.2.0.aarch64.xml                    |  1 -
 .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |  1 -
 .../qemucapabilitiesdata/caps_4.2.0.s390x.xml |  1 -
 .../caps_4.2.0.x86_64.xml                     |  1 -
 .../caps_5.0.0.aarch64.xml                    |  1 -
 .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml |  1 -
 .../caps_5.0.0.riscv64.xml                    |  1 -
 .../caps_5.0.0.x86_64.xml                     |  1 -
 .../qemucapabilitiesdata/caps_5.1.0.sparc.xml |  1 -
 .../caps_5.1.0.x86_64.xml                     |  1 -
 .../caps_5.2.0.aarch64.xml                    |  1 -
 .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml |  1 -
 .../caps_5.2.0.riscv64.xml                    |  1 -
 .../qemucapabilitiesdata/caps_5.2.0.s390x.xml |  1 -
 .../caps_5.2.0.x86_64.xml                     |  1 -
 .../caps_6.0.0.aarch64.xml                    |  1 -
 .../qemucapabilitiesdata/caps_6.0.0.s390x.xml |  1 -
 .../caps_6.0.0.x86_64.xml                     |  1 -
 .../caps_6.1.0.x86_64.xml                     |  1 -
 .../caps_6.2.0.aarch64.xml                    |  1 -
 .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml |  1 -
 .../caps_6.2.0.x86_64.xml                     |  1 -
 .../caps_7.0.0.aarch64.xml                    |  1 -
 .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml |  1 -
 .../caps_7.0.0.x86_64.xml                     |  1 -
 .../caps_7.1.0.x86_64.xml                     |  1 -
 tests/qemumonitorjsontest.c                   |  4 +-
 33 files changed, 42 insertions(+), 89 deletions(-)

-- 
2.37.1
Re: [PATCH 0/8] qemu: Fix regression with non-shared storage migration and clean out more dead code
Posted by Ján Tomko 1 year, 7 months ago
On a Thursday in 2022, Peter Krempa wrote:
>Patch 1 fixes regression caused by improper refactor from the
>pre-blockdev removal series. The rest are cleanups noticed while
>investigating the code.
>
>Peter Krempa (8):
>  qemu: migration: Fix setup of non-shared storage migration in
>    qemuMigrationSrcBeginPhase
>  NEWS: Mention that non-shared storage migration was broken in
>    libvirt-8.7
>  qemu: migration: Always assume support for QEMU_CAPS_NBD_SERVER
>  qemu: capabilities: Retire QEMU_CAPS_NBD_SERVER
>  qemu: migration: Don't attempt to fall back to old-style storage
>    migration
>  qemu: monitor: Drop support for old-style non-shared storage migration
>  qemu: migration: Remove QEMU_MONITOR_MIGRATE_BACKGROUND
>  qemu: monitor: Renumber QEMU_MONITOR_MIGRATE_RESUME
>
> NEWS.rst                                      |  6 ++
> src/qemu/qemu_capabilities.c                  |  3 +-
> src/qemu/qemu_capabilities.h                  |  2 +-
> src/qemu/qemu_migration.c                     | 78 ++++++++-----------
> src/qemu/qemu_monitor.h                       |  5 +-
> src/qemu/qemu_monitor_json.c                  |  7 +-
> .../caps_4.2.0.aarch64.xml                    |  1 -
> .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |  1 -
> .../qemucapabilitiesdata/caps_4.2.0.s390x.xml |  1 -
> .../caps_4.2.0.x86_64.xml                     |  1 -
> .../caps_5.0.0.aarch64.xml                    |  1 -
> .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml |  1 -
> .../caps_5.0.0.riscv64.xml                    |  1 -
> .../caps_5.0.0.x86_64.xml                     |  1 -
> .../qemucapabilitiesdata/caps_5.1.0.sparc.xml |  1 -
> .../caps_5.1.0.x86_64.xml                     |  1 -
> .../caps_5.2.0.aarch64.xml                    |  1 -
> .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml |  1 -
> .../caps_5.2.0.riscv64.xml                    |  1 -
> .../qemucapabilitiesdata/caps_5.2.0.s390x.xml |  1 -
> .../caps_5.2.0.x86_64.xml                     |  1 -
> .../caps_6.0.0.aarch64.xml                    |  1 -
> .../qemucapabilitiesdata/caps_6.0.0.s390x.xml |  1 -
> .../caps_6.0.0.x86_64.xml                     |  1 -
> .../caps_6.1.0.x86_64.xml                     |  1 -
> .../caps_6.2.0.aarch64.xml                    |  1 -
> .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml |  1 -
> .../caps_6.2.0.x86_64.xml                     |  1 -
> .../caps_7.0.0.aarch64.xml                    |  1 -
> .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml |  1 -
> .../caps_7.0.0.x86_64.xml                     |  1 -
> .../caps_7.1.0.x86_64.xml                     |  1 -
> tests/qemumonitorjsontest.c                   |  4 +-
> 33 files changed, 42 insertions(+), 89 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano