[PATCH v2 00/17] jobs: finish generalization

Kristina Hanicova posted 17 patches 1 year, 7 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1662385930.git.khanicov@redhat.com
docs/kbase/internals/qemu-threads.rst         |  34 +-
po/POTFILES                                   |   1 +
src/bhyve/bhyve_domain.c                      |   2 +-
src/ch/ch_conf.c                              |   2 +-
src/ch/ch_domain.c                            |  76 --
src/ch/ch_domain.h                            |  11 +-
src/ch/ch_driver.c                            |  40 +-
src/conf/domain_conf.c                        |  14 +-
src/conf/domain_conf.h                        |  16 +-
src/conf/meson.build                          |   1 +
src/conf/virconftypes.h                       |   2 +
src/conf/virdomainjob.c                       | 665 ++++++++++++++++++
.../domain_job.h => conf/virdomainjob.h}      |  37 +-
src/hyperv/hyperv_driver.c                    |   2 +-
src/hypervisor/domain_job.c                   | 249 -------
src/hypervisor/meson.build                    |   1 -
src/libvirt_private.syms                      |  52 +-
src/libxl/libxl_conf.c                        |   2 +-
src/libxl/libxl_domain.c                      | 113 +--
src/libxl/libxl_domain.h                      |  18 +-
src/libxl/libxl_driver.c                      | 123 ++--
src/libxl/libxl_migration.c                   |  20 +-
src/lxc/lxc_conf.c                            |   2 +-
src/lxc/lxc_domain.c                          |  86 ---
src/lxc/lxc_domain.h                          |  14 +-
src/lxc/lxc_driver.c                          | 103 ++-
src/openvz/openvz_conf.c                      |   2 +-
src/qemu/qemu_backup.c                        |  24 +-
src/qemu/qemu_checkpoint.c                    |  12 +-
src/qemu/qemu_conf.c                          |   7 +-
src/qemu/qemu_domain.c                        |  83 ++-
src/qemu/qemu_domain.h                        |   3 +-
src/qemu/qemu_domainjob.c                     | 560 ++-------------
src/qemu/qemu_domainjob.h                     |  25 +-
src/qemu/qemu_driver.c                        | 482 +++++++------
src/qemu/qemu_migration.c                     | 201 +++---
src/qemu/qemu_migration_cookie.c              |  17 +-
src/qemu/qemu_migration_cookie.h              |   3 +-
src/qemu/qemu_migration_params.c              |   8 +-
src/qemu/qemu_process.c                       |  95 ++-
src/qemu/qemu_snapshot.c                      |  20 +-
src/security/virt-aa-helper.c                 |   2 +-
src/test/test_driver.c                        |   2 +-
src/vbox/vbox_common.c                        |   2 +-
src/vmware/vmware_driver.c                    |   2 +-
src/vmx/vmx.c                                 |   2 +-
src/vz/vz_driver.c                            |   2 +-
tests/bhyveargv2xmltest.c                     |   2 +-
tests/qemumigrationcookiexmltest.c            |   3 +-
tests/testutils.c                             |   2 +-
50 files changed, 1476 insertions(+), 1771 deletions(-)
create mode 100644 src/conf/virdomainjob.c
rename src/{hypervisor/domain_job.h => conf/virdomainjob.h} (86%)
delete mode 100644 src/hypervisor/domain_job.c
[PATCH v2 00/17] jobs: finish generalization
Posted by Kristina Hanicova 1 year, 7 months ago
v1 here: https://listman.redhat.com/archives/libvir-list/2022-August/233908.html

diff to v1:
* changes in the first commit: typo, currentAPI in warning I forgot to
move and renamed VIR_FROM_HYPERV to VIR_FROM_NONE as Jano suggested


Kristina Hanicova (17):
  qemu & hypervisor: move qemuDomainObjBeginJobInternal() into
    hypervisor
  libxl: remove usage of virDomainJobData
  move files: hypervisor/domain_job -> conf/virdomainjob
  virdomainjob: add check for callbacks
  conf: extend xmlopt with job config & add job object into domain
    object
  virdomainjob: make drivers use job object in the domain object
  qemu: use virDomainObjBeginJob()
  libxl: use virDomainObjBeginJob()
  LXC: use virDomainObjBeginJob()
  CH: use virDomainObjBeginJob()
  qemu: use virDomainObjEndJob()
  libxl: use virDomainObjEndJob()
  LXC: use virDomainObjEndJob()
  CH: use virDomainObjEndJob()
  qemu & conf: move BeginAgentJob & EndAgentJob into
    src/conf/virdomainjob
  qemu & conf: move BeginAsyncJob & EndAsyncJob into src/conf
  qemu & conf: move BeginNestedJob & BeginJobNowait into src/conf

 docs/kbase/internals/qemu-threads.rst         |  34 +-
 po/POTFILES                                   |   1 +
 src/bhyve/bhyve_domain.c                      |   2 +-
 src/ch/ch_conf.c                              |   2 +-
 src/ch/ch_domain.c                            |  76 --
 src/ch/ch_domain.h                            |  11 +-
 src/ch/ch_driver.c                            |  40 +-
 src/conf/domain_conf.c                        |  14 +-
 src/conf/domain_conf.h                        |  16 +-
 src/conf/meson.build                          |   1 +
 src/conf/virconftypes.h                       |   2 +
 src/conf/virdomainjob.c                       | 665 ++++++++++++++++++
 .../domain_job.h => conf/virdomainjob.h}      |  37 +-
 src/hyperv/hyperv_driver.c                    |   2 +-
 src/hypervisor/domain_job.c                   | 249 -------
 src/hypervisor/meson.build                    |   1 -
 src/libvirt_private.syms                      |  52 +-
 src/libxl/libxl_conf.c                        |   2 +-
 src/libxl/libxl_domain.c                      | 113 +--
 src/libxl/libxl_domain.h                      |  18 +-
 src/libxl/libxl_driver.c                      | 123 ++--
 src/libxl/libxl_migration.c                   |  20 +-
 src/lxc/lxc_conf.c                            |   2 +-
 src/lxc/lxc_domain.c                          |  86 ---
 src/lxc/lxc_domain.h                          |  14 +-
 src/lxc/lxc_driver.c                          | 103 ++-
 src/openvz/openvz_conf.c                      |   2 +-
 src/qemu/qemu_backup.c                        |  24 +-
 src/qemu/qemu_checkpoint.c                    |  12 +-
 src/qemu/qemu_conf.c                          |   7 +-
 src/qemu/qemu_domain.c                        |  83 ++-
 src/qemu/qemu_domain.h                        |   3 +-
 src/qemu/qemu_domainjob.c                     | 560 ++-------------
 src/qemu/qemu_domainjob.h                     |  25 +-
 src/qemu/qemu_driver.c                        | 482 +++++++------
 src/qemu/qemu_migration.c                     | 201 +++---
 src/qemu/qemu_migration_cookie.c              |  17 +-
 src/qemu/qemu_migration_cookie.h              |   3 +-
 src/qemu/qemu_migration_params.c              |   8 +-
 src/qemu/qemu_process.c                       |  95 ++-
 src/qemu/qemu_snapshot.c                      |  20 +-
 src/security/virt-aa-helper.c                 |   2 +-
 src/test/test_driver.c                        |   2 +-
 src/vbox/vbox_common.c                        |   2 +-
 src/vmware/vmware_driver.c                    |   2 +-
 src/vmx/vmx.c                                 |   2 +-
 src/vz/vz_driver.c                            |   2 +-
 tests/bhyveargv2xmltest.c                     |   2 +-
 tests/qemumigrationcookiexmltest.c            |   3 +-
 tests/testutils.c                             |   2 +-
 50 files changed, 1476 insertions(+), 1771 deletions(-)
 create mode 100644 src/conf/virdomainjob.c
 rename src/{hypervisor/domain_job.h => conf/virdomainjob.h} (86%)
 delete mode 100644 src/hypervisor/domain_job.c

-- 
2.37.2
Re: [PATCH v2 00/17] jobs: finish generalization
Posted by Ján Tomko 1 year, 7 months ago
On a Monday in 2022, Kristina Hanicova wrote:
>v1 here: https://listman.redhat.com/archives/libvir-list/2022-August/233908.html
>
>diff to v1:
>* changes in the first commit: typo, currentAPI in warning I forgot to
>move and renamed VIR_FROM_HYPERV to VIR_FROM_NONE as Jano suggested
>
>
>Kristina Hanicova (17):
>  qemu & hypervisor: move qemuDomainObjBeginJobInternal() into
>    hypervisor
>  libxl: remove usage of virDomainJobData
>  move files: hypervisor/domain_job -> conf/virdomainjob
>  virdomainjob: add check for callbacks
>  conf: extend xmlopt with job config & add job object into domain
>    object
>  virdomainjob: make drivers use job object in the domain object
>  qemu: use virDomainObjBeginJob()
>  libxl: use virDomainObjBeginJob()
>  LXC: use virDomainObjBeginJob()
>  CH: use virDomainObjBeginJob()
>  qemu: use virDomainObjEndJob()
>  libxl: use virDomainObjEndJob()
>  LXC: use virDomainObjEndJob()
>  CH: use virDomainObjEndJob()
>  qemu & conf: move BeginAgentJob & EndAgentJob into
>    src/conf/virdomainjob
>  qemu & conf: move BeginAsyncJob & EndAsyncJob into src/conf
>  qemu & conf: move BeginNestedJob & BeginJobNowait into src/conf
>
> docs/kbase/internals/qemu-threads.rst         |  34 +-
> po/POTFILES                                   |   1 +
> src/bhyve/bhyve_domain.c                      |   2 +-
> src/ch/ch_conf.c                              |   2 +-
> src/ch/ch_domain.c                            |  76 --
> src/ch/ch_domain.h                            |  11 +-
> src/ch/ch_driver.c                            |  40 +-
> src/conf/domain_conf.c                        |  14 +-
> src/conf/domain_conf.h                        |  16 +-
> src/conf/meson.build                          |   1 +
> src/conf/virconftypes.h                       |   2 +
> src/conf/virdomainjob.c                       | 665 ++++++++++++++++++
> .../domain_job.h => conf/virdomainjob.h}      |  37 +-
> src/hyperv/hyperv_driver.c                    |   2 +-
> src/hypervisor/domain_job.c                   | 249 -------
> src/hypervisor/meson.build                    |   1 -
> src/libvirt_private.syms                      |  52 +-
> src/libxl/libxl_conf.c                        |   2 +-
> src/libxl/libxl_domain.c                      | 113 +--
> src/libxl/libxl_domain.h                      |  18 +-
> src/libxl/libxl_driver.c                      | 123 ++--
> src/libxl/libxl_migration.c                   |  20 +-
> src/lxc/lxc_conf.c                            |   2 +-
> src/lxc/lxc_domain.c                          |  86 ---
> src/lxc/lxc_domain.h                          |  14 +-
> src/lxc/lxc_driver.c                          | 103 ++-
> src/openvz/openvz_conf.c                      |   2 +-
> src/qemu/qemu_backup.c                        |  24 +-
> src/qemu/qemu_checkpoint.c                    |  12 +-
> src/qemu/qemu_conf.c                          |   7 +-
> src/qemu/qemu_domain.c                        |  83 ++-
> src/qemu/qemu_domain.h                        |   3 +-
> src/qemu/qemu_domainjob.c                     | 560 ++-------------
> src/qemu/qemu_domainjob.h                     |  25 +-
> src/qemu/qemu_driver.c                        | 482 +++++++------
> src/qemu/qemu_migration.c                     | 201 +++---
> src/qemu/qemu_migration_cookie.c              |  17 +-
> src/qemu/qemu_migration_cookie.h              |   3 +-
> src/qemu/qemu_migration_params.c              |   8 +-
> src/qemu/qemu_process.c                       |  95 ++-
> src/qemu/qemu_snapshot.c                      |  20 +-
> src/security/virt-aa-helper.c                 |   2 +-
> src/test/test_driver.c                        |   2 +-
> src/vbox/vbox_common.c                        |   2 +-
> src/vmware/vmware_driver.c                    |   2 +-
> src/vmx/vmx.c                                 |   2 +-
> src/vz/vz_driver.c                            |   2 +-
> tests/bhyveargv2xmltest.c                     |   2 +-
> tests/qemumigrationcookiexmltest.c            |   3 +-
> tests/testutils.c                             |   2 +-
> 50 files changed, 1476 insertions(+), 1771 deletions(-)
> create mode 100644 src/conf/virdomainjob.c
> rename src/{hypervisor/domain_job.h => conf/virdomainjob.h} (86%)
> delete mode 100644 src/hypervisor/domain_job.c
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano