[PATCH 1/7] util: virFileIsSharedFSType: Pass bitmap of checked fs types as unsigned

Peter Krempa posted 7 patches 3 years, 5 months ago
[PATCH 1/7] util: virFileIsSharedFSType: Pass bitmap of checked fs types as unsigned
Posted by Peter Krempa 3 years, 5 months ago
We populate the bits individualy so unsigned is the proper type.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/util/virfile.c | 4 ++--
 src/util/virfile.h | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/util/virfile.c b/src/util/virfile.c
index ce541b8946..1def05b6c4 100644
--- a/src/util/virfile.c
+++ b/src/util/virfile.c
@@ -3394,7 +3394,7 @@ virFileIsSharedFixFUSE(const char *path,

 int
 virFileIsSharedFSType(const char *path,
-                      int fstypes)
+                      unsigned int fstypes)
 {
     g_autofree char *dirpath = NULL;
     char *p = NULL;
@@ -3601,7 +3601,7 @@ virFileFindHugeTLBFS(virHugeTLBFS **ret_fs,
 #else /* defined __linux__ */

 int virFileIsSharedFSType(const char *path G_GNUC_UNUSED,
-                          int fstypes G_GNUC_UNUSED)
+                          unsigned int fstypes G_GNUC_UNUSED)
 {
     /* XXX implement me :-) */
     return 0;
diff --git a/src/util/virfile.h b/src/util/virfile.h
index 4af1ad9136..8d6df034f8 100644
--- a/src/util/virfile.h
+++ b/src/util/virfile.h
@@ -224,7 +224,7 @@ enum {
     VIR_FILE_SHFS_ACFS = (1 << 9),
 };

-int virFileIsSharedFSType(const char *path, int fstypes) ATTRIBUTE_NONNULL(1);
+int virFileIsSharedFSType(const char *path, unsigned int fstypes) ATTRIBUTE_NONNULL(1);
 int virFileIsSharedFS(const char *path) ATTRIBUTE_NONNULL(1);
 int virFileIsClusterFS(const char *path) ATTRIBUTE_NONNULL(1);
 int virFileIsMountPoint(const char *file) ATTRIBUTE_NONNULL(1);
-- 
2.37.1
Re: [PATCH 1/7] util: virFileIsSharedFSType: Pass bitmap of checked fs types as unsigned
Posted by Ján Tomko 3 years, 5 months ago
On a Monday in 2022, Peter Krempa wrote:
>We populate the bits individualy so unsigned is the proper type.

*individually

>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/util/virfile.c | 4 ++--
> src/util/virfile.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano