On Tue, Aug 2, 2022 at 12:28 PM Michal Privoznik <mprivozn@redhat.com>
wrote:
> Technically, this is a v2 of:
>
> https://listman.redhat.com/archives/libvir-list/2022-July/233306.html
>
> but not really. Because I've discarded the 3/3 from original series and
> implemented Andrea's idea.
>
> Michal Prívozník (4):
> src: Export virDomainTPMVersion enum conversion helpers
> testutilsqemu: Fake TPM versions
> qemu_validate: Validate TPM version
> qemuxml2argvtest: Add negative cases for TPM version
>
> src/libvirt_private.syms | 2 ++
> src/qemu/qemu_validate.c | 15 ++++++++++++---
> tests/domaincapsdata/qemu_3.1.0-q35.x86_64.xml | 3 +++
> tests/domaincapsdata/qemu_3.1.0-tcg.x86_64.xml | 3 +++
> tests/domaincapsdata/qemu_3.1.0.x86_64.xml | 3 +++
> tests/domaincapsdata/qemu_4.0.0-q35.x86_64.xml | 3 +++
> tests/domaincapsdata/qemu_4.0.0-tcg.x86_64.xml | 3 +++
> tests/domaincapsdata/qemu_4.0.0.x86_64.xml | 3 +++
> tests/domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 3 +++
> tests/domaincapsdata/qemu_4.1.0-tcg.x86_64.xml | 3 +++
> tests/domaincapsdata/qemu_4.1.0.x86_64.xml | 3 +++
> tests/domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 3 +++
> tests/domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 3 +++
> tests/domaincapsdata/qemu_4.2.0.ppc64.xml | 3 +++
> tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 3 +++
> tests/domaincapsdata/qemu_5.0.0-q35.x86_64.xml | 3 +++
> tests/domaincapsdata/qemu_5.0.0-tcg.x86_64.xml | 3 +++
> .../domaincapsdata/qemu_5.0.0-virt.aarch64.xml | 3 +++
> tests/domaincapsdata/qemu_5.0.0.aarch64.xml | 3 +++
> tests/domaincapsdata/qemu_5.0.0.ppc64.xml | 3 +++
> tests/domaincapsdata/qemu_5.0.0.x86_64.xml | 3 +++
> tests/domaincapsdata/qemu_5.1.0-q35.x86_64.xml | 3 +++
> tests/domaincapsdata/qemu_5.1.0-tcg.x86_64.xml | 3 +++
> tests/domaincapsdata/qemu_5.1.0.x86_64.xml | 3 +++
> tests/domaincapsdata/qemu_5.2.0-q35.x86_64.xml | 3 +++
> tests/domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 3 +++
> .../domaincapsdata/qemu_5.2.0-virt.aarch64.xml | 3 +++
> tests/domaincapsdata/qemu_5.2.0.aarch64.xml | 3 +++
> tests/domaincapsdata/qemu_5.2.0.ppc64.xml | 3 +++
> tests/domaincapsdata/qemu_5.2.0.x86_64.xml | 3 +++
> tests/domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 4 ++++
> tests/domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 4 ++++
> .../domaincapsdata/qemu_6.0.0-virt.aarch64.xml | 4 ++++
> tests/domaincapsdata/qemu_6.0.0.aarch64.xml | 4 ++++
> tests/domaincapsdata/qemu_6.0.0.x86_64.xml | 4 ++++
> tests/domaincapsdata/qemu_6.1.0-q35.x86_64.xml | 4 ++++
> tests/domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 4 ++++
> tests/domaincapsdata/qemu_6.1.0.x86_64.xml | 4 ++++
> tests/domaincapsdata/qemu_6.2.0-q35.x86_64.xml | 4 ++++
> tests/domaincapsdata/qemu_6.2.0-tcg.x86_64.xml | 4 ++++
> .../domaincapsdata/qemu_6.2.0-virt.aarch64.xml | 4 ++++
> tests/domaincapsdata/qemu_6.2.0.aarch64.xml | 4 ++++
> tests/domaincapsdata/qemu_6.2.0.ppc64.xml | 4 ++++
> tests/domaincapsdata/qemu_6.2.0.x86_64.xml | 4 ++++
> tests/domaincapsdata/qemu_7.0.0-q35.x86_64.xml | 3 +++
> tests/domaincapsdata/qemu_7.0.0-tcg.x86_64.xml | 3 +++
> .../domaincapsdata/qemu_7.0.0-virt.aarch64.xml | 3 +++
> tests/domaincapsdata/qemu_7.0.0.aarch64.xml | 3 +++
> tests/domaincapsdata/qemu_7.0.0.ppc64.xml | 3 +++
> tests/domaincapsdata/qemu_7.0.0.x86_64.xml | 3 +++
> tests/domaincapsdata/qemu_7.1.0-q35.x86_64.xml | 3 +++
> tests/domaincapsdata/qemu_7.1.0-tcg.x86_64.xml | 3 +++
> tests/domaincapsdata/qemu_7.1.0.x86_64.xml | 3 +++
> tests/domaincapstest.c | 17 ++++++++++++++++-
> .../tpm-emulator-tpm2.x86_64-latest.err | 1 +
> .../tpm-emulator.x86_64-latest.err | 1 +
> tests/qemuxml2argvtest.c | 6 ++++++
> tests/testutilsqemu.c | 13 +++++++++++--
> tests/testutilsqemu.h | 3 +++
> 59 files changed, 219 insertions(+), 6 deletions(-)
> create mode 100644
> tests/qemuxml2argvdata/tpm-emulator-tpm2.x86_64-latest.err
> create mode 100644 tests/qemuxml2argvdata/tpm-emulator.x86_64-latest.err
>
>
Reviewed-by: Kristina Hanicova <khanicov@redhat.com>
Good job Michal!
Kristina