[PATCH 61/80] qemu: block: Remove unused qemuBlockStorageSourceChainDetachPrepareLegacy

Peter Krempa posted 80 patches 3 years, 4 months ago
[PATCH 61/80] qemu: block: Remove unused qemuBlockStorageSourceChainDetachPrepareLegacy
Posted by Peter Krempa 3 years, 4 months ago
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_block.c | 26 --------------------------
 src/qemu/qemu_block.h |  3 ---
 2 files changed, 29 deletions(-)

diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index 6e643598bc..a5d9f47ec4 100644
--- a/src/qemu/qemu_block.c
+++ b/src/qemu/qemu_block.c
@@ -1657,32 +1657,6 @@ qemuBlockStorageSourceChainDetachPrepareBlockdev(virStorageSource *src)
 }


-/**
- * qemuBlockStorageSourceChainDetachPrepareLegacy
- * @src: storage source chain to remove
- * @driveAlias: Alias of the 'drive' backend (always consumed)
- *
- * Prepares qemuBlockStorageSourceChainData *for detaching @src and its
- * backingStore if -drive was used.
- */
-qemuBlockStorageSourceChainData *
-qemuBlockStorageSourceChainDetachPrepareDrive(virStorageSource *src,
-                                              char *driveAlias)
-{
-    g_autoptr(qemuBlockStorageSourceAttachData) backend = NULL;
-    g_autoptr(qemuBlockStorageSourceChainData) data = NULL;
-
-    data = g_new0(qemuBlockStorageSourceChainData, 1);
-
-    if (!(backend = qemuBlockStorageSourceDetachPrepare(src, driveAlias)))
-        return NULL;
-
-    VIR_APPEND_ELEMENT(data->srcdata, data->nsrcdata, backend);
-
-    return g_steal_pointer(&data);
-}
-
-
 /**
  * qemuBlockStorageSourceChainDetachPrepareChardev
  * @src: storage source chain to remove
diff --git a/src/qemu/qemu_block.h b/src/qemu/qemu_block.h
index 422c1a0deb..a20a5e8a61 100644
--- a/src/qemu/qemu_block.h
+++ b/src/qemu/qemu_block.h
@@ -150,9 +150,6 @@ qemuBlockStorageSourceChainDataFree(qemuBlockStorageSourceChainData *data);
 qemuBlockStorageSourceChainData *
 qemuBlockStorageSourceChainDetachPrepareBlockdev(virStorageSource *src);
 qemuBlockStorageSourceChainData *
-qemuBlockStorageSourceChainDetachPrepareDrive(virStorageSource *src,
-                                              char *driveAlias);
-qemuBlockStorageSourceChainData *
 qemuBlockStorageSourceChainDetachPrepareChardev(char *chardevAlias);

 int
-- 
2.36.1
Re: [PATCH 61/80] qemu: block: Remove unused qemuBlockStorageSourceChainDetachPrepareLegacy
Posted by Pavel Hrdina 3 years, 4 months ago
On Tue, Jul 26, 2022 at 04:37:39PM +0200, Peter Krempa wrote:
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  src/qemu/qemu_block.c | 26 --------------------------
>  src/qemu/qemu_block.h |  3 ---
>  2 files changed, 29 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>